App\Http\Middleware\CheckIfAdmin

Complexity

Total Complexity

7

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	checkIfUserIsAdmin()	0	3	1
A	handle()	0	11	3
A	respondToUnauthorizedRequest()	0	6	3

<?php

namespace App\Http\Middleware;

use Closure;

class CheckIfAdmin
{
    /**
     * Checked that the logged in user is an administrator.
     *
     * --------------
     * VERY IMPORTANT
     * --------------
     * If you have both regular users and admins inside the same table,
     * change the contents of this method to check that the logged in user
     * is an admin, and not a regular user.
     *
     * @param [type] $user [description]

The doc comment [type] at position 0 could not be parsed: Unknown type name '[' at position 0 in [type].

Parameter comment must start with a capital letter

Parameter comment must end with a full stop

     *
     * @return bool [description]

Expected "boolean" but found "bool" for function return type

     */
    private function checkIfUserIsAdmin($user)

Method \App\Http\Middleware\CheckIfAdmin::checkIfUserIsAdmin() does not have parameter type hint for its parameter $user but it should be possible to add it based on @param annotation "[type]".

Method \App\Http\Middleware\CheckIfAdmin::checkIfUserIsAdmin() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool".

Type hint "[type]" missing for $user

    {
        return ($user->hasRole('admin'));
    }

    /**
     * Answer to unauthorized access request.
     *
     * @param [type] $request [description]

The doc comment [type] at position 0 could not be parsed: Unknown type name '[' at position 0 in [type].

Parameter comment must start with a capital letter

Parameter comment must end with a full stop

     *
     * @return [type] [description]

The doc comment [type] at position 0 could not be parsed: Unknown type name '[' at position 0 in [type].

     */
    private function respondToUnauthorizedRequest($request)

Method \App\Http\Middleware\CheckIfAdmin::respondToUnauthorizedRequest() does not have parameter type hint for its parameter $request but it should be possible to add it based on @param annotation "[type]".

Method \App\Http\Middleware\CheckIfAdmin::respondToUnauthorizedRequest() does not have return type hint for its return value but it should be possible to add it based on @return annotation "[type]".

Type hint "[type]" missing for $request

    {
        if ($request->ajax() || $request->wantsJson()) {
            return response(trans('backpack::base.unauthorized'), 401);
        } else {
            return redirect()->guest(backpack_url('login'));
        }
    }

    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request

Missing parameter comment

     * @param \Closure                 $next

Missing parameter comment

     *
     * @return mixed
     */
    public function handle($request, Closure $next)

Method \App\Http\Middleware\CheckIfAdmin::handle() does not have parameter type hint for its parameter $request but it should be possible to add it based on @param annotation "\Illuminate\Http\Request".

Type hint "\Illuminate\Http\Request" missing for $request

    {
        if (backpack_auth()->guest()) {
            return $this->respondToUnauthorizedRequest($request);
        }

        if (!$this->checkIfUserIsAdmin(backpack_user())) {
            return $this->respondToUnauthorizedRequest($request);
        }

        return $next($request);
    }
}