Passed
Push — feature/immutable-application-... ( 724692...212613 )
by Chris
34:25 queued 17:29
created
app/Http/ViewComposers/ReferenceComposer.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -20,13 +20,13 @@
 block discarded – undo
20 20
      *
21 21
      * @return void
22 22
      */
23
-    public function compose(View $view) : void
23
+    public function compose (View $view) : void
24 24
     {
25 25
         if (!$this->relationships) {
26
-            $this->relationships = Relationship::all();
26
+            $this->relationships = Relationship::all ();
27 27
         }
28 28
 
29
-        $view->with('relationships', $this->relationships);
30
-        $view->with('reference_template', Lang::get('common/references'));
29
+        $view->with ('relationships', $this->relationships);
30
+        $view->with ('reference_template', Lang::get ('common/references'));
31 31
     }
32 32
 }
Please login to merge, or discard this patch.
app/Http/ViewComposers/CourseComposer.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -20,13 +20,13 @@
 block discarded – undo
20 20
      *
21 21
      * @return void
22 22
      */
23
-    public function compose(View $view) : void
23
+    public function compose (View $view) : void
24 24
     {
25 25
         if (!$this->courseStatuses) {
26
-            $this->courseStatuses = CourseStatus::all();
26
+            $this->courseStatuses = CourseStatus::all ();
27 27
         }
28 28
 
29
-        $view->with('course_status', $this->courseStatuses);
30
-        $view->with('course_template', Lang::get('common/course'));
29
+        $view->with ('course_status', $this->courseStatuses);
30
+        $view->with ('course_template', Lang::get ('common/course'));
31 31
     }
32 32
 }
Please login to merge, or discard this patch.
app/Http/ViewComposers/GocComposer.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -13,8 +13,8 @@
 block discarded – undo
13 13
      * @param  View  $view
14 14
      * @return void
15 15
      */
16
-    public function compose(View $view)
16
+    public function compose (View $view)
17 17
     {
18
-        $view->with('goc', Lang::get('common/goc'));
18
+        $view->with ('goc', Lang::get ('common/goc'));
19 19
     }
20 20
 }
Please login to merge, or discard this patch.
app/Http/Controllers/ApplicationReviewController.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -17,31 +17,31 @@
 block discarded – undo
17 17
      * @param  \App\Models\JobApplication $application Incoming Application.
18 18
      * @return \Illuminate\Http\Response
19 19
      */
20
-    public function updateForApplication(Request $request, JobApplication $application)
20
+    public function updateForApplication (Request $request, JobApplication $application)
21 21
     {
22
-        $request->validate([
22
+        $request->validate ([
23 23
             'review_status_id' => [
24 24
                 'nullable',
25
-                Rule::in(ReviewStatus::all()->pluck('id')->toArray())
25
+                Rule::in (ReviewStatus::all ()->pluck ('id')->toArray ())
26 26
             ],
27 27
             'notes' => 'nullable|string'
28 28
         ]);
29 29
 
30 30
         $review = $application->application_review;
31 31
         if ($review === null) {
32
-            $review = new ApplicationReview();
33
-            $review->job_application()->associate($application);
32
+            $review = new ApplicationReview ();
33
+            $review->job_application ()->associate ($application);
34 34
         }
35
-        $review->fill([
36
-            'review_status_id' => $request->input('review_status_id'),
37
-            'notes' => $request->input('notes'),
35
+        $review->fill ([
36
+            'review_status_id' => $request->input ('review_status_id'),
37
+            'notes' => $request->input ('notes'),
38 38
         ]);
39
-        $review->save();
39
+        $review->save ();
40 40
 
41
-        if ($request->ajax()) {
42
-            return $review->fresh()->toJson();
41
+        if ($request->ajax ()) {
42
+            return $review->fresh ()->toJson ();
43 43
         }
44 44
 
45
-        return redirect()->back();
45
+        return redirect ()->back ();
46 46
     }
47 47
 }
Please login to merge, or discard this patch.
app/Http/Controllers/FaqController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -12,13 +12,13 @@
 block discarded – undo
12 12
      *
13 13
      * @return View
14 14
      */
15
-    public function __invoke()
15
+    public function __invoke ()
16 16
     {
17
-        return view(
17
+        return view (
18 18
             'applicant/static_faq',
19 19
             [
20
-                'faq' => Lang::get('applicant/faq'),
21
-                'breadcrumb_home' => route('home'),
20
+                'faq' => Lang::get ('applicant/faq'),
21
+                'breadcrumb_home' => route ('home'),
22 22
                 'applicant_sidebar_active' => 'active',
23 23
             ]
24 24
         );
Please login to merge, or discard this patch.
app/Http/Controllers/ApplicationController.php 1 patch
Spacing   +29 added lines, -30 removed lines patch added patch discarded remove patch
@@ -17,15 +17,15 @@  discard block
 block discarded – undo
17 17
      *
18 18
      * @return \Illuminate\Http\Response
19 19
      */
20
-    public function index()
20
+    public function index ()
21 21
     {
22
-        $applications = Auth::user()->applicant->job_applications;
23
-        return view(
22
+        $applications = Auth::user ()->applicant->job_applications;
23
+        return view (
24 24
             'applicant/application_index',
25 25
             [
26
-                'application_index' => Lang::get('applicant/application_index'),
26
+                'application_index' => Lang::get ('applicant/application_index'),
27 27
                 'applications' => $applications,
28
-                'departments_template' => Lang::get('common/lookup/departments'),
28
+                'departments_template' => Lang::get ('common/lookup/departments'),
29 29
                 'manager_profile_photo' => '/images/user.png', // TODO: get real photo.
30 30
             ]
31 31
         );
@@ -37,30 +37,29 @@  discard block
 block discarded – undo
37 37
      * @param  \App\Models\JobApplication $application Incoming Application object.
38 38
      * @return \Illuminate\Http\Response
39 39
      */
40
-    public function show(JobApplication $application)
40
+    public function show (JobApplication $application)
41 41
     {
42 42
         $criteria = [
43
-            'essential' => $application->job_poster->criteria->filter(function ($value, $key) {
43
+            'essential' => $application->job_poster->criteria->filter (function ($value, $key) {
44 44
                 return $value->criteria_type->name == 'essential';
45 45
             }),
46
-            'asset' => $application->job_poster->criteria->filter(function ($value, $key) {
46
+            'asset' => $application->job_poster->criteria->filter (function ($value, $key) {
47 47
                 return $value->criteria_type->name == 'asset';
48 48
             }),
49 49
         ];
50 50
 
51 51
         // Display slightly different views on different portals.
52
-        $view = WhichPortal::isManagerPortal() ?
53
-            'manager/application_post' :
54
-            'applicant/application_preview';
52
+        $view = WhichPortal::isManagerPortal () ?
53
+            'manager/application_post' : 'applicant/application_preview';
55 54
 
56
-        if (WhichPortal::isManagerPortal()) {
55
+        if (WhichPortal::isManagerPortal ()) {
57 56
             // Load things required for review component.
58
-            $application->load(['veteran_status', 'citizenship_declaration', 'application_review', 'applicant.user']);
57
+            $application->load (['veteran_status', 'citizenship_declaration', 'application_review', 'applicant.user']);
59 58
         }
60 59
 
61 60
 
62 61
         // If the application status is draft then get data through the applicant model. Else, grab the data from the application itself.
63
-        if ($application->isDraft()) {
62
+        if ($application->isDraft ()) {
64 63
             $source = $application->applicant;
65 64
         } else {
66 65
             $source = $application;
@@ -73,23 +72,23 @@  discard block
 block discarded – undo
73 72
         $references = $source->references;
74 73
         $work_samples = $source->work_samples;
75 74
 
76
-        return view(
75
+        return view (
77 76
             $view,
78 77
             [
79 78
                 // Localized strings.
80
-                'post' => Lang::get('manager/application_post'), // Change text
81
-                'is_manager_view' => WhichPortal::isManagerPortal(),
79
+                'post' => Lang::get ('manager/application_post'), // Change text
80
+                'is_manager_view' => WhichPortal::isManagerPortal (),
82 81
                 // Application Template Data.
83
-                'application_template' => Lang::get('applicant/application_template'),
84
-                'citizenship_declaration_template' => Lang::get('common/citizenship_declaration'),
85
-                'veteran_status_template' => Lang::get('common/veteran_status'),
82
+                'application_template' => Lang::get ('applicant/application_template'),
83
+                'citizenship_declaration_template' => Lang::get ('common/citizenship_declaration'),
84
+                'veteran_status_template' => Lang::get ('common/veteran_status'),
86 85
                 // Job Data.
87 86
                 'job' => $application->job_poster,
88 87
                 // Skills Data.
89
-                'skills' => Skill::all(),
90
-                'skill_template' => Lang::get('common/skills'),
91
-                'reference_template' => Lang::get('common/references'),
92
-                'sample_template' => Lang::get('common/work_samples'),
88
+                'skills' => Skill::all (),
89
+                'skill_template' => Lang::get ('common/skills'),
90
+                'reference_template' => Lang::get ('common/references'),
91
+                'sample_template' => Lang::get ('common/work_samples'),
93 92
                 'criteria' => $criteria,
94 93
                 // Applicant Data.
95 94
                 'applicant' => $application->applicant,
@@ -100,7 +99,7 @@  discard block
 block discarded – undo
100 99
                 'skill_declarations' => $skill_declarations,
101 100
                 'references' => $references,
102 101
                 'work_samples' => $work_samples,
103
-                'review_statuses' => ReviewStatus::all(),
102
+                'review_statuses' => ReviewStatus::all (),
104 103
             ]
105 104
         );
106 105
     }
@@ -112,18 +111,18 @@  discard block
 block discarded – undo
112 111
      * @param  \App\Models\JobApplication $application Incoming Application object.
113 112
      * @return \Illuminate\Http\Response
114 113
      */
115
-    public function destroy(Request $request, JobApplication $application)
114
+    public function destroy (Request $request, JobApplication $application)
116 115
     {
117
-        $this->authorize('delete', $application);
116
+        $this->authorize ('delete', $application);
118 117
 
119
-        $application->delete();
118
+        $application->delete ();
120 119
 
121
-        if ($request->ajax()) {
120
+        if ($request->ajax ()) {
122 121
             return [
123 122
                 'message' => 'Application deleted'
124 123
             ];
125 124
         }
126 125
 
127
-        return redirect()->back();
126
+        return redirect ()->back ();
128 127
     }
129 128
 }
Please login to merge, or discard this patch.
app/Http/Controllers/AssessmentPlanController.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -20,41 +20,41 @@
 block discarded – undo
20 20
      * @param  \App\Models\JobPoster $jobPoster Job Poster to retrieve assessment plan for.
21 21
      * @return mixed[]
22 22
      */
23
-    public function getForJob(JobPoster $jobPoster)
23
+    public function getForJob (JobPoster $jobPoster)
24 24
     {
25
-        if (Gate::denies('view-assessment-plan', $jobPoster)) {
26
-            abort(403);
25
+        if (Gate::denies ('view-assessment-plan', $jobPoster)) {
26
+            abort (403);
27 27
         }
28 28
 
29
-        $criteria = Criteria::where('job_poster_id', $jobPoster->id)->get();
29
+        $criteria = Criteria::where ('job_poster_id', $jobPoster->id)->get ();
30 30
         $criteriaTranslated = [];
31 31
         foreach ($criteria as $criterion) {
32 32
             // TODO: getTranslationsArray probably makes DB calls every loop. Find a way to profile & optimize.
33
-            $criteriaTranslated[] = array_merge($criterion->toArray(), $criterion->getTranslationsArray());
33
+            $criteriaTranslated[] = array_merge ($criterion->toArray (), $criterion->getTranslationsArray ());
34 34
         }
35
-        $criteriaIds = $criteria->pluck('id');
36
-        $assessments = Assessment::whereIn('criterion_id', $criteriaIds)->get();
35
+        $criteriaIds = $criteria->pluck ('id');
36
+        $assessments = Assessment::whereIn ('criterion_id', $criteriaIds)->get ();
37 37
         // Check for newly created assessment plan, and initialize any empty criteria to have the
38 38
         // "Narrative Review" option set.
39
-        $assessmentCriteriaIds = $assessments->pluck('criterion_id');
40
-        $emptyAssessments = array_diff($criteriaIds->toArray(), $assessmentCriteriaIds->toArray());
39
+        $assessmentCriteriaIds = $assessments->pluck ('criterion_id');
40
+        $emptyAssessments = array_diff ($criteriaIds->toArray (), $assessmentCriteriaIds->toArray ());
41 41
         if (!empty($emptyAssessments)) {
42
-            $narrativeReview = AssessmentType::where('key', 'narrative_assessment')->first();
42
+            $narrativeReview = AssessmentType::where ('key', 'narrative_assessment')->first ();
43 43
             foreach ($emptyAssessments as $criterionId) {
44
-                Assessment::create([
44
+                Assessment::create ([
45 45
                     'criterion_id' => $criterionId,
46 46
                     'assessment_type_id' => $narrativeReview->id
47 47
                 ]);
48 48
             }
49
-            $assessments = Assessment::whereIn('criterion_id', $criteriaIds)->get();
49
+            $assessments = Assessment::whereIn ('criterion_id', $criteriaIds)->get ();
50 50
         }
51
-        $questions = RatingGuideQuestion::where('job_poster_id', $jobPoster->id)->get();
52
-        $answers = RatingGuideAnswer::whereIn('rating_guide_question_id', $questions->pluck('id'))->get();
51
+        $questions = RatingGuideQuestion::where ('job_poster_id', $jobPoster->id)->get ();
52
+        $answers = RatingGuideAnswer::whereIn ('rating_guide_question_id', $questions->pluck ('id'))->get ();
53 53
         return [
54 54
             'criteria' => $criteriaTranslated,
55
-            'assessments' => $assessments->toArray(),
56
-            'rating_guide_questions' => $questions->toArray(),
57
-            'rating_guide_answers' => $answers->toArray()
55
+            'assessments' => $assessments->toArray (),
56
+            'rating_guide_questions' => $questions->toArray (),
57
+            'rating_guide_answers' => $answers->toArray ()
58 58
         ];
59 59
     }
60 60
 }
Please login to merge, or discard this patch.
app/Http/Controllers/AssessmentController.php 1 patch
Spacing   +33 added lines, -33 removed lines patch added patch discarded remove patch
@@ -16,35 +16,35 @@  discard block
 block discarded – undo
16 16
      * @param  \Illuminate\Http\Request $request Incoming request.
17 17
      * @return \Illuminate\Http\Response
18 18
      */
19
-    public function store(Request $request)
19
+    public function store (Request $request)
20 20
     {
21
-        $this->authorize('create', Assessment::class);
21
+        $this->authorize ('create', Assessment::class);
22 22
 
23 23
         try {
24
-            $criterion_id = (int)$request->json('criterion_id');
25
-            $assessment_type_id = (int)$request->json('assessment_type_id');
26
-            $criteria = Criteria::findOrFail($criterion_id);
27
-            AssessmentType::findOrFail($assessment_type_id);
24
+            $criterion_id = (int) $request->json ('criterion_id');
25
+            $assessment_type_id = (int) $request->json ('assessment_type_id');
26
+            $criteria = Criteria::findOrFail ($criterion_id);
27
+            AssessmentType::findOrFail ($assessment_type_id);
28 28
 
29
-            $assessment = new Assessment([
29
+            $assessment = new Assessment ([
30 30
                 'criterion_id' => $criterion_id,
31 31
                 'assessment_type_id' => $assessment_type_id
32 32
             ]);
33 33
             // Check that this user is allowed to create an Assessment for this criterion.
34
-            $this->authorize('update', $assessment);
34
+            $this->authorize ('update', $assessment);
35 35
 
36
-            $assessment->save();
37
-            $assessment->refresh();
38
-            $assessment['criteria'] = $criteria->toArray();
36
+            $assessment->save ();
37
+            $assessment->refresh ();
38
+            $assessment['criteria'] = $criteria->toArray ();
39 39
         } catch (\Exception $e) {
40
-            return response()->json([
41
-                'error' => $e->getMessage()
40
+            return response ()->json ([
41
+                'error' => $e->getMessage ()
42 42
             ], 400);
43 43
         }
44 44
 
45 45
         return [
46 46
             'success' => "Successfully created assessment $assessment->id",
47
-            'assessment' => $assessment->toArray()
47
+            'assessment' => $assessment->toArray ()
48 48
         ];
49 49
     }
50 50
 
@@ -54,12 +54,12 @@  discard block
 block discarded – undo
54 54
      * @param  \App\Models\Assessment $assessment Incoming object.
55 55
      * @return \Illuminate\Http\Response
56 56
      */
57
-    public function show(Assessment $assessment)
57
+    public function show (Assessment $assessment)
58 58
     {
59
-        $this->authorize('view', $assessment);
60
-        $criteria = Criteria::find($assessment->id);
61
-        $assessment['criteria'] = $criteria->toArray();
62
-        return $assessment->toArray();
59
+        $this->authorize ('view', $assessment);
60
+        $criteria = Criteria::find ($assessment->id);
61
+        $assessment['criteria'] = $criteria->toArray ();
62
+        return $assessment->toArray ();
63 63
     }
64 64
 
65 65
     /**
@@ -69,28 +69,28 @@  discard block
 block discarded – undo
69 69
      * @param  \App\Models\Assessment   $assessment Incoming object.
70 70
      * @return \Illuminate\Http\Response
71 71
      */
72
-    public function update(Request $request, Assessment $assessment)
72
+    public function update (Request $request, Assessment $assessment)
73 73
     {
74
-        $this->authorize('update', $assessment);
74
+        $this->authorize ('update', $assessment);
75 75
         try {
76
-            $criterion_id = (int)$request->json('criterion_id');
77
-            $assessment_type_id = (int)$request->json('assessment_type_id');
78
-            $criteria = Criteria::findOrFail($criterion_id);
79
-            AssessmentType::findOrFail($assessment_type_id);
76
+            $criterion_id = (int) $request->json ('criterion_id');
77
+            $assessment_type_id = (int) $request->json ('assessment_type_id');
78
+            $criteria = Criteria::findOrFail ($criterion_id);
79
+            AssessmentType::findOrFail ($assessment_type_id);
80 80
 
81 81
             $assessment->criterion_id = $criterion_id;
82 82
             $assessment->assessment_type_id = $assessment_type_id;
83
-            $assessment->save();
84
-            $assessment['criteria'] = $criteria->toArray();
83
+            $assessment->save ();
84
+            $assessment['criteria'] = $criteria->toArray ();
85 85
         } catch (\Exception $e) {
86
-            return response()->json([
87
-                'error' => $e->getMessage()
86
+            return response ()->json ([
87
+                'error' => $e->getMessage ()
88 88
             ], 400);
89 89
         }
90 90
 
91 91
         return [
92 92
             'success' => "Successfully updated assessment $assessment->id",
93
-            'assessment' => $assessment->toArray(),
93
+            'assessment' => $assessment->toArray (),
94 94
         ];
95 95
     }
96 96
 
@@ -100,10 +100,10 @@  discard block
 block discarded – undo
100 100
      * @param  \App\Models\Assessment $assessment Incoming object.
101 101
      * @return \Illuminate\Http\Response
102 102
      */
103
-    public function destroy(Assessment $assessment)
103
+    public function destroy (Assessment $assessment)
104 104
     {
105
-        $this->authorize('delete', $assessment);
106
-        $assessment->delete();
105
+        $this->authorize ('delete', $assessment);
106
+        $assessment->delete ();
107 107
 
108 108
         return [
109 109
             'success' => "Successfully deleted assessment $assessment->id"
Please login to merge, or discard this patch.
app/Http/Controllers/AssessmentPlanNotificationController.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -14,15 +14,15 @@  discard block
 block discarded – undo
14 14
      * @param  \Illuminate\Http\Request $request Incoming request.
15 15
      * @return mixed
16 16
      */
17
-    public function index(Request $request)
17
+    public function index (Request $request)
18 18
     {
19 19
         $notificationsArray = [];
20
-        if ($request->has('job_poster_id') && $request->user() != null) {
21
-            $jobPosterId = $request->input('job_poster_id');
22
-            $notifications = AssessmentPlanNotification::where('job_poster_id', $jobPosterId)->get();
20
+        if ($request->has ('job_poster_id') && $request->user () != null) {
21
+            $jobPosterId = $request->input ('job_poster_id');
22
+            $notifications = AssessmentPlanNotification::where ('job_poster_id', $jobPosterId)->get ();
23 23
             foreach ($notifications as $notification) {
24
-                if ($request->user()->can('view', $notification)) {
25
-                    $notificationsArray[] = $notification->toArray();
24
+                if ($request->user ()->can ('view', $notification)) {
25
+                    $notificationsArray[] = $notification->toArray ();
26 26
                 }
27 27
             }
28 28
         }
@@ -35,10 +35,10 @@  discard block
 block discarded – undo
35 35
      * @param  \App\Models\AssessmentPlanNotification $assessmentPlanNotification Incoming object.
36 36
      * @return mixed
37 37
      */
38
-    public function show(AssessmentPlanNotification $assessmentPlanNotification)
38
+    public function show (AssessmentPlanNotification $assessmentPlanNotification)
39 39
     {
40
-        $this->authorize('view', $assessmentPlanNotification);
41
-        return $assessmentPlanNotification->toArray();
40
+        $this->authorize ('view', $assessmentPlanNotification);
41
+        return $assessmentPlanNotification->toArray ();
42 42
     }
43 43
 
44 44
     /**
@@ -49,17 +49,17 @@  discard block
 block discarded – undo
49 49
      * @throws \InvalidArgumentException For missing $question.
50 50
      * @return mixed
51 51
      */
52
-    public function update(Request $request, AssessmentPlanNotification $assessmentPlanNotification)
52
+    public function update (Request $request, AssessmentPlanNotification $assessmentPlanNotification)
53 53
     {
54
-        $this->authorize('update', $assessmentPlanNotification);
55
-        $assessmentPlanNotification->fill([
56
-            'acknowledged' => $request->input('acknowledged')
54
+        $this->authorize ('update', $assessmentPlanNotification);
55
+        $assessmentPlanNotification->fill ([
56
+            'acknowledged' => $request->input ('acknowledged')
57 57
         ]);
58
-        $assessmentPlanNotification->save();
58
+        $assessmentPlanNotification->save ();
59 59
 
60 60
         return [
61 61
             'success' => "Successfully updated assessment plan notification $assessmentPlanNotification->id",
62
-            'assessment_plan_notification' => $assessmentPlanNotification->toArray(),
62
+            'assessment_plan_notification' => $assessmentPlanNotification->toArray (),
63 63
         ];
64 64
     }
65 65
 
@@ -69,10 +69,10 @@  discard block
 block discarded – undo
69 69
      * @param  \App\Models\AssessmentPlanNotification $assessmentPlanNotification Incoming object.
70 70
      * @return mixed
71 71
      */
72
-    public function destroy(AssessmentPlanNotification $assessmentPlanNotification)
72
+    public function destroy (AssessmentPlanNotification $assessmentPlanNotification)
73 73
     {
74
-        $this->authorize('delete', $assessmentPlanNotification);
75
-        $assessmentPlanNotification->delete();
74
+        $this->authorize ('delete', $assessmentPlanNotification);
75
+        $assessmentPlanNotification->delete ();
76 76
 
77 77
         return [
78 78
             'success' => "Successfully deleted assessment plan notification $assessmentPlanNotification->id"
Please login to merge, or discard this patch.