App\Http\Controllers\JobController

Complexity

Total Complexity

18

Size/Duplication

Total Lines	233
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	11	1
A	create()	0	18	2
A	managerIndex()	0	31	4
A	show()	0	31	2
B	store()	0	102	9

<?php

Missing file doc comment

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Auth;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use Carbon\Carbon;
use App\Models\JobPoster;
use App\Models\Lookup\JobTerm;
use App\Models\Lookup\Province;
use App\Models\Lookup\SecurityClearance;
use App\Models\Lookup\LanguageRequirement;
use App\Models\Lookup\CitizenshipDeclaration;
use App\Models\Lookup\Department;
use App\Models\Lookup\SkillLevel;
use App\Models\Lookup\CriteriaType;
use App\Models\Lookup\VeteranStatus;
use App\Models\JobApplication;
use App\Models\Criteria;
use App\Models\Skill;
use App\Models\JobPosterQuestion;
use App\Models\JobPosterKeyTask;
use Jenssegers\Date\Date;

class JobController extends Controller

Missing doc comment for class JobController

{
    /**
     * Display a listing of JobPosters.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $now = Carbon::now();
        //Find published jobs that are currently open for applications
        $jobs = JobPoster::where('open_date_time', '<=', $now)
            ->where('close_date_time', '>=', $now)
            ->where('published', true)
            ->get();
        $jobs->load('manager.work_environment');
        return view('applicant/job_index', ['job_index' => Lang::get('applicant/job_index'),

The expression return view('applicant/job_index', array('job_index' => Illuminate\Support\Facades\Lang::get('applicant/job_index'), 'jobs' => $jobs)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

The opening parenthesis of a multi-line function call should be the last content on the line.

            'jobs' => $jobs]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Display a listing of a manager's JobPosters.
     *
     * @return \Illuminate\Http\Response
     */
    public function managerIndex()
    {
        $manager = Auth::user()->manager;

Accessing manager on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $veteran_applications = [];
        $citizen_applications = [];
        $other_applications = [];

        foreach($manager->job_posters as $job) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            $job->submitted_applications->load(['veteran_status', 'citizenship_declaration']);
            $veteran_applications[$job->id] = $job->submitted_applications->filter(function($application) {

The opening parenthesis of a multi-line function call should be the last content on the line.

                return $application->veteran_status->name !== "none" &&
                        $application->citizenship_declaration->name === "citizen";
            });

For multi-line function calls, the closing parenthesis should be on a new line.

            $citizen_applications[$job->id] = $job->submitted_applications->filter(function($application) {

The opening parenthesis of a multi-line function call should be the last content on the line.

                return $application->veteran_status->name === "none" &&
                        $application->citizenship_declaration->name === "citizen";
            });

For multi-line function calls, the closing parenthesis should be on a new line.

            $other_applications[$job->id] = $job->submitted_applications->filter(function($application) {

The opening parenthesis of a multi-line function call should be the last content on the line.

                return $application->citizenship_declaration->name !== "citizen";
            });

For multi-line function calls, the closing parenthesis should be on a new line.

        }

        return view('manager/job_index', [

The expression return view('manager/job_index', array('manager_job_index' => array('title' => 'My Job Posts'), 'jobs' => $manager->job_posters, 'veteran_applications' => $veteran_applications, 'citizen_applications' => $citizen_applications, 'other_applications' => $other_applications)) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

The opening parenthesis of a multi-line function call should be the last content on the line.

            "manager_job_index" => [
                "title" => "My Job Posts"
            ],
            'jobs' => $manager->job_posters,
            'veteran_applications' => $veteran_applications,
            'citizen_applications' => $citizen_applications,
            'other_applications' => $other_applications,
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Display the specified job poster.
     *
     * @param  Request  $request

Missing parameter comment

Expected 15 spaces after parameter type; 2 found

     * @param  \App\Models\JobPoster  $jobPoster

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function show(Request $request, JobPoster $jobPoster)
    {
        //TODO: Improve workplace photos, and reference them in template direction from WorkEnvironment model
        $workplacePhotos = [];
        foreach($jobPoster->manager->work_environment->workplace_photo_captions as $photoCaption) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            $workplacePhotos[] = [
                'description' => $photoCaption->description,
                'url' => '/images/user.png'
            ];
        }

        //TODO: replace route('manager.show',manager.id) in templates with link using slug

        $criteria = [
            'essential' => $jobPoster->criteria->filter(function($value, $key) {

The opening parenthesis of a multi-line function call should be the last content on the line.

                return $value->criteria_type->name == 'essential';
            }),

For multi-line function calls, the closing parenthesis should be on a new line.

            'asset' => $jobPoster->criteria->filter(function($value, $key) {

The opening parenthesis of a multi-line function call should be the last content on the line.

                return $value->criteria_type->name == 'asset';
            }),

For multi-line function calls, the closing parenthesis should be on a new line.

        ];
        return view('applicant/job_post', [

The expression return view('applicant/job_post', array('job_post' => Illuminate\Support\Facades\Lang::get('applicant/job_post'), 'manager' => $jobPoster->manager, 'manager_profile_photo_url' => '/images/user.png', 'team_culture' => $jobPoster->manager->team_culture, 'work_environment' => $jobPoster->manager->work_environment, 'workplace_photos' => $workplacePhotos, 'job' => $jobPoster, 'criteria' => $criteria, 'skill_template' => Illuminate\Support\Facades\Lang::get('common/skills'))) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

The opening parenthesis of a multi-line function call should be the last content on the line.

            'job_post' =>Lang::get('applicant/job_post'),
            'manager' => $jobPoster->manager,
            'manager_profile_photo_url' => '/images/user.png', //TODO get real photo
            'team_culture' => $jobPoster->manager->team_culture,
            'work_environment' => $jobPoster->manager->work_environment,
            'workplace_photos' => $workplacePhotos,
            'job' => $jobPoster,
            'criteria' => $criteria,
            'skill_template' => Lang::get('common/skills'),
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Display the form for creating a new Job Poster
     * @param  Request $request [description]

There must be exactly one blank line before the tags in a doc comment

     * @return \Illuminate\Http\Response           A view

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function create(Request $request) {
        $manager = $request->user() ? $request->user()->manager : null;

        //No job details exist yet because we're creating a new one
        $job = [];

        return view('manager/job_create', [

The expression return view('manager/job_create', array('job_create' => Illuminate\Support\Facades\Lang::get('manager/job_create'), 'manager' => $manager, 'provinces' => App\Models\Lookup\Province::all(), 'departments' => App\Models\Lookup\Department::all(), 'language_requirments' => App\Models\Lookup\LanguageRequirement::all(), 'security_clearances' => App\Models\Lookup\SecurityClearance::all(), 'job' => $job, 'form_action_url' => route('manager.jobs.store'), 'skills' => App\Models\Skill::all(), 'skill_levels' => App\Models\Lookup\SkillLevel::all(), 'skill_template' => Illuminate\Support\Facades\Lang::get('common/skills'))) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

The opening parenthesis of a multi-line function call should be the last content on the line.

            'job_create' => Lang::get('manager/job_create'),
            'manager' => $manager,
            'provinces' => Province::all(),
            'departments' => Department::all(),
            'language_requirments' => LanguageRequirement::all(),
            'security_clearances' => SecurityClearance::all(),
            'job' => $job,
            'form_action_url' => route('manager.jobs.store'),
            'skills' => Skill::all(),
            'skill_levels' => SkillLevel::all(),
            'skill_template' => Lang::get('common/skills'),
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

    }

    /**
     * Create a new resource in storage
     * @param  Request $request

There must be exactly one blank line before the tags in a doc comment

Missing parameter comment

     * @return \Illuminate\Http\Response           A redirect

Tag cannot be grouped with parameter tags in a doc comment

     */
    public function store(Request $request) {

        $input = $request->input();

        $job = new JobPoster();
        $job->manager_id = $request->user()->manager->id;
        $job->published = ($input['submit'] == 'publish');
        $job->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

            'job_term_id' => JobTerm::where('name', 'month')->firstOrFail()->id,
            'term_qty' => $input['term_qty'],
            'open_date_time' => new Date($input['open_date'].$input['open_time']),
            'close_date_time' => new Date($input['close_date'].$input['close_time']),
            'start_date_time' => new Date($input['start_date_time']),
            'department_id' => $input['department'],
            'province_id' => $input['province'],
            'salary_min' => $input['salary_min'],
            'salary_max' => $input['salary_max'],
            'noc' => $input['noc'],
            'classification' => $input['classification'],
            'security_clearance_id' => $input['security_clearance'],
            'language_requirement_id' => $input['language_requirement'],
            'remote_work_allowed' => $request->input('remote_work_allowed', false),

false of type false is incompatible with the type array|null|string expected by parameter $default of Illuminate\Http\Request::input().

            'en' => [
                'city' => $input['city'],
                'title' => $input['title']['en'],
                'impact' => $input['impact']['en'],
                'branch' => $input['branch']['en'],
                'division' => $input['division']['en'],
                'education' => $input['education']['en'],
            ],
            'fr' => [
                'city' => $input['city'],
                'title' => $input['title']['fr'],
                'impact' => $input['impact']['fr'],
                'branch' => $input['branch']['fr'],
                'division' => $input['division']['fr'],
                'education' => $input['education']['fr'],
            ],
        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

        $job->save();

        if (isset($input['task'])) {
            foreach($input['task'] as $task) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                $jobPosterTask = new JobPosterKeyTask();
                $jobPosterTask->job_poster_id =  $job->id;
                $jobPosterTask->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'en' => [
                        'description' => $task['en']
                    ],
                    'fr' => [
                        'description' => $task['fr']
                    ]
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                $jobPosterTask->save();
            }
        }

        if (isset($input['question'])) {
            foreach($input['question'] as $question) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                $jobQuestion = new JobPosterQuestion();
                $jobQuestion->job_poster_id = $job->id;
                $jobQuestion->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'en'=> [
                        'question' => $question['question']['en'],
                        'description' => $question['description']['en']
                    ],
                    'fr'=> [
                        'question' => $question['question']['fr'],
                        'description' => $question['description']['fr']
                    ]
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                $jobQuestion->save();
            }
        }

        $criteria = $input['criteria'];

        //Save new criteria
        if (isset($criteria['new'])) {
            foreach($criteria['new'] as $criteriaType => $criteriaTypeInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                foreach($criteriaTypeInput as $skillType => $skillTypeInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                    foreach($skillTypeInput as $criteriaInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                        $criteria = new Criteria();
                        $criteria->job_poster_id = $job->id;
                        $criteria->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                            'criteria_type_id' => CriteriaType::where('name', $criteriaType)->firstOrFail()->id,
                            'skill_id' => $criteriaInput['skill_id'],
                            'skill_level_id' => $criteriaInput['skill_level_id'],
                            'en' => [
                                'description' => $criteriaInput['description']['en'],
                            ],
                            'fr' => [
                                'description' => $criteriaInput['description']['fr'],
                            ],
                        ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                        $criteria->save();
                    }
                }
            }
        }

        return redirect( route('manager.jobs.index') );

The expression return redirect(route('manager.jobs.index')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }
}