SendScreenCandidatesEmail::screenCandidatesPrompt() - Code Metrics - Inspection of "Fix spacing, and get correct link for french secti..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/screen-candidates-emai... ( cb6bad...e0463b )

by Yonathan

created 2020-03-09 20:16 UTC

SendScreenCandidatesEmail::screenCandidatesPrompt() A

↳ Parent: Project

Complexity

Conditions	3
Paths	4

Size

Total Lines	57
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	38
c	1
b	0
f	0
dl	0
loc	57
rs	9.312
cc	3
nc	4
nop	1

How to fix Long Method

<?php

namespace App\Listeners;

use App\Events\JobSaved;
use App\Mail\ScreenCandidatesPrompt;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Mail;

class SendScreenCandidatesEmail
{
    /**
     * Create the event listener.
     *
     * @return void
     */
    public function __construct()
    {
    }

    /**
     * Handle the event.
     *
     * @param  JobSaved  $event
     * @return void
     */
    public function handle(JobSaved $event)
    {
        $job = $event->job;

        // If the job poster status has changed to 'assessment' then send email
        if ($job->isDirty('job_poster_status_id') && $job->job_poster_status->key === 'assessment') {
            $manager_email = $job->manager->user->email;
            if (isset($manager_email)) {
                Mail::to($manager_email)->send(new ScreenCandidatesPrompt($job));
            } else {
                Log::error('The screen applicants email to manager has not been set.');
            }
        }
    }
}


1			<?php
2
3			namespace App\Listeners;
4
5			use App\Events\JobSaved;
6			use App\Mail\ScreenCandidatesPrompt;
7			use Illuminate\Support\Facades\Log;
8			use Illuminate\Support\Facades\Mail;
9
10			class SendScreenCandidatesEmail
11			{
12			/**
13			* Create the event listener.
14			*
15			* @return void
16			*/
17			public function __construct()
18			{
19			}
20
21			/**
22			* Handle the event.
23			*
24			* @param JobSaved $event
25			* @return void
26			*/
27			public function handle(JobSaved $event)
28			{
29			$job = $event->job;
30
31			// If the job poster status has changed to 'assessment' then send email
32			if ($job->isDirty('job_poster_status_id') && $job->job_poster_status->key === 'assessment') {
33			$manager_email = $job->manager->user->email;
34			if (isset($manager_email)) {
35			Mail::to($manager_email)->send(new ScreenCandidatesPrompt($job));
36			} else {
37			Log::error('The screen applicants email to manager has not been set.');
38			}
39			}
40			}
41			}
42

GCTC-NTGC / TalentCloud

Push — feature/screen-candidates-emai... ( cb6bad...e0463b )

SendScreenCandidatesEmail::screenCandidatesPrompt() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like