App\Console\Kernel

Complexity

Total Complexity

5

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Test Coverage

Coverage

93.33%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	commands()	0	5	1
A	schedule()	0	8	2
A	osProcessIsRunning()	0	18	2

<?php

namespace App\Console;

use Illuminate\Console\Scheduling\Schedule;
use Illuminate\Foundation\Console\Kernel as ConsoleKernel;

class Kernel extends ConsoleKernel
{
    /**
     * The Artisan commands provided by your application.
     *
     * @var array

@var annotation of property \App\Console\Kernel::$commands does not specify type hint for its items.

     */
    protected $commands = [
        //
    ];

    /**
     * Define the application's command schedule.
     *
     * @param  \Illuminate\Console\Scheduling\Schedule  $schedule

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return void
     */
    protected function schedule(Schedule $schedule)

Method \App\Console\Kernel::schedule() does not have return type hint for its return value but it should be possible to add it based on @return annotation "void".

    {
        // $schedule->command('inspire')
        //          ->hourly();

        // start the queue daemon, if its not running
        if (!$this->osProcessIsRunning('queue:work')) {
            $schedule->command('queue:work')->everyMinute();
        }
    }

    /**
     * Register the commands for the application.
     *
     * @return void
     */
    protected function commands()

Method \App\Console\Kernel::commands() does not have return type hint for its return value but it should be possible to add it based on @return annotation "void".

    {
        $this->load(__DIR__.'/Commands');

        require base_path('routes/console.php');
    }

    /**
     * checks, if a process with $needle in the name is running
     *
     * @param string $needle

Missing parameter comment

     * @return bool

Expected "boolean" but found "bool" for function return type

     */
    protected function osProcessIsRunning($needle)

Method \App\Console\Kernel::osProcessIsRunning() does not have parameter type hint for its parameter $needle but it should be possible to add it based on @param annotation "string".

Method \App\Console\Kernel::osProcessIsRunning() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool".

Type hint "string" missing for $needle

    {
        // get process status. the "-ww"-option is important to get the full output!
        exec('ps aux -ww', $process_status);


        // search $needle in process status
        $result = array_filter($process_status,
            function($var) use ($needle)

Expected 1 space after FUNCTION keyword; 0 found

            {   return strpos($var, $needle); });

Opening brace should be on the same line as the declaration

Opening brace must be the last content on the line

It is generally recommended to place each PHP statement on a line by itself.

        // if the result is not empty, the needle exists in running processes
        if (!empty($result)) {
            return true;
        }

        return false;
    }
}