App\Models\RatingGuideAnswer

Complexity

Total Complexity

4

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	criterion()	0	3	1
A	rating_guide_question()	0	3	1
A	setCriterionIdAttribute()	0	6	2

<?php

namespace App\Models;

/**
 * Class RatingGuideQuestion
 *
 * @property int $id
 * @property int $rating_guide_question_id
 * @property int $criterion_id
 * @property string $expected_answer
 * @property \Jenssegers\Date\Date $created_at
 * @property \Jenssegers\Date\Date $updated_at
 *
 * @property \App\Models\RatingGuideQuestion $rating_guide_question
 * @property \App\Models\Criteria $criterion
 */
class RatingGuideAnswer extends BaseModel
{
    /**
     * The columns that can be filled with mass-assignment
     *
     * @var string[]
     */
    protected $fillable = [
        'rating_guide_question_id',
        'criterion_id',
        'expected_answer',
    ];

    /**
     * Mutator for criterion_id. Save NULL instead of empty strings.
     *
     * @param string|null $value Criterion Id, or empty string

Parameter comment must end with a full stop

     * @return void
     */
    public function setCriterionIdAttribute($value): void

Method \App\Models\RatingGuideAnswer::setCriterionIdAttribute() does not have parameter type hint for its parameter $value but it should be possible to add it based on @param annotation "string|null".

    {
        if (empty($value)) { // will check for empty string, null values

Inline comments must start with a capital letter

            $this->attributes['criterion_id'] = null;
        } else {
            $this->attributes['criterion_id'] = $value;
        }
    }

    /**
     * Get the RatingGuideQuestion relation.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    public function rating_guide_question(): \Illuminate\Database\Eloquent\Relations\BelongsTo

Method name "RatingGuideAnswer::rating_guide_question" is not in camel caps format

    {
        return $this->belongsTo(\App\Models\RatingGuideQuestion::class);
    }

    /**
     * Get the Criteria relation.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsTo
     */
    public function criterion(): \Illuminate\Database\Eloquent\Relations\BelongsTo
    {
        return $this->belongsTo(\App\Models\Criteria::class, 'criterion_id');
    }
}