GCTC-NTGC / TalentCloud

app/Services/Validation/ApplicationValidator.php

Spacing +61 added lines, -61 removed lines

@@ -20,14 +20,14 @@ 
     protected $veteran_status_ids;
     protected $preferred_language_ids;
 
-    public function __construct()
+    public function __construct ()
     {
-        $this->citizenship_ids = CitizenshipDeclaration::all()->pluck('id')->toArray();
-        $this->veteran_status_ids = VeteranStatus::all()->pluck('id')->toArray();
-        $this->preferred_language_ids = PreferredLanguage::all()->pluck('id')->toArray();
+        $this->citizenship_ids = CitizenshipDeclaration::all ()->pluck ('id')->toArray ();
+        $this->veteran_status_ids = VeteranStatus::all ()->pluck ('id')->toArray ();
+        $this->preferred_language_ids = PreferredLanguage::all ()->pluck ('id')->toArray ();
     }
 
-    public function validate(JobApplication $application)
+    public function validate (JobApplication $application)
     {
 
         $backendRules = [
@@ -36,30 +36,30 @@ 
             'applicant_id' => 'required'
         ];
 
-        $rules = array_merge(
+        $rules = array_merge (
             $backendRules,
             // $this->basicsValidator($application)->getRules(),
-            $this->experienceValidator($application)->getRules(),
+            $this->experienceValidator ($application)->getRules (),
             // $this->essentialSkillsValidator($application)->getRules(),
-            $this->affirmationValidator($application)->getRules()
+            $this->affirmationValidator ($application)->getRules ()
         );
 
-        $data = $application->toArray();
+        $data = $application->toArray ();
 
         // Combining and simplifiying error messages
-        $rules = array_merge(
+        $rules = array_merge (
             $rules,
             ['application_step_1' => 'required|boolean|accepted'],
             ['application_step_3' => 'required|boolean|accepted']
         );
-        $data = array_merge(
+        $data = array_merge (
             $data,
-            ['application_step_1' => $this->basicsComplete($application)],
-            ['application_step_3' => $this->essentialSkillsComplete($application)]
+            ['application_step_1' => $this->basicsComplete ($application)],
+            ['application_step_3' => $this->essentialSkillsComplete ($application)]
         );
 
         // Validate basic data is filled in
-        Validator::make($data, $rules)->validate();
+        Validator::make ($data, $rules)->validate ();
     }
 
     /**
@@ -69,124 +69,124 @@ 
      * @param array    $array Array to operate on.
      * @return array
      */
-    protected function arrayMapKeys($fn, $array): array
+    protected function arrayMapKeys ($fn, $array): array
     {
         $newArray = [];
         foreach ($array as $key => $value) {
-            $newArray[$fn($key)] = $value;
+            $newArray[$fn ($key)] = $value;
         }
         return $newArray;
     }
 
-    protected function addNestedValidatorRules($nestedAttribute, $validatorRules, $rules = [])
+    protected function addNestedValidatorRules ($nestedAttribute, $validatorRules, $rules = [])
     {
         // prepend the attribute name of each validator rule with the nested attribute name
-        $newRules = $this->arrayMapKeys(function($key) use ($nestedAttribute) {
-                return implode('.', [$nestedAttribute, $key]);
+        $newRules = $this->arrayMapKeys (function ($key) use ($nestedAttribute) {
+                return implode ('.', [$nestedAttribute, $key]);
         },
             $validatorRules);
         // Merge new rules with old rules
-        $rules = array_merge($rules, $newRules);
+        $rules = array_merge ($rules, $newRules);
         return $rules;
     }
 
-    public function basicsValidator(JobApplication $application)
+    public function basicsValidator (JobApplication $application)
     {
         // Validate the fields common to every application
         $rules = [
             'language_requirement_confirmed' => ['required', 'boolean'],
-            'citizenship_declaration_id' => ['required', Rule::in($this->citizenship_ids)],
-            'veteran_status_id' => ['required', Rule::in($this->veteran_status_ids)],
-            'preferred_language_id' => ['required', Rule::in($this->preferred_language_ids)],
+            'citizenship_declaration_id' => ['required', Rule::in ($this->citizenship_ids)],
+            'veteran_status_id' => ['required', Rule::in ($this->veteran_status_ids)],
+            'preferred_language_id' => ['required', Rule::in ($this->preferred_language_ids)],
         ];
 
         // Load application answers so they are included in application->toArray()
-        $application->load('job_application_answers');
+        $application->load ('job_application_answers');
 
         // Validate that each question has been answered
         $jobPosterQuestionRules = [];
         foreach ($application->job_poster->job_poster_questions as $question) {
-            $jobPosterQuestionRules[] = new ContainsObjectWithAttributeRule('job_poster_question_id', $question->id);
+            $jobPosterQuestionRules[] = new ContainsObjectWithAttributeRule ('job_poster_question_id', $question->id);
         }
         $rules['job_application_answers'] = $jobPosterQuestionRules;
-        $answerValidatorFactory = new JobApplicationAnswerValidator($application);
+        $answerValidatorFactory = new JobApplicationAnswerValidator ($application);
 
         // Validate that each answer is complete
         foreach ($application->job_application_answers as $key => $answer) {
-            $attribute = implode('.', ['job_application_answers', $key]);
-            $rules = $this->addNestedValidatorRules($attribute, $answerValidatorFactory->rules(), $rules);
+            $attribute = implode ('.', ['job_application_answers', $key]);
+            $rules = $this->addNestedValidatorRules ($attribute, $answerValidatorFactory->rules (), $rules);
         }
 
-        $validator = Validator::make($application->toArray(), $rules);
+        $validator = Validator::make ($application->toArray (), $rules);
         return $validator;
     }
 
-    public function basicsComplete(JobApplication $application)
+    public function basicsComplete (JobApplication $application)
     {
-        $validator = $this->basicsValidator($application);
-        return $validator->passes();
+        $validator = $this->basicsValidator ($application);
+        return $validator->passes ();
     }
 
-    public function experienceValidator(JobApplication $application)
+    public function experienceValidator (JobApplication $application)
     {
         $rules = ['experience_saved' => 'required|boolean|accepted'];
-        return Validator::make($application->toArray(), $rules);
+        return Validator::make ($application->toArray (), $rules);
     }
 
-    public function experienceComplete(JobApplication $application)
+    public function experienceComplete (JobApplication $application)
     {
-        return $this->experienceValidator($application)->passes();
+        return $this->experienceValidator ($application)->passes ();
     }
 
-    protected function skillsValidator(JobApplication $application, $criteria_type)
+    protected function skillsValidator (JobApplication $application, $criteria_type)
     {
         $rules = [];
 
         $skillDeclarationRules = [];
-        $criteriaTypeId = CriteriaType::where('name', $criteria_type)->firstOrFail()->id;
-        foreach ($application->job_poster->criteria->where('criteria_type_id', $criteriaTypeId) as $criteria) {
+        $criteriaTypeId = CriteriaType::where ('name', $criteria_type)->firstOrFail ()->id;
+        foreach ($application->job_poster->criteria->where ('criteria_type_id', $criteriaTypeId) as $criteria) {
             // Validate that every essential skill has a corresponding declaration
-            $skillDeclarationRules[] = new ContainsObjectWithAttributeRule('skill_id', $criteria->skill_id);
+            $skillDeclarationRules[] = new ContainsObjectWithAttributeRule ('skill_id', $criteria->skill_id);
         }
         $rules['skill_declarations'] = $skillDeclarationRules;
-        $application->applicant->load('skill_declarations');
+        $application->applicant->load ('skill_declarations');
 
         // Validate that those declarations are complete
-        $skilDeclarationValidatorFactory = new SkillDeclarationValidator($application->applicant);
-        $relevantSkillIds = $application->job_poster->criteria->where('criteria_type_id', $criteriaTypeId)->pluck('skill_id');
+        $skilDeclarationValidatorFactory = new SkillDeclarationValidator ($application->applicant);
+        $relevantSkillIds = $application->job_poster->criteria->where ('criteria_type_id', $criteriaTypeId)->pluck ('skill_id');
         foreach ($application->skill_declarations as $key => $declaration) {
-            if ($relevantSkillIds->contains($declaration->skill_id)) {
-                $attribute = implode('.', ['skill_declarations', $key]);
-                $skillDeclarationValidator = $skilDeclarationValidatorFactory->validator($declaration);
-                $rules = $this->addNestedValidatorRules($attribute, $skillDeclarationValidator->getRules(), $rules);
+            if ($relevantSkillIds->contains ($declaration->skill_id)) {
+                $attribute = implode ('.', ['skill_declarations', $key]);
+                $skillDeclarationValidator = $skilDeclarationValidatorFactory->validator ($declaration);
+                $rules = $this->addNestedValidatorRules ($attribute, $skillDeclarationValidator->getRules (), $rules);
             }
         }
 
-        $validator = Validator::make($application->toArray(), $rules);
+        $validator = Validator::make ($application->toArray (), $rules);
         return $validator;
     }
 
-    public function essentialSkillsValidator(JobApplication $application)
+    public function essentialSkillsValidator (JobApplication $application)
     {
-        return $this->skillsValidator($application, 'essential');
+        return $this->skillsValidator ($application, 'essential');
     }
 
-    public function essentialSkillsComplete(JobApplication $application)
+    public function essentialSkillsComplete (JobApplication $application)
     {
-        return $this->essentialSkillsValidator($application)->passes();
+        return $this->essentialSkillsValidator ($application)->passes ();
     }
 
-    public function assetSkillsValidator(JobApplication $application)
+    public function assetSkillsValidator (JobApplication $application)
     {
-        return $this->skillsValidator($application, 'asset');
+        return $this->skillsValidator ($application, 'asset');
     }
 
-    public function assetSkillsComplete(JobApplication $application)
+    public function assetSkillsComplete (JobApplication $application)
     {
-        return $this->assetSkillsValidator($application)->passes();
+        return $this->assetSkillsValidator ($application)->passes ();
     }
 
-    public function affirmationValidator(JobApplication $application)
+    public function affirmationValidator (JobApplication $application)
     {
         $rules = [
             'submission_signature' => [
@@ -200,11 +200,11 @@ 
                 'max:191',
             ]
         ];
-        return Validator::make($application->toArray(), $rules);
+        return Validator::make ($application->toArray (), $rules);
     }
 
-    public function affirmationComplete(JobApplication $application)
+    public function affirmationComplete (JobApplication $application)
     {
-        return $this->affirmationValidator($application)->passes();
+        return $this->affirmationValidator ($application)->passes ();
     }
 }

app/Console/Kernel.php

Spacing +11 added lines, -11 removed lines

@@ -21,13 +21,13 @@ 
      * @param  \Illuminate\Console\Scheduling\Schedule $schedule
      * @return void
      */
-    protected function schedule(Schedule $schedule): void
+    protected function schedule (Schedule $schedule): void
     {
         // $schedule->command('inspire')
         // ->hourly();
         // start the queue daemon, if its not running
-        if (!$this->osProcessIsRunning('queue:work')) {
-            $schedule->command('queue:work')->everyMinute();
+        if (!$this->osProcessIsRunning ('queue:work')) {
+            $schedule->command ('queue:work')->everyMinute ();
         }
     }
 
@@ -36,11 +36,11 @@ 
      *
      * @return void
      */
-    protected function commands(): void
+    protected function commands (): void
     {
-        $this->load(__DIR__ . '/Commands');
+        $this->load (__DIR__.'/Commands');
 
-        require base_path('routes/console.php');
+        require base_path ('routes/console.php');
     }
 
     /**
@@ -49,17 +49,17 @@ 
      * @param string $needle
      * @return boolean
      */
-    protected function osProcessIsRunning(string $needle): bool
+    protected function osProcessIsRunning (string $needle): bool
     {
         // get process status. the "-ww"-option is important to get the full output!
-        exec('ps aux -ww', $process_status);
+        exec ('ps aux -ww', $process_status);
 
 
         // search $needle in process status
-        $result = array_filter(
+        $result = array_filter (
             $process_status,
-            function($var) use ($needle) {
-                return strpos($var, $needle);
+            function ($var) use ($needle) {
+                return strpos ($var, $needle);
             }
         );
 

app/Http/Middleware/Authenticate.php

Spacing +4 added lines, -4 removed lines

@@ -12,12 +12,12 @@
      * @param  \Illuminate\Http\Request  $request
      * @return string
      */
-    protected function redirectTo($request)
+    protected function redirectTo ($request)
     {
-        if (WhichPortal::isManagerPortal()) {
-            return route('manager.login');
+        if (WhichPortal::isManagerPortal ()) {
+            return route ('manager.login');
         } else {
-            return route('login');
+            return route ('login');
         }
     }
 }