SessionTokenStorage::refreshKey() - Code Metrics - Inspection of "Fix 'relatives' form names and WorkSampleValidator" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — bugfix/relatives_not_saving ( 6485fa...f1e1c5 )

by Tristan

created 2019-03-28 17:13 UTC

SessionTokenStorage::refreshKey() A

↳ Parent: SessionTokenStorage

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	2
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

namespace App\Services\Auth;

use App\Services\Auth\Contracts\TokenStorage;

class SessionTokenStorage implements TokenStorage {

    public function fetchRefresh(string $iss, string $sub) {

        $key = $this->refreshKey($iss, $sub);
        return session($key);

    }

    public function saveRefresh(string $iss, string $sub, string $refreshToken) {

        $key = $this->refreshKey($iss, $sub);
        session([$key => $refreshToken]);
        return true;
    }

    protected function refreshKey(string $iss, string $sub) {

        return $key = implode('.', ['refreshToken', $iss, $sub]);

    }

    public function fetchAccess(string $iss, string $sub) {

        $key = $this->accessKey($iss, $sub);
        return session($key);

    }

    public function saveAccess(string $iss, string $sub, string $accessToken) {

        $key = $this->accessKey($iss, $sub);
        session([$key => $accessToken]);
        return true;
    }

    protected function accessKey(string $iss, string $sub) {

        return $key = implode('.', ['accessToken', $iss, $sub]);

    }

    public function forgetAccess(string $iss, string $sub) {

        $key = $this->accessKey($iss, $sub);
        session()->forget($key);
    }

    public function forgetRefresh(string $iss, string $sub) {

        $key = $this->refreshKey($iss, $sub);
        session()->forget($key);
    }

}


1			<?php
2
3			namespace App\Services\Auth;
4
5			use App\Services\Auth\Contracts\TokenStorage;
6
7			class SessionTokenStorage implements TokenStorage {
8
9			public function fetchRefresh(string $iss, string $sub) {
			1 ignored issue – show introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\Auth\SessionTokenStorage::fetchRefresh() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing doc comment for function fetchRefresh() Loading history...
10			$key = $this->refreshKey($iss, $sub);
11			return session($key);
			0 ignored issues – show Bug Best Practice introduced 2018-10-19 14:38 UTC by Report Bug Copy Issue Report The expression `return session($key)` also could return the type `Illuminate\Session\Sessi...lluminate\Session\Store` which is incompatible with the return type mandated by `App\Services\Auth\Contra...Storage::fetchRefresh()` of `null\|string`. Loading history...
12			}
13
14			public function saveRefresh(string $iss, string $sub, string $refreshToken) {
			1 ignored issue – show introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\Auth\SessionTokenStorage::saveRefresh() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing doc comment for function saveRefresh() Loading history...
15			$key = $this->refreshKey($iss, $sub);
16			session([$key => $refreshToken]);
17			return true;
18			}
19
20			protected function refreshKey(string $iss, string $sub) {
			1 ignored issue – show introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\Auth\SessionTokenStorage::refreshKey() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing doc comment for function refreshKey() Loading history...
21			return $key = implode('.', ['refreshToken', $iss, $sub]);
			0 ignored issues – show Unused Code introduced 2018-08-24 15:45 UTC by Report Bug Copy Issue Report The assignment to `$key` is dead and can be removed. Loading history...
22			}
23
24			public function fetchAccess(string $iss, string $sub) {
			1 ignored issue – show introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\Auth\SessionTokenStorage::fetchAccess() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing doc comment for function fetchAccess() Loading history...
25			$key = $this->accessKey($iss, $sub);
26			return session($key);
			0 ignored issues – show Bug Best Practice introduced 2018-10-19 14:38 UTC by Report Bug Copy Issue Report The expression `return session($key)` also could return the type `Illuminate\Session\Sessi...lluminate\Session\Store` which is incompatible with the return type mandated by `App\Services\Auth\Contra...nStorage::fetchAccess()` of `null\|string`. Loading history...
27			}
28
29			public function saveAccess(string $iss, string $sub, string $accessToken) {
			1 ignored issue – show introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\Auth\SessionTokenStorage::saveAccess() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing doc comment for function saveAccess() Loading history...
30			$key = $this->accessKey($iss, $sub);
31			session([$key => $accessToken]);
32			return true;
33			}
34
35			protected function accessKey(string $iss, string $sub) {
			1 ignored issue – show introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\Auth\SessionTokenStorage::accessKey() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing doc comment for function accessKey() Loading history...
36			return $key = implode('.', ['accessToken', $iss, $sub]);
			0 ignored issues – show Unused Code introduced 2018-08-24 15:45 UTC by Report Bug Copy Issue Report The assignment to `$key` is dead and can be removed. Loading history...
37			}
38
39			public function forgetAccess(string $iss, string $sub) {
			1 ignored issue – show introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\Auth\SessionTokenStorage::forgetAccess() does not have void return type hint. Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing doc comment for function forgetAccess() Loading history...
40			$key = $this->accessKey($iss, $sub);
41			session()->forget($key);
42			}
43
44			public function forgetRefresh(string $iss, string $sub) {
			1 ignored issue – show introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\Auth\SessionTokenStorage::forgetRefresh() does not have void return type hint. Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing doc comment for function forgetRefresh() Loading history...
45			$key = $this->refreshKey($iss, $sub);
46			session()->forget($key);
47			}
48
49			}
50

GCTC-NTGC / TalentCloud

Push — bugfix/relatives_not_saving ( 6485fa...f1e1c5 )

SessionTokenStorage::refreshKey() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like