App\Services\Auth\JwtValidator::signatureIsValid()

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function signatureIsValid(Token $token) {

Method \App\Services\Auth\JwtValidator::signatureIsValid() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function signatureIsValid()

        $kid = $token->getHeader("kid");
        $alg = $token->getHeader("alg");
        $publicKey = $this->keyFetcher->getByKID($kid);
        
        switch ($alg) {
            case "RS256":
                $signer = new Sha256();
                break;
            default:
                $signer = new Sha256();
                break;
        }

        $signatureIsValid = $token->verify($signer, $publicKey);

It seems like $publicKey can also be of type Lcobucci\JWT\Signer\Key; however, parameter $key of Lcobucci\JWT\Token::verify() does only seem to accept string, maybe add an additional type check?

        return $signatureIsValid;
    }