App\Services\Auth\RequestTokenParser

Complexity

Total Complexity

6

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	save()	0	4	1
A	parse()	0	12	2
A	parseFromString()	0	2	1
A	forget()	0	7	1

<?php
namespace App\Services\Auth;

use Illuminate\Auth\AuthenticationException;
use Illuminate\Support\Facades\Cookie;
use Illuminate\Http\Request;
//use Lcobucci\JWT\Token;
//use Lcobucci\JWT\Token\Parser;
use Lcobucci\JWT\Token;
use Lcobucci\JWT\Parser;

/**
 * Adapted from the OpenIDConnect Laravel package at
 * https://github.com/furdarius/oidconnect-laravel
 */
class RequestTokenParser
{
    const AUTH_HEADER = "Authorization";
    const COOKIE_KEY = "id_token";

    /**
     * @var Parser
     */
    private $parser;
    /**
     * TokenMiddleware constructor.
     *
     * @param Parser         $parser

Missing parameter comment

Expected 1 spaces after parameter type; 9 found

     */
    public function __construct(
        Parser $parser
    ) {
        $this->parser = $parser;
    }
    /**
     * @param Request $request

Missing parameter comment

     *
     * @return Token
     */

Missing @throws tag in function comment

    public function parse(Request $request)

Method \App\Services\Auth\RequestTokenParser::parse() does not have return type hint for its return value but it should be possible to add it based on @return annotation "Token".

    {
//        if ($request->session()->has(static::COOKIE_KEY)) {
//            $token = $request->session()->get(static::COOKIE_KEY);
//        } else {
//            throw new AuthenticationException("Request doesn't contain id token");
//        }
        $token = $request->cookie(static::COOKIE_KEY);
        if (empty($token)) {
            throw new AuthenticationException("Request doesn't contain id token");
        }
        return $this->parser->parse($token);

It seems like $token can also be of type array; however, parameter $jwt of Lcobucci\JWT\Parser::parse() does only seem to accept string, maybe add an additional type check?

         /*
        $bearer = $request->headers->get(static::AUTH_HEADER);
        if (empty($bearer)) {
            throw new AuthenticationException("Request doesn't contain auth token");
        }
        $parts = explode(" ", $bearer);
        if (count($parts) < 2) {
            throw new AuthenticationException("Invalid format of auth header");
        }
        $jwt = $parts[1];
        return $this->parser->parse($jwt);
          *
          */
    }

    /**
     * @param string $tokenString     *

Expected 1 spaces after parameter name; 5 found

Parameter comment must start with a capital letter

Parameter comment must end with a full stop

     * @return Token
     */
    public function parseFromString(string $tokenString) {

Method \App\Services\Auth\RequestTokenParser::parseFromString() does not have return type hint for its return value but it should be possible to add it based on @return annotation "Token".

        return $this->parser->parse($tokenString);
    }

    public function save(Token $token) {

Method \App\Services\Auth\RequestTokenParser::save() does not have void return type hint.

Missing doc comment for function save()

        //session([static::COOKIE_KEY => (string)$token]);
        //Cookie::queue(static::COOKIE_KEY, (string)$token);
        cookie()->queue(cookie()->forever(static::COOKIE_KEY, (string)$token));
    }

    public function forget() {

Method \App\Services\Auth\RequestTokenParser::forget() does not have void return type hint.

Missing doc comment for function forget()

        //session()->forget(static::COOKIE_KEY);
        // if (Cookie::hasQueued(static::COOKIE_KEY)) {
        //   Cookie::unqueue(static::COOKIE_KEY);
        // }
        // Cookie::queue(Cookie::forget(static::COOKIE_KEY));
        cookie()->queue(cookie()->forget(static::COOKIE_KEY));
    }
}