App\Services\Auth\OidConnectGuard

Complexity

Total Complexity

23

Size/Duplication

Total Lines	174
Duplicated Lines	0 %

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	guest()	0	2	1
A	setUser()	0	3	1
A	id()	0	4	2
A	__construct()	0	12	1
A	check()	0	2	1
A	getProvider()	0	3	1
A	validate()	0	9	4
B	user()	0	45	9
A	setProvider()	0	3	1
A	authenticate()	0	7	2

<?php

namespace App\Services\Auth;

use Illuminate\Http\Request;
use Illuminate\Contracts\Auth\Guard;
use Illuminate\Contracts\Auth\UserProvider;
use Illuminate\Contracts\Auth\Authenticatable;
use Illuminate\Auth\AuthenticationException;
use App\Services\Auth\JwtValidator;
use App\Services\Auth\RequestTokenParser;
use App\Services\Auth\Contracts\TokenRefresher;
use App\Exceptions\Auth\TokenStorageException;
use App\Exceptions\Auth\TokenRequestException;

class OidConnectGuard implements Guard {

    protected $request;

Property \App\Services\Auth\OidConnectGuard::$request does not have @var annotation.

Missing member variable doc comment

    protected $provider;

Property \App\Services\Auth\OidConnectGuard::$provider does not have @var annotation.

Missing member variable doc comment

    protected $requestTokenParser;

Property \App\Services\Auth\OidConnectGuard::$requestTokenParser does not have @var annotation.

Missing member variable doc comment

    protected $jwtValidator;

Property \App\Services\Auth\OidConnectGuard::$jwtValidator does not have @var annotation.

Missing member variable doc comment

    protected $tokenRefresher;

Property \App\Services\Auth\OidConnectGuard::$tokenRefresher does not have @var annotation.

Missing member variable doc comment

    protected $user;

Property \App\Services\Auth\OidConnectGuard::$user does not have @var annotation.

Missing member variable doc comment

    /**
     * Set to true when user() has already ran once.
     * @var bool

Expected "boolean" but found "bool" for @var tag in member variable comment

     */
    protected $userAlreadyAttempted;

    /**
     * Create a new authentication guard.
     *
     *
     * @param UserProvider $provider

Missing parameter comment

Expected 7 spaces after parameter type; 1 found

     * @param RequestTokenParser $requestTokenParser

Missing parameter comment

     * @param JwtValidator $jwtValidator

Missing parameter comment

Expected 7 spaces after parameter type; 1 found

     * @param TokenRefresher $tokenRefresher

Missing parameter comment

Expected 5 spaces after parameter type; 1 found

     * @param Request $request

Missing parameter comment

Expected 12 spaces after parameter type; 1 found

     */
    public function __construct(UserProvider $provider,

The first parameter of a multi-line function declaration must be on the line after the opening bracket

            RequestTokenParser $requestTokenParser,

Multi-line function declaration not indented correctly; expected 8 spaces but found 12

            JwtValidator $jwtValidator,

Multi-line function declaration not indented correctly; expected 8 spaces but found 12

            TokenRefresher $tokenRefresher,

Multi-line function declaration not indented correctly; expected 8 spaces but found 12

            Request $request) {

Multi-line function declaration not indented correctly; expected 8 spaces but found 12

The closing parenthesis of a multi-line function declaration must be on a new line

        $this->request = $request;
        $this->provider = $provider;
        $this->requestTokenParser = $requestTokenParser;
        $this->jwtValidator = $jwtValidator;
        $this->tokenRefresher = $tokenRefresher;
        $this->user = NULL;

TRUE, FALSE and NULL must be lowercase; expected null, but found NULL.

        $this->userAlreadyAttempted = false;
    }

    /**
     * Determine if the current user is authenticated.
     *
     * @return bool

Expected "boolean" but found "bool" for function return type

     */
    public function check() {

Method \App\Services\Auth\OidConnectGuard::check() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool".

        return !is_null($this->user());
    }

    /**
     * Determine if the current user is a guest.
     *
     * @return bool

Expected "boolean" but found "bool" for function return type

     */
    public function guest() {

Method \App\Services\Auth\OidConnectGuard::guest() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool".

        return !$this->check();
    }

    /**
     * Get the ID for the currently authenticated user.
     *
     * @return int|null

Expected "integer|null" but found "int|null" for function return type

     */
    public function id()

Method \App\Services\Auth\OidConnectGuard::id() does not have return type hint for its return value but it should be possible to add it based on @return annotation "int|null".

    {
        if ($this->user()) {
            return $this->user()->getAuthIdentifier();
        }
    }

    /**
     * Set the current user.
     *
     * @param  \Illuminate\Contracts\Auth\Authenticatable  $user

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return void
     */
    public function setUser(Authenticatable $user)

Method \App\Services\Auth\OidConnectGuard::setUser() does not have return type hint for its return value but it should be possible to add it based on @return annotation "void".

    {
        $this->user = $user;
    }

    public function user() {

Method \App\Services\Auth\OidConnectGuard::user() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function user()

        // If we've already retrieved the user for the current request we can just
        // return it back immediately. We do not want to fetch the user data on
        // every call to this method because that would be tremendously slow.
        if (! is_null($this->user) || $this->userAlreadyAttempted) {
            return $this->user;
        }

        $this->userAlreadyAttempted = true;
        $user = null;

        try {
            $idToken = $this->requestTokenParser->parse($this->request);
        } catch (AuthenticationException $exception) {
            //Return a null user is enough, swallow the exception here
            return $user;
        }

        if (!$this->jwtValidator->claimsAreValid($idToken) ||
                !$this->jwtValidator->signatureIsValid($idToken)) {
            return $user;
        }

        //At this point, token is definitely valid
        if ($this->jwtValidator->isExpired($idToken)) {

Blank line found at start of control structure

            $iss = $idToken->getClaim("iss");
            $sub = $idToken->getClaim("sub");
            try {
                $idToken = $this->tokenRefresher->refreshIDToken($iss, $sub);

Blank line found at end of control structure

            } catch (TokenStorageException $storageException) {
                //DO NOTHING
            } catch (TokenRequestException $requestException) {
                return $user;
            }
            $this->requestTokenParser->save($idToken);
        }

        $credentials = $idToken->getClaims();

        $user = $this->provider->retrieveByCredentials($credentials);

        $this->user = $user;
        return $user;
    }

    public function validate(array $credentials = array()) {

Method \App\Services\Auth\OidConnectGuard::validate() does not have @param annotation for its traversable parameter $credentials.

Method \App\Services\Auth\OidConnectGuard::validate() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function validate()

        if (empty($credentials['id_token'])) {
            return false;
        }
        $token = $this->requestTokenParser->parseFromString($credentials['id_token']);

The assignment to $token is dead and can be removed.

        return $this->jwtValidator->claimsAreValid($idToken) &&

The variable $idToken seems to be never defined.

            !$this->jwtValidator->isExpired($idToken) &&
            $this->jwtValidator->signatureIsValid($idToken);
    }

    /**
     * Get the user provider used by the guard.
     *
     * @return \Illuminate\Contracts\Auth\UserProvider
     */
    public function getProvider()

Method \App\Services\Auth\OidConnectGuard::getProvider() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Contracts\Auth\UserProvider".

    {
        return $this->provider;
    }

    /**
     * Set the user provider used by the guard.
     *
     * @param  \Illuminate\Contracts\Auth\UserProvider  $provider

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return void
     */
    public function setProvider(UserProvider $provider)

Method \App\Services\Auth\OidConnectGuard::setProvider() does not have return type hint for its return value but it should be possible to add it based on @return annotation "void".

    {
        $this->provider = $provider;
    }

    /**
     * Determine if the current user is authenticated.
     *
     * @return \Illuminate\Contracts\Auth\Authenticatable
     *
     * @throws \Illuminate\Auth\AuthenticationException

Comment missing for @throws tag in function comment

     */
    public function authenticate()

Method \App\Services\Auth\OidConnectGuard::authenticate() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Contracts\Auth\Authenticatable".

    {
        if (! is_null($user = $this->user())) {
            return $user;
        }

        throw new AuthenticationException;
    }
}