App\Services\Auth\JSONFetcher

Complexity

Total Complexity

4

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	post()	0	11	1
A	__construct()	0	3	1
A	request()	0	6	1
A	get()	0	9	1

<?php

namespace App\Services\Auth;

use GuzzleHttp\Client;
use App\Services\Auth\Contracts\JSONGetter;
use App\Services\Auth\Contracts\JSONPoster;

/**
 * Adapted from the OpenIDConnect Laravel package at
 * https://github.com/furdarius/oidconnect-laravel
 */
class JSONFetcher implements JSONGetter, JSONPoster
{
    /**
     * @var \GuzzleHttp\Client
     */
    private $client;
    /**
     * JSONFetcher constructor.
     *
     * @param \GuzzleHttp\Client $client

Missing parameter comment

     */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }
    /**

Doc comment for parameter "$url" missing

Doc comment for parameter "$params" missing

Doc comment for parameter "$options" missing

     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function get(string $url, array $params = [], array $options = [])
    {
        $reqOpts = array_merge([
            'query' => $params,
            'headers' => [
                'Accept' => 'application/json',
            ],
        ], $options);
        return $this->request("GET", $url, $reqOpts);
    }
    /**
     * @param string $method

Missing parameter comment

     * @param string $url

Missing parameter comment

     * @param array  $options

@param annotation of method \App\Services\Auth\JSONFetcher::request() does not specify type hint for items of its traversable parameter $options.

Missing parameter comment

     *
     * @return array

@return annotation of method \App\Services\Auth\JSONFetcher::request() does not specify type hint for items of its traversable return value.

     */
    protected function request(string $method, string $url, array $options)

Method \App\Services\Auth\JSONFetcher::request() does not have return type hint for its return value but it should be possible to add it based on @return annotation "array".

    {
        $response = $this->client->request($method, $url, $options);
        // TODO: Handle request errors (ex.: authorization error with 403 status code)
        $data = $response->getBody()->getContents();
        return json_decode($data, true);
    }
    /**

Doc comment for parameter "$url" missing

Doc comment for parameter "$params" missing

Doc comment for parameter "$body" missing

Doc comment for parameter "$options" missing

     * {@inheritdoc}
     */

Missing @return tag in function comment

    public function post(string $url, array $params = [], $body = null, array $options = [])
    {
        $reqOpts = array_merge([
            'query' => $params,
            'headers' => [
                'Accept' => 'application/json',
                'Content-Type' => 'application/x-www-form-urlencoded',
            ],
            'body' => $body,
        ], $options);
        return $this->request("POST", $url, $reqOpts);
    }
}