App\Http\Controllers\WorkSamplesController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	0	2	1
A	destroy()	0	13	2
A	edit()	0	5	1
A	update()	0	27	3

<?php

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Log;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use App\Models\Skill;
use App\Models\Applicant;
use App\Models\WorkSample;
use App\Services\Validation\Requests\UpdateWorkSampleValidator;

class WorkSamplesController extends Controller
{

    /**
     * Display the Work Samples associated with the applicant.
     *
     * @param  \App\Models\Applicant  $applicant

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response

Function return type is not void, but function has no return statement

     */
    public function show(Applicant $applicant)
    {
        //

    }

Function closing brace must go on the next line following the body; found 1 blank lines before brace

    /**
     * Show the form for editing the applicant's work samples
     *
     * @param  Request  $request

Missing parameter comment

Expected 15 spaces after parameter type; 2 found

     * @param  \App\Models\Applicant  $applicant

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response
     */
    public function edit(Request $request, Applicant $applicant)

Method \App\Http\Controllers\WorkSamplesController::edit() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\Response".

    {
        return view('applicant/profile_05_portfolio', [

The expression return view('applicant/profile_05_portfolio', array('applicant' => $applicant, 'profile' => Illuminate\Support\Facades\Lang::get('applicant/profile_work_samples'))) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

            'applicant' => $applicant,
            'profile' => Lang::get('applicant/profile_work_samples'),
        ]);
    }

    /**
     * Update the workSample in storage, or create new one.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 4 spaces after parameter type; 2 found

     * @param  \App\Models\WorkSample|null  $workSample

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, ?WorkSample $workSample = null)

Method \App\Http\Controllers\WorkSamplesController::update() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\Response".

    {
        $validator = new UpdateWorkSampleValidator();
        $validator->validate($request->input());

        if ($workSample === null) {
            $workSample = new WorkSample();
            $workSample->applicant_id = $request->user()->applicant->id;
        }
        $workSample->fill([
            'name' => $request->input('name'),
            'file_type_id' => $request->input('file_type_id'),
            'url' => $request->input('url'),
            'description' => $request->input('description'),
        ]);
        $workSample->save();

        //Attach relatives
        $skillIds = $this->getRelativeIds($request->input(), 'skills');
        $workSample->skill_declarations()->sync($skillIds);

        // if an ajax request, return the new object
        if ($request->ajax()) {
            $workSample->load('file_type');
            return $workSample->toJson();

The expression return $workSample->toJson() returns the type string which is incompatible with the documented return type Illuminate\Http\Response.

        } else {
            return redirect()->back();

The expression return redirect()->back() returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }
    }

    /**
     * Delete the particular work sample from storage.
     *
     * @param  \Illuminate\Http\Request  $request

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

     * @param  \App\Models\WorkSample  $workSample

Missing parameter comment

Expected 3 spaces after parameter type; 2 found

     * @return \Illuminate\Http\Response
     */
    public function destroy(Request $request, WorkSample $workSample)

Method \App\Http\Controllers\WorkSamplesController::destroy() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\Response".

    {
        $this->authorize('delete', $workSample);

        $workSample->delete();

        if($request->ajax()) {

Expected 1 space(s) after IF keyword; 0 found

            return [

The expression return array('message' => 'Work sample deleted') returns the type array<string,string> which is incompatible with the documented return type Illuminate\Http\Response.

                "message" => 'Work sample deleted'
            ];
        }

        return redirect()->back();

The expression return redirect()->back() returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }

}