App\Http\Controllers\ApplicantProfileController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	139
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	0	22	1
A	update()	0	48	5
A	edit()	0	35	3

<?php

namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Auth;
use Illuminate\Auth\GuardHelpers;
use Illuminate\Http\Request;
use App\Models\Lookup\ApplicantProfileQuestion;
use App\Models\Applicant;
use App\Models\ApplicantProfileAnswer;
use App\Http\Controllers\Controller;
use Illuminate\Support\Facades\Hash;
use App\Services\Validation\Requests\UpdateApplicationProfileValidator;

class ApplicantProfileController extends Controller
{

    protected $answerFormInputName = 'applicantProfileAnswer';

Property \App\Http\Controllers\ApplicantProfileController::$answerFormInputName does not have @var annotation.

Missing member variable doc comment

    /**
     * Display the specified resource.
     *
     * @param  Request               $request

Missing parameter comment

     * @param  \App\Models\Applicant $applicant

Missing parameter comment

     * @return \Illuminate\Http\Response
     */
    public function show(Request $request, Applicant $applicant)

The parameter $request is not used and could be removed.

Method \App\Http\Controllers\ApplicantProfileController::show() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\Response".

    {
        //TODO:
        //Josh, to loop through answers&question data, leverage this data structure:
        // applicant
        //     [applicant_profile_answers]
        //         answer
        //         applicant_profile_question
        //             id
        //             value // The question text
        //             description // Question description text

        return view(

The expression return view('manager/applicant_profile', array('profile' => Illuminate\Support\Facades\Lang::get('manager/applicant_profile'), 'user' => $applicant->user, 'applicant' => $applicant, 'profile_photo_url' => '/images/user.png')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

            'manager/applicant_profile',
            [
                /* Localization Strings*/
                'profile' => Lang::get('manager/applicant_profile'), // Change text

                /* User Data */
                'user' => $applicant->user,
                'applicant' => $applicant,
                'profile_photo_url' => '/images/user.png', //TODO: get real photos
            ]
        );
    }

    /**
     * Show the form for editing the logged-in user's applicant profile
     *
     * @param  Request               $request   Incoming request object.
     * @param  \App\Models\Applicant $applicant Applicant to view and edit.
     * @return \Illuminate\Http\Response
     */
    public function edit(Request $request, Applicant $applicant)

Method \App\Http\Controllers\ApplicantProfileController::edit() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\Response".

    {
        $profileQuestions = ApplicantProfileQuestion::all();

        $profileText = Lang::get('applicant/applicant_profile');

        $profileQuestionForms = [];
        foreach ($profileQuestions as $question) {
            $answerObj = $applicant->applicant_profile_answers
                ->where('applicant_profile_question_id', $question->id)->first();
            $answer = $answerObj ? $answerObj->answer : null;

            $formValues = [
                'id' => $question->id,
                'question' => $question->question,
                'description' => $question->description,
                'answer' => $answer,
                'answer_label' => $profileText['about_section']['answer_label'],
                'input_name' => $this->answerFormInputName.'['.$question->id.']'
            ];
            array_push($profileQuestionForms, $formValues);
        }

        return view(

The expression return view('applicant/profile_01_about', array('profile' => $profileText, 'applicant_profile_questions' => $profileQuestionForms, 'user' => $applicant->user, 'applicant' => $applicant, 'profile_photo_url' => '/images/user.png', 'form_submit_action' => route('profile.about.update', $applicant))) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

            'applicant/profile_01_about', [
            /* Localized strings*/
            'profile' => $profileText,
            /* Applicant Profile Questions */
            'applicant_profile_questions' => $profileQuestionForms,
            /* User Data */
            'user' => $applicant->user,
            'applicant' => $applicant,
            'profile_photo_url' => '/images/user.png', //TODO: get real photos

            'form_submit_action' => route('profile.about.update', $applicant)
            ]
        );
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  Request               $request   Incoming request.
     * @param  \App\Models\Applicant $applicant Applicant object to update.
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Request $request, Applicant $applicant)

Method \App\Http\Controllers\ApplicantProfileController::update() does not have return type hint for its return value but it should be possible to add it based on @return annotation "\Illuminate\Http\RedirectResponse".

    {
        $questions = ApplicantProfileQuestion::all();

        $validator = new UpdateApplicationProfileValidator($applicant);
        $validator->validate($request->all());

        foreach ($questions as $question) {
            $answerName = $this->answerFormInputName . '.' . $question->id;
            if ($request->has($answerName)) {
                $answer = ApplicantProfileAnswer::where(
                    ['applicant_id' => $applicant->id,
                    'applicant_profile_question_id' => $question->id]
                )
                            ->first();
                if ($answer == null) {
                    $answer = new ApplicantProfileAnswer();
                    $answer->applicant_id =$applicant->id;
                    $answer->applicant_profile_question_id = $question->id;
                }
                $answer->answer = $request->input($answerName);
                $answer->save();
            }
        }

        $input = $request->input();
        $applicant->fill(
            [
            'tagline' => $input['tagline'],
            'twitter_username' => $input['twitter_username'],
            'linkedin_url' => $input['linkedin_url'],
            ]
        );
        $applicant->save();

        $user = $applicant->user;
        $user->fill(
            [
            'name' => $input['profile_name'],
            'email' => $input['profile_email'], //TODO make changing email harder!
            ]
        );
        if ($input['new_password']) {
            $user->password =  Hash::make($input['new_password']); //TODO: change password in seperate form!
        }
        $user->save();

        return redirect()->route('profile.about.edit', $applicant);
    }
}