SkillsController::create() - Code Metrics - Inspection of "Save properly resolved merge conflict" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — bugfix/dropdown_accessibility ( 8a3d59...d27897 )

by Tristan

created 2019-02-05 17:03 UTC

SkillsController::create() A

↳ Parent: SkillsController

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	9
dl	0
loc	19
ccs	0
cts	10
cp	0
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php


namespace App\Http\Controllers;

use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Log;
use Illuminate\Http\Request;
use App\Models\Skill;
use App\Models\Lookup\SkillLevel;
use App\Models\Lookup\SkillStatus;
use App\Models\SkillDeclaration;
use App\Models\Applicant;
use App\Http\Controllers\Controller;
use App\Services\Validation\BulkSkillDeclarationValidator;
use App\Services\Validation\SkillDeclarationValidator;

class SkillsController extends Controller

{

    /**
     * Display the Skills page associated with the applicant.
     *
     * @param  \App\Models\Applicant  $applicant

     * @return \Illuminate\Http\Response

     */
    public function show(Applicant $applicant)
    public function show(/** @scrutinizer ignore-unused */ Applicant $applicant)
    {
        //

    }

    /**
     * Show the form for editing the applicant's skills
     *
     * @param  Request  $request

     * @param  \App\Models\Applicant  $applicant

     * @return \Illuminate\Http\Response

     */
    public function edit(Request $request, Applicant $applicant)
    {
        $skills = Skill::all();

        return view('applicant/profile_03_skills', [

            'applicant' => $applicant,
            'profile' => Lang::get('applicant/profile_skills'),
            'skills' => $skills
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
    }

    /**
     * Create the particular skill declaration in storage.
     *
     * @param  \Illuminate\Http\Request  $request

     * @return \Illuminate\Http\Response

     */
    public function create(Request $request)
    {
        $this->authorize('create', SkillDeclaration::class);

        $user = $request->user();
        $applicant = $user->applicant;

        //Get the default claim status id
        $claimedStatusId = SkillStatus::where('name', 'claimed')->firstOrFail()->id;

        // Create a new Skill Declaration
        // But don't save, as it hasn't been validated yet
        $skillDeclaration = new SkillDeclaration();
        $skillDeclaration->applicant_id = $applicant->id;
        $skillDeclaration->skill_id = $request->input('skill_id');
        $skillDeclaration->skill_status_id = $claimedStatusId;

        //Update variable fields in skill declaration
        return $this->updateSkillDeclaration($request, $skillDeclaration);

    }

    /**
     * Update the particular skill declaration in storage.
     *
     * @param  \Illuminate\Http\Request  $request

     * @param  \App\Models\SkillDeclaration  $skillDeclaration

     * @return \Illuminate\Http\Response

     */
    public function update(Request $request, SkillDeclaration $skillDeclaration)
    {
        $this->authorize('update', $skillDeclaration);

        return $this->updateSkillDeclaration($request, $skillDeclaration);

    }

    protected function updateSkillDeclaration(Request $request, SkillDeclaration $skillDeclaration)

    {
        //Fill variable values
        $skillDeclaration->fill([

            'description' => $request->input('description'),
            'skill_level_id' => $request->input('skill_level_id'),
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.

        //Validate before saving
        $validator = new SkillDeclarationValidator($request->user()->applicant);
        $validator->validate($skillDeclaration);

        //Save this skill declaration
        $skillDeclaration->save();

        //Attach relatives
        $referenceIds = $this->getRelativeIds($request->input(), 'references');
        $skillDeclaration->references()->sync($referenceIds);

        $sampleIds = $this->getRelativeIds($request->input(), 'samples');
        $skillDeclaration->work_samples()->sync($sampleIds);

        // $skillDeclaration->save();

        // If an ajax request, return the new object
        if($request->ajax()) {

            $skillDeclaration->load('references');
            $skillDeclaration->load('work_samples');
            $skillDeclaration->load('skill');
            $skillDeclaration->load('skill_status');
            return $skillDeclaration->toJson();
        }

        return redirect()->back();
    }

    /**
     * Delete the particular skill declaration in storage.
     *
     * @param  \Illuminate\Http\Request  $request

     * @param  \App\Models\SkillDeclaration  $skillDeclaration

     * @return \Illuminate\Http\Response

     */
    public function destroy(Request $request, SkillDeclaration $skillDeclaration)
    {
        $this->authorize('delete', $skillDeclaration);
        $skillDeclaration->delete();

        if($request->ajax()) {

            return ['message' => 'Skill deleted'];

        }

        return redirect()->back();

    }

}


GCTC-NTGC / TalentCloud

Push — bugfix/dropdown_accessibility ( 8a3d59...d27897 )

SkillsController::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like