WhichPortal::isHrPortal() - Code Metrics - Inspection of "Redux hrAdvisor store partly done" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/redux-claim-job ( b0411b )

by Tristan

created 2019-12-05 23:04 UTC

WhichPortal::isHrPortal() A

↳ Parent: WhichPortal

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	2
dl	0
loc	4
rs	10
c	1
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace App\Services;

use Illuminate\Support\Facades\URL;

class WhichPortal
{

    public function isApplicantPortal()

    {
        return !$this->isManagerPortal() && !$this->isHrPortal() && !$this->isAdminPortal();
    }

    public function isManagerPortal()

    {
        $url = URL::current();
        return $this->urlIsManagerPortal($url);
    }

    public function isHrPortal()

    {
        $url = URL::current();
        return $this->urlIsHrPortal($url);
    }

    public function isAdminPortal()

    {
        $url = URL::current();
        return $this->urlIsAdminPortal($url);
    }

    public function urlIsManagerPortal($url): bool

    {
        $baseUrl = config('app.url');
        $managerPrefix = config('app.manager_prefix');
        $managerPattern = "#^$baseUrl/(\w+/)?$managerPrefix(/.*)?$#";
        return preg_match($managerPattern, $url);

    }

    public function urlIsHrPortal($url): bool

    {
        $baseUrl = config('app.url');
        $hrPrefix = config('app.hr_prefix');
        $hrPattern = "#^$baseUrl/(\w+/)?$hrPrefix(/.*)?$#";
        return preg_match($hrPattern, $url);

    }

    public function urlIsAdminPortal($url): bool

    {
        $baseUrl = config('app.url');
        $adminPrefix = config('backpack.base.route_prefix', 'admin');
        $adminPattern = "#^$baseUrl/(\w+/)?$adminPrefix(/.*)?$#";
        return preg_match($adminPattern, $url);

    }
}


1			<?php
2
3			namespace App\Services;
4
5			use Illuminate\Support\Facades\URL;
6
7			class WhichPortal
8			{
9
10			public function isApplicantPortal()
			2 ignored issues – show introduced 2019-12-05 15:07 UTC by Report Bug Copy Issue Report Method \App\Services\WhichPortal::isApplicantPortal() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-11-19 02:35 UTC by Report Bug Copy Issue Report Missing doc comment for function isApplicantPortal() Loading history...
11			{
12			return !$this->isManagerPortal() && !$this->isHrPortal() && !$this->isAdminPortal();
13			}
14
15			public function isManagerPortal()
			2 ignored issues – show introduced 2019-12-05 15:07 UTC by Report Bug Copy Issue Report Method \App\Services\WhichPortal::isManagerPortal() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-12-05 23:16 UTC by Report Bug Copy Issue Report Missing doc comment for function isManagerPortal() Loading history...
16			{
17			$url = URL::current();
18			return $this->urlIsManagerPortal($url);
19			}
20
21			public function isHrPortal()
			2 ignored issues – show introduced 2019-12-05 23:16 UTC by Report Bug Copy Issue Report Method \App\Services\WhichPortal::isHrPortal() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-12-05 23:16 UTC by Report Bug Copy Issue Report Missing doc comment for function isHrPortal() Loading history...
22			{
23			$url = URL::current();
24			return $this->urlIsHrPortal($url);
25			}
26
27			public function isAdminPortal()
			2 ignored issues – show introduced 2019-12-05 15:07 UTC by Report Bug Copy Issue Report Method \App\Services\WhichPortal::isAdminPortal() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-11-28 20:07 UTC by Report Bug Copy Issue Report Missing doc comment for function isAdminPortal() Loading history...
28			{
29			$url = URL::current();
30			return $this->urlIsAdminPortal($url);
31			}
32
33			public function urlIsManagerPortal($url): bool
			1 ignored issue – show Coding Style Documentation introduced 2019-07-03 15:34 UTC by Report Bug Copy Issue Report Missing doc comment for function urlIsManagerPortal() Loading history... introduced 2019-12-05 15:07 UTC by Report Bug Copy Issue Report Method \App\Services\WhichPortal::urlIsManagerPortal() does not have parameter type hint nor @param annotation for its parameter $url. Loading history...
34			{
35			$baseUrl = config('app.url');
36			$managerPrefix = config('app.manager_prefix');
37			$managerPattern = "#^$baseUrl/(\w+/)?$managerPrefix(/.*)?$#";
38			return preg_match($managerPattern, $url);
			0 ignored issues – show Bug Best Practice introduced 2019-07-03 15:34 UTC by Report Bug Copy Issue Report The expression `return preg_match($managerPattern, $url)` returns the type `integer` which is incompatible with the type-hinted return `boolean`. Loading history...
39			}
40
41			public function urlIsHrPortal($url): bool
			1 ignored issue – show introduced 2019-12-05 23:16 UTC by Report Bug Copy Issue Report Method \App\Services\WhichPortal::urlIsHrPortal() does not have parameter type hint nor @param annotation for its parameter $url. Loading history... Coding Style Documentation introduced 2019-12-05 23:16 UTC by Report Bug Copy Issue Report Missing doc comment for function urlIsHrPortal() Loading history...
42			{
43			$baseUrl = config('app.url');
44			$hrPrefix = config('app.hr_prefix');
45			$hrPattern = "#^$baseUrl/(\w+/)?$hrPrefix(/.*)?$#";
46			return preg_match($hrPattern, $url);
			0 ignored issues – show Bug Best Practice introduced 2019-11-14 19:46 UTC by Report Bug Copy Issue Report The expression `return preg_match($hrPattern, $url)` returns the type `integer` which is incompatible with the type-hinted return `boolean`. Loading history...
47			}
48
49			public function urlIsAdminPortal($url): bool
			1 ignored issue – show introduced 2019-12-05 15:07 UTC by Report Bug Copy Issue Report Method \App\Services\WhichPortal::urlIsAdminPortal() does not have parameter type hint nor @param annotation for its parameter $url. Loading history... Coding Style Documentation introduced 2019-11-28 20:07 UTC by Report Bug Copy Issue Report Missing doc comment for function urlIsAdminPortal() Loading history...
50			{
51			$baseUrl = config('app.url');
52			$adminPrefix = config('backpack.base.route_prefix', 'admin');
53			$adminPattern = "#^$baseUrl/(\w+/)?$adminPrefix(/.*)?$#";
54			return preg_match($adminPattern, $url);
			0 ignored issues – show Bug Best Practice introduced 2019-09-04 17:33 UTC by Report Bug Copy Issue Report The expression `return preg_match($adminPattern, $url)` returns the type `integer` which is incompatible with the type-hinted return `boolean`. Loading history...
55			}
56			}
57

GCTC-NTGC / TalentCloud

Push — feature/redux-claim-job ( b0411b )

WhichPortal::isHrPortal() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like