ContainsObjectWithAttributeRule::message() - Code Metrics - Inspection of "Merge branch 'dev' into allow-managers-to-edit-job..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — allow-managers-to-edit-job-pos... ( 73e355...e58fba )

by Tristan

created 2019-01-04 01:21 UTC

ContainsObjectWithAttributeRule::message() A

↳ Parent: ContainsObjectWithAttributeRule

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php


namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;

class ContainsObjectWithAttributeRule implements Rule

{

    protected $attributeName;
    protected $attributeValue;

    /**

     * Create a new rule instance.
     *
     * @param  App\Models\Applicant  $applicant

     * @param  string  $relation

     * @return void

     */
    public function __construct($attributeName, $attributeValue)
    {
        $this->attributeName = $attributeName;
        $this->attributeValue = $attributeValue;
    }

    protected function array_any(array $array, callable $fn) {

        foreach ($array as $value) {
            if($fn($value)) {

                return true;
            }
        }
        return false;
    }

    /**
     * This check passes if the $value is an array which contains an object
     *  with a attributeName relation equal to attributeValue
     * @param  [type] $attribute [description]

     * @param  [type] $value     [description]
     * @return boolean            [description]

     */
    public function passes($attribute, $value)
    {
        // debugbar()->debug($value);
        // debugbar()->debug($this->attributeName);
        // debugbar()->debug($this->attributeValue);
        return $this->array_any($value, function ($object) {

            return $object[$this->attributeName] == $this->attributeValue;
        });
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
    }

    public function message()

    {
        return Lang::trans('validation.contains_object_with_attribute', ['relation' => $this->attributeName, 'attributeValue' => $this->attributeValue]);

    }
}


1			<?php
2
			0 ignored issues – show Coding Style introduced 2018-11-20 15:47 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
3			namespace App\Services\Validation\Rules;
4
5			use Illuminate\Contracts\Validation\Rule;
6			use Illuminate\Support\Facades\Lang;
7
8			class ContainsObjectWithAttributeRule implements Rule
			0 ignored issues – show Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Missing doc comment for class ContainsObjectWithAttributeRule Loading history...
9			{
10
11			protected $attributeName;
12			protected $attributeValue;
13
14			/**
			0 ignored issues – show Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Parameter `$attributeName` should have a doc-comment as per coding-style. Loading history... Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Parameter `$attributeValue` should have a doc-comment as per coding-style. Loading history...
15			* Create a new rule instance.
16			*
17			* @param App\Models\Applicant $applicant
			0 ignored issues – show Bug introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report The type `App\Services\Validation\Rules\App\Models\Applicant` was not found. Did you mean `App\Models\Applicant`? If so, make sure to prefix the type with `\`. Loading history... Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history... Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Expected 1 spaces after parameter type; 2 found Loading history... Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Doc comment for parameter $applicant does not match actual variable name $attributeName Loading history...
18			* @param string $relation
			0 ignored issues – show Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history... Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Expected 15 spaces after parameter type; 2 found Loading history... Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Doc comment for parameter $relation does not match actual variable name $attributeValue Loading history...
19			* @return void
			0 ignored issues – show Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Tag cannot be grouped with parameter tags in a doc comment Loading history...
20			*/
21			public function __construct($attributeName, $attributeValue)
22			{
23			$this->attributeName = $attributeName;
24			$this->attributeValue = $attributeValue;
25			}
26
27			protected function array_any(array $array, callable $fn) {
			0 ignored issues – show Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Missing doc comment for function array_any() Loading history... Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Protected method name "ContainsObjectWithAttributeRule::array_any" is not in camel caps format Loading history...
28			foreach ($array as $value) {
29			if($fn($value)) {
			0 ignored issues – show Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Expected "if (...) {\n"; found "if(...) {\n" Loading history...
30			return true;
31			}
32			}
33			return false;
34			}
35
36			/**
37			* This check passes if the $value is an array which contains an object
38			* with a attributeName relation equal to attributeValue
39			* @param [type] $attribute [description]
			0 ignored issues – show Documentation Bug introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report The doc comment `[type]` at position `0` could not be parsed: Unknown type name '[' at position 0 in [type]. Loading history... Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report There must be exactly one blank line before the tags in a doc comment Loading history...
40			* @param [type] $value [description]
41			* @return boolean [description]
			0 ignored issues – show Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report Tag cannot be grouped with parameter tags in a doc comment Loading history...
42			*/
43			public function passes($attribute, $value)
44			{
45			// debugbar()->debug($value);
46			// debugbar()->debug($this->attributeName);
47			// debugbar()->debug($this->attributeValue);
48			return $this->array_any($value, function ($object) {
			0 ignored issues – show Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report The opening parenthesis of a multi-line function call should be the last content on the line. Loading history...
49			return $object[$this->attributeName] == $this->attributeValue;
50			});
			0 ignored issues – show Coding Style introduced 2018-12-07 23:36 UTC by Report Bug Copy Issue Report For multi-line function calls, the closing parenthesis should be on a new line. If a function call spawns multiple lines, the coding standard suggests to move the closing parenthesis to a new line: someFunctionCall( $firstArgument, $secondArgument, $thirdArgument ); // Closing parenthesis on a new line. Loading history...
51			}
52
53			public function message()
			0 ignored issues – show Coding Style introduced 2018-12-13 20:56 UTC by Report Bug Copy Issue Report Missing doc comment for function message() Loading history...
54			{
55			return Lang::trans('validation.contains_object_with_attribute', ['relation' => $this->attributeName, 'attributeValue' => $this->attributeValue]);
			0 ignored issues – show Bug Best Practice introduced 2018-12-13 20:56 UTC by Report Bug Copy Issue Report The expression `return Illuminate\Suppor...$this->attributeValue))` also could return the type `array` which is incompatible with the return type mandated by `Illuminate\Contracts\Validation\Rule::message()` of `string`. Loading history...
56			}
57			}
58

GCTC-NTGC / TalentCloud

Push — allow-managers-to-edit-job-pos... ( 73e355...e58fba )

ContainsObjectWithAttributeRule::message() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like