App\Http\Controllers\Api\ManagerController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	destroy()	0	2	1
A	update()	0	6	1
A	store()	0	2	1
A	index()	0	2	1
A	__construct()	0	4	1
A	show()	0	3	1
A	showAuthenticated()	0	7	3

<?php

namespace App\Http\Controllers\Api;

use App\Http\Controllers\Controller;
use App\Http\Requests\UpdateManagerApi;
use App\Models\Manager;
use Illuminate\Http\Request;
use Illuminate\Http\Resources\Json\JsonResource;
use Illuminate\Support\Facades\Auth;

class ManagerController extends Controller
{
    /**
     * Class constructor.
     */
    public function __construct()
    {
        // This applies the appropriate policy to each resource route.
        $this->authorizeResource(Manager::class, 'manager');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response

Function return type is not void, but function has no return statement

     */
    public function index()
    {
        // TODO: complete.
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request $request Incoming Request.
     * @return \Illuminate\Http\Response

Function return type is not void, but function has no return statement

     */
    public function store(Request $request)

The parameter $request is not used and could be removed.

    {
        // TODO: complete.
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Models\Manager $manager Incoming Manager.
     * @return \Illuminate\Http\Response
     */
    public function show(Manager $manager)
    {
        return new JsonResource($manager);
    }

    /**
     * Display the Manager for the current logged in user.
     *
     * @return \Illuminate\Http\Response
     */
    public function showAuthenticated()
    {
        $user = Auth::user();
        if ($user !== null && $user->manager !== null) {

Accessing manager on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            return new JsonResource($user->manager);
        }
        return response()->json([]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \App\Http\Requests\UpdateManagerApi $request Incoming Form Request.
     * @param  \App\Models\Manager                 $manager Incoming Manager.
     * @return \Illuminate\Http\Response
     */
    public function update(UpdateManagerApi $request, Manager $manager)
    {
        $validated = $request->validated();
        $manager->fill($validated);
        $manager->save();
        return new JsonResource($manager);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Models\Manager $manager Incoming Manager.
     * @return \Illuminate\Http\Response

Function return type is not void, but function has no return statement

     */
    public function destroy(Manager $manager)

The parameter $manager is not used and could be removed.

    {
        // TODO: complete.
    }
}