AddTranslatedNameAndDescriptionToSkillsTable::up()

Complexity

Conditions	4
Paths	3

Size

Total Lines	21
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function up()
    {
        Schema::table('skills', function (Blueprint $table) {
            $table->json('name')->nullable();
            $table->json('description')->nullable();
        });

        $skills = Skill::all();
        $langEn = Lang::get('common/skills.skills', [], 'en');
        $langFr = Lang::get('common/skills.skills', [], 'fr');

        foreach ($skills as $skill) {
            if (!array_key_exists($skill->key, $langEn) || !array_key_exists($skill->key, $langFr)) {

The property key does not seem to exist on App\Models\Skill. Are you sure there is no database migration missing?

It seems like $langEn can also be of type null and string; however, parameter $search of array_key_exists() does only seem to accept array, maybe add an additional type check?

                continue;
            }
            $skill
                ->setTranslation('name', 'en', $langEn[$skill->key]['name'])
                ->setTranslation('name', 'fr', $langFr[$skill->key]['name'])
                ->setTranslation('description', 'en', $langEn[$skill->key]['description'])
                ->setTranslation('description', 'fr', $langFr[$skill->key]['description'])
                ->save();
        }