SkillDeclarationValidator::validate() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/dev' into rel..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — release/1.0.17 ( f9f3c1...f9f3c1 )

by Grant

created 2019-12-23 21:10 UTC

SkillDeclarationValidator::validate() A

↳ Parent: SkillDeclarationValidator

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
c	0
b	0
f	0
dl	0
loc	3
rs	10
cc	1
nc	1
nop	1

<?php

namespace App\Services\Validation;

use Illuminate\Support\Facades\Validator;
use App\Models\SkillDeclaration;
use App\Services\Validation\Rules\PolyExistsRule;
use App\Services\Validation\Rules\UniqueSkillDeclarationRule;

class SkillDeclarationValidator
{

    public function validator(SkillDeclaration $skillDeclaration)

    {
        $uniqueSkillRule = new UniqueSkillDeclarationRule($skillDeclaration->skillable->skill_declarations, $skillDeclaration->id);

        // Validate basic data is filled in
        $validator = Validator::make($skillDeclaration->getAttributes(), [
            'skill_id' => [
                'required',
                'exists:skills,id',
                $uniqueSkillRule,
            ],
            'skillable_id' => [
                'required',
                new PolyExistsRule($skillDeclaration->skillable_type),
            ],
            'skillable_type' => 'required',
            'skill_status_id' => [
                'required',
                'exists:skill_statuses,id',
            ],
            'skill_level_id' => [
                'required',
                'exists:skill_levels,id',
            ],
            'description' => 'required|string',
        ]);
        return $validator;
    }

    public function validate(SkillDeclaration $skillDeclaration)

    {
        return $this->validator($skillDeclaration)->validate();
    }
}


1			<?php
2
3			namespace App\Services\Validation;
4
5			use Illuminate\Support\Facades\Validator;
6			use App\Models\SkillDeclaration;
7			use App\Services\Validation\Rules\PolyExistsRule;
8			use App\Services\Validation\Rules\UniqueSkillDeclarationRule;
9
10			class SkillDeclarationValidator
11			{
12
13			public function validator(SkillDeclaration $skillDeclaration)
			2 ignored issues – show introduced 2019-12-05 15:07 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\SkillDeclarationValidator::validator() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing doc comment for function validator() Loading history...
14			{
15			$uniqueSkillRule = new UniqueSkillDeclarationRule($skillDeclaration->skillable->skill_declarations, $skillDeclaration->id);
16
17			// Validate basic data is filled in
18			$validator = Validator::make($skillDeclaration->getAttributes(), [
19			'skill_id' => [
20			'required',
21			'exists:skills,id',
22			$uniqueSkillRule,
23			],
24			'skillable_id' => [
25			'required',
26			new PolyExistsRule($skillDeclaration->skillable_type),
27			],
28			'skillable_type' => 'required',
29			'skill_status_id' => [
30			'required',
31			'exists:skill_statuses,id',
32			],
33			'skill_level_id' => [
34			'required',
35			'exists:skill_levels,id',
36			],
37			'description' => 'required\|string',
38			]);
39			return $validator;
40			}
41
42			public function validate(SkillDeclaration $skillDeclaration)
			2 ignored issues – show introduced 2019-12-05 15:07 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\SkillDeclarationValidator::validate() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing doc comment for function validate() Loading history...
43			{
44			return $this->validator($skillDeclaration)->validate();
45			}
46			}
47

GCTC-NTGC / TalentCloud

Push — release/1.0.17 ( f9f3c1...f9f3c1 )

SkillDeclarationValidator::validate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like