App\Services\Validation\Rules\UniqueSkillDeclarationRule

Complexity

Total Complexity

5

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	passes()	0	7	3
A	message()	0	3	1

<?php

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;
use App\Models\Applicant;
use App\Models\SkillDeclaration;

class UniqueSkillDeclarationRule implements Rule
{

    protected $existing_declarations;

Missing member variable doc comment

    protected $skill_declaration_id;

Missing member variable doc comment

    /**

Doc comment for parameter "$skill_declaration_id" missing

Doc comment for parameter "$existing_declarations" missing

     * Create a new rule instance.
     *
     * @param  App\Models\Applicant  $user

The type App\Services\Validation\Rules\App\Models\Applicant was not found. Did you mean App\Models\Applicant? If so, make sure to prefix the type with \.

Missing parameter comment

Expected 1 spaces after parameter type; 2 found

Doc comment for parameter $user does not match actual variable name $existing_declarations

     * @return void
     */
    public function __construct($existing_declarations, $skill_declaration_id = null)

Type hint "App\Models\Applicant" missing for $user

Method \App\Services\Validation\Rules\UniqueSkillDeclarationRule::__construct() does not have parameter type hint nor @param annotation for its parameter $existing_declarations.

Method \App\Services\Validation\Rules\UniqueSkillDeclarationRule::__construct() does not have parameter type hint nor @param annotation for its parameter $skill_declaration_id.

    {
        $this->existing_declarations = $existing_declarations;
        $this->skill_declaration_id = $skill_declaration_id;
    }

    /**
     * This check passes if no there are no previous declarations for this skill,
     * or if they are updating a previously existing declaration
     * @param  [type] $attribute [description]

Parameter comment must start with a capital letter

Parameter comment must end with a full stop

The doc comment [type] at position 0 could not be parsed: Unknown type name '[' at position 0 in [type].

     * @param  [type] $value     [description]

Parameter comment must start with a capital letter

Parameter comment must end with a full stop

     * @return [type]            [description]

The doc comment [type] at position 0 could not be parsed: Unknown type name '[' at position 0 in [type].

     */
    public function passes($attribute, $value)

Type hint "[type]" missing for $attribute

Type hint "[type]" missing for $value

Method \App\Services\Validation\Rules\UniqueSkillDeclarationRule::passes() does not have parameter type hint nor @param annotation for its parameter $attribute.

Method \App\Services\Validation\Rules\UniqueSkillDeclarationRule::passes() does not have parameter type hint nor @param annotation for its parameter $value.

Method \App\Services\Validation\Rules\UniqueSkillDeclarationRule::passes() does not have return type hint nor @return annotation for its return value.

    {
        $prev_declarations_of_skill = $this->existing_declarations->where('skill_id', $value);

        return $prev_declarations_of_skill->isEmpty() ||
            ($this->skill_declaration_id != null
                && $prev_declarations_of_skill->pluck('id')->contains($this->skill_declaration_id));
    }

    public function message()

Missing doc comment for function message()

Method \App\Services\Validation\Rules\UniqueSkillDeclarationRule::message() does not have return type hint nor @return annotation for its return value.

    {
        return Lang::get('validation.user_skill_unique');
    }
}