UserCrudController::setup() - Code Metrics - Inspection of "WIP updated to functional component, refactored fu..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — feature/word_counter ( e4aaca...45e6a8 )

by Yonathan

created 2019-07-31 19:14 UTC

UserCrudController::setup() B

↳ Parent: UserCrudController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	25
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	62
ccs	25
cts	26
cp	0.9615
crap	1
rs	8.829
c	0
b	0
f	0

How to fix Long Method

<?php

namespace App\Http\Controllers\Admin;

use Backpack\CRUD\app\Http\Controllers\CrudController;
use App\Models\UserRole;

class UserCrudController extends CrudController
{
    /**
     * Prepare the admin interface by setting the associated
     * model, setting the route, and adding custom columns/fields.
     *
     * @return void
     */
    public function setup() : void
    {
        $this->crud->setModel("App\Models\User");
        $this->crud->setRoute("admin/user");
        $this->crud->setEntityNameStrings('user', 'users');

        $this->crud->denyAccess('create');
        $this->crud->denyAccess('delete');

        $this->crud->addColumn([
            'name' => 'name',
            'type' => 'text',
            'label' => 'Name'
        ]);
        $this->crud->addColumn([
            'name' => 'email',
            'type' => 'text',
            'label' => 'Email'
        ]);
        $this->crud->addColumn([
            'name' => 'user_role.name',
            'type' => 'text',
            'label' => 'Role'
        ]);
        $this->crud->addColumn([
            'name' => 'is_priority',
            'type' => 'check',
            'label' => 'Priority'
        ]);

        $this->crud->addFilter([
            'name' => 'user_role',
            'type' => 'select2',
            'label' => 'Role'
        ], function () {
            return UserRole::all()->keyBy('id')->pluck('name', 'id')->toArray();
        }, function ($value) : void {
            $this->crud->addClause('where', 'user_role_id', $value);
        });

        $this->crud->addField([
            'name' => 'name',
            'label' => "Name",
            'type' => 'text',
            'attributes' => [
                'readonly'=>'readonly'
            ]
        ]);
        $this->crud->addField([
            'label' => "Role",
            'type' => 'select',
            'name' => 'user_role_id', // the db column for the foreign key
            'entity' => 'user_role', // the method that defines the relationship in your Model
            'attribute' => 'name', // foreign key attribute that is shown to user
            'model' => "App\Models\UserRole" // foreign key model
        ]);
        $this->crud->addField([
            'name' => 'is_priority',
            'type' => 'checkbox',
            'label' => 'Priority'
        ]);
    }

    /**
     * Action for updating an existing User in the database.
     *
     * @param \Illuminate\Http\Request $request Incoming form request.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update($request) // phpcs:ignore

    {
        $response = parent::updateCrud();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        return $response;
    }
}


1		<?php
2
3		namespace App\Http\Controllers\Admin;
4
5		use Backpack\CRUD\app\Http\Controllers\CrudController;
6		use App\Models\UserRole;
7
8		class UserCrudController extends CrudController
9		{
10		/**
11		* Prepare the admin interface by setting the associated
12		* model, setting the route, and adding custom columns/fields.
13		*
14		* @return void
15		*/
16	1	public function setup() : void
17		{
18	1	$this->crud->setModel("App\Models\User");
19	1	$this->crud->setRoute("admin/user");
20	1	$this->crud->setEntityNameStrings('user', 'users');
21
22	1	$this->crud->denyAccess('create');
23	1	$this->crud->denyAccess('delete');
24
25	1	$this->crud->addColumn([
26	1	'name' => 'name',
27		'type' => 'text',
28		'label' => 'Name'
29		]);
30	1	$this->crud->addColumn([
31	1	'name' => 'email',
32		'type' => 'text',
33		'label' => 'Email'
34		]);
35	1	$this->crud->addColumn([
36	1	'name' => 'user_role.name',
37		'type' => 'text',
38		'label' => 'Role'
39		]);
40	1	$this->crud->addColumn([
41	1	'name' => 'is_priority',
42		'type' => 'check',
43		'label' => 'Priority'
44		]);
45
46	1	$this->crud->addFilter([
47	1	'name' => 'user_role',
48		'type' => 'select2',
49		'label' => 'Role'
50		], function () {
51	1	return UserRole::all()->keyBy('id')->pluck('name', 'id')->toArray();
52		}, function ($value) : void {
53		$this->crud->addClause('where', 'user_role_id', $value);
54	1	});
55
56	1	$this->crud->addField([
57	1	'name' => 'name',
58		'label' => "Name",
59		'type' => 'text',
60		'attributes' => [
61		'readonly'=>'readonly'
62		]
63		]);
64	1	$this->crud->addField([
65	1	'label' => "Role",
66		'type' => 'select',
67		'name' => 'user_role_id', // the db column for the foreign key
68		'entity' => 'user_role', // the method that defines the relationship in your Model
69		'attribute' => 'name', // foreign key attribute that is shown to user
70		'model' => "App\Models\UserRole" // foreign key model
71		]);
72	1	$this->crud->addField([
73	1	'name' => 'is_priority',
74		'type' => 'checkbox',
75		'label' => 'Priority'
76		]);
77	1	}
78
79		/**
80		* Action for updating an existing User in the database.
81		*
82		* @param \Illuminate\Http\Request $request Incoming form request.
83		*
84		* @return \Illuminate\Http\RedirectResponse
85		*/
86		public function update($request) // phpcs:ignore
		0 ignored issues – show Unused Code introduced 2019-07-09 12:53 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
87		{
88		$response = parent::updateCrud();
		0 ignored issues – show Comprehensibility Bug introduced 2019-07-09 12:53 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`updateCrud()` instead of `update()`). Are you sure this is correct? If so, you might want to change this to `$this->updateCrud()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
89		return $response;
90		}
91		}
92

GCTC-NTGC / TalentCloud

Push — feature/word_counter ( e4aaca...45e6a8 )

UserCrudController::setup() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like