Passed
Branch feature/immutable-application-... (238d28)
by Grant
08:39
created
database/factories/RatingGuideAnswerFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -5,9 +5,9 @@
 block discarded – undo
5 5
 use App\Models\Skill;
6 6
 use App\Models\Criteria;
7 7
 
8
-$factory->define(RatingGuideAnswer::class, function (Faker\Generator $faker) {
8
+$factory->define(RatingGuideAnswer::class, function(Faker\Generator $faker){
9 9
     return [
10
-        'rating_guide_question_id' => function () {
10
+        'rating_guide_question_id' => function(){
11 11
             return factory(RatingGuideQuestion::class)->create()->id;
12 12
         },
13 13
         'criterion_id' => null,
Please login to merge, or discard this patch.
database/seeds/DevSeeder.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 
61 61
         factory(JobPoster::class, 3)->state('published')->create([
62 62
             'manager_id' => $managerUser->manager->id
63
-        ])->each(function ($job) : void {
63
+        ])->each(function($job) : void {
64 64
             $job->job_applications()->saveMany(factory(JobApplication::class, 5))->create([
65 65
                 'job_poster_id' => $job->id
66 66
             ]);
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
         });
75 75
         factory(JobPoster::class, 3)->state('closed')->create([
76 76
             'manager_id' => $managerUser->manager->id
77
-        ])->each(function ($job) : void {
77
+        ])->each(function($job) : void {
78 78
             $job->job_applications()->saveMany(factory(JobApplication::class, 5))->create([
79 79
                 'job_poster_id' => $job->id
80 80
             ]);
Please login to merge, or discard this patch.
routes/backpack/custom.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@
 block discarded – undo
9 9
     'prefix' => config('backpack.base.route_prefix', 'admin'),
10 10
     'middleware' => ['web', config('backpack.base.middleware_key', 'admin')],
11 11
     'namespace' => 'App\Http\Controllers\Admin',
12
-], function () : void {
12
+], function() : void {
13 13
     // Custom admin routes.
14 14
     Route::crud('skill', 'SkillCrudController');
15 15
     Route::crud('job-poster', 'JobPosterCrudController');
Please login to merge, or discard this patch.
database/factories/CriteriaFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -8,10 +8,10 @@
 block discarded – undo
8 8
 
9 9
 $faker_fr = Faker\Factory::create('fr');
10 10
 
11
-$factory->define(Criteria::class, function (Faker\Generator $faker) use ($faker_fr) {
11
+$factory->define(Criteria::class, function(Faker\Generator $faker) use ($faker_fr) {
12 12
     return [
13 13
         'criteria_type_id' => CriteriaType::inRandomOrder()->first()->id,
14
-        'job_poster_id' => function () {
14
+        'job_poster_id' => function(){
15 15
             return factory(JobPoster::class)->create()->id;
16 16
         },
17 17
         'skill_id' => Skill::inRandomOrder()->first()->id,
Please login to merge, or discard this patch.
database/factories/WorkEnvironmentFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -6,14 +6,14 @@
 block discarded – undo
6 6
 use App\Models\Manager;
7 7
 use App\Models\Lookup\Frequency;
8 8
 
9
-$factory->define(WorkEnvironment::class, function (Faker $faker) {
9
+$factory->define(WorkEnvironment::class, function(Faker $faker){
10 10
     $faker_fr = FakerFactory::create('fr');
11 11
     return [
12 12
         'telework_allowed_frequency_id' => Frequency::inRandomOrder()->first()->id,
13 13
         'flexible_hours_frequency_id' => Frequency::inRandomOrder()->first()->id,
14 14
         'things_to_know:en' => $faker->paragraph(),
15 15
         'things_to_know:fr' => $faker_fr->paragraph(),
16
-        'manager_id' => function () {
16
+        'manager_id' => function(){
17 17
             return factory(Manager::class)->create()->id;
18 18
         }
19 19
     ];
Please login to merge, or discard this patch.
database/factories/JobPosterQuestionFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -5,9 +5,9 @@
 block discarded – undo
5 5
 
6 6
 $faker_fr = Faker\Factory::create('fr');
7 7
 
8
-$factory->define(JobPosterQuestion::class, function (Faker\Generator $faker) use ($faker_fr) {
8
+$factory->define(JobPosterQuestion::class, function(Faker\Generator $faker) use ($faker_fr) {
9 9
     return [
10
-        'job_poster_id' => function () {
10
+        'job_poster_id' => function(){
11 11
             return factory(JobPoster::class)->create()->id;
12 12
         },
13 13
         'description:en' => $faker->sentence(),
Please login to merge, or discard this patch.
database/factories/TeamCultureFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@  discard block
 block discarded – undo
5 5
 use App\Models\TeamCulture;
6 6
 use App\Models\Manager;
7 7
 
8
-$factory->define(TeamCulture::class, function (Faker $faker) {
8
+$factory->define(TeamCulture::class, function(Faker $faker){
9 9
     $faker_fr = FakerFactory::create('fr');
10 10
     return [
11 11
         'team_size' => $faker->numberBetween(5, 15),
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
         'operating_context:fr' => $faker_fr->paragraph(),
19 19
         'what_we_value:fr' => $faker_fr->paragraph(),
20 20
         'how_we_work:fr' => $faker_fr->paragraph(),
21
-        'manager_id' => function () {
21
+        'manager_id' => function(){
22 22
             return factory(Manager::class)->create()->id;
23 23
         }
24 24
     ];
Please login to merge, or discard this patch.
database/factories/JobPosterKeyTaskFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -5,9 +5,9 @@
 block discarded – undo
5 5
 
6 6
 $faker_fr = Faker\Factory::create('fr');
7 7
 
8
-$factory->define(JobPosterKeyTask::class, function (Faker\Generator $faker) use ($faker_fr) {
8
+$factory->define(JobPosterKeyTask::class, function(Faker\Generator $faker) use ($faker_fr) {
9 9
     return [
10
-        'job_poster_id' => function () {
10
+        'job_poster_id' => function(){
11 11
             return factory(JobPoster::class)->create()->id;
12 12
         },
13 13
         'description:en' => $faker->sentence(),
Please login to merge, or discard this patch.
app/Http/Controllers/Api/CriteriaController.php 2 patches
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -12,11 +12,11 @@
 block discarded – undo
12 12
 class CriteriaController extends Controller
13 13
 {
14 14
 /**
15
-     * Converts a Criteria to the shape sent and recieved by the api.
16
-     *
17
-     * @param Criteria $model
18
-     * @return void
19
-     */
15
+ * Converts a Criteria to the shape sent and recieved by the api.
16
+ *
17
+ * @param Criteria $model
18
+ * @return void
19
+ */
20 20
     public function toApiArray(Criteria $model)
21 21
     {
22 22
         return array_merge($model->toArray(), $model->getTranslationsArray());
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
             }
63 63
         }
64 64
 
65
-        $isUnsaved = function ($criteria, $savedIds): bool {
65
+        $isUnsaved = function($criteria, $savedIds): bool {
66 66
             return !array_key_exists('id', $criteria) || !in_array($criteria['id'], $savedIds);
67 67
         };
68 68
 
@@ -163,7 +163,7 @@  discard block
 block discarded – undo
163 163
         $newSkillId = null,
164 164
         $newSkillLevelId = null,
165 165
         $newCriteriaTypeId = null
166
-    ) {
166
+    ){
167 167
         $notification = new AssessmentPlanNotification();
168 168
         $notification->job_poster_id = $criteria->job_poster_id;
169 169
         $notification->type = $type;
Please login to merge, or discard this patch.