GCTC-NTGC / TalentCloud

app/Http/Controllers/Auth/ResetPasswordController.php

Spacing +9 added lines, -9 removed lines

@@ -31,12 +31,12 @@ 
      */
     protected function redirectTo()
     {
-        if (WhichPortal::isManagerPortal()) {
-            $redirectTo = route('manager.home');
-        } elseif (WhichPortal::isHrPortal()) {
-            $redirectTo = route('hr_advisor.home');
+        if (WhichPortal::isManagerPortal ()) {
+            $redirectTo = route ('manager.home');
+        } elseif (WhichPortal::isHrPortal ()) {
+            $redirectTo = route ('hr_advisor.home');
         } else {
-            $redirectTo = route('home');
+            $redirectTo = route ('home');
         }
         return $redirectTo;
     }
@@ -48,7 +48,7 @@ 
      */
     public function __construct()
     {
-        $this->middleware('guest');
+        $this->middleware ('guest');
     }
 
     /**
@@ -62,11 +62,11 @@ 
      */
     public function showResetForm(Request $request, $token = null)
     {
-        return view('auth.passwords.reset')->with([
+        return view ('auth.passwords.reset')->with ([
             'token' => $token,
             'email' => $request->email,
-            'routes' => $this->auth_routes(),
-            'reset_password' => Lang::get('common/auth/reset_password'),
+            'routes' => $this->auth_routes (),
+            'reset_password' => Lang::get ('common/auth/reset_password'),
         ]);
     }
 

app/Http/Controllers/JobController.php

Spacing +71 added lines, -71 removed lines

@@ -23,26 +23,26 @@ 
      */
     public function index()
     {
-        $now = Carbon::now();
+        $now = Carbon::now ();
 
         // Find published jobs that are currently open for applications.
         // Eager load required relationships: Department, Province, JobTerm.
         // Eager load the count of submitted applications, to prevent the relationship
         // from being actually loaded and firing off events.
-        $jobs = JobPoster::where('open_date_time', '<=', $now)
-            ->where('close_date_time', '>=', $now)
-            ->where('published', true)
-            ->with([
+        $jobs = JobPoster::where ('open_date_time', '<=', $now)
+            ->where ('close_date_time', '>=', $now)
+            ->where ('published', true)
+            ->with ([
                 'department',
                 'province',
                 'job_term',
             ])
-            ->withCount([
+            ->withCount ([
                 'submitted_applications',
             ])
-            ->get();
-        return view('applicant/job_index', [
-            'job_index' => Lang::get('applicant/job_index'),
+            ->get ();
+        return view ('applicant/job_index', [
+            'job_index' => Lang::get ('applicant/job_index'),
             'jobs' => $jobs
         ]);
     }
@@ -54,31 +54,31 @@ 
      */
     public function managerIndex()
     {
-        $manager = Auth::user()->manager;
+        $manager = Auth::user ()->manager;
 
-        $jobs = JobPoster::where('manager_id', $manager->id)
-            ->with('classification')
-            ->withCount('submitted_applications')
-            ->get();
+        $jobs = JobPoster::where ('manager_id', $manager->id)
+            ->with ('classification')
+            ->withCount ('submitted_applications')
+            ->get ();
 
         foreach ($jobs as &$job) {
             $chosen_lang = $job->chosen_lang;
 
             // Show chosen lang title if current title is empty.
             if (empty($job->title)) {
-                $job->title = $job->translate($chosen_lang)->title;
+                $job->title = $job->translate ($chosen_lang)->title;
                 $job->trans_required = true;
             }
 
             // Always preview and edit in the chosen language.
-            $job->preview_link = LaravelLocalization::getLocalizedURL($chosen_lang, route('manager.jobs.show', $job));
-            $job->edit_link = LaravelLocalization::getLocalizedURL($chosen_lang, route('manager.jobs.edit', $job));
+            $job->preview_link = LaravelLocalization::getLocalizedURL ($chosen_lang, route ('manager.jobs.show', $job));
+            $job->edit_link = LaravelLocalization::getLocalizedURL ($chosen_lang, route ('manager.jobs.edit', $job));
         }
 
 
-        return view('manager/job_index', [
+        return view ('manager/job_index', [
             // Localization Strings.
-            'jobs_l10n' => Lang::get('manager/job_index'),
+            'jobs_l10n' => Lang::get ('manager/job_index'),
             // Data.
             'jobs' => $jobs,
         ]);
@@ -93,7 +93,7 @@ 
      */
     public function destroy(Request $request, JobPoster $jobPoster)
     {
-        $jobPoster->delete();
+        $jobPoster->delete ();
     }
 
     /**
@@ -105,14 +105,14 @@ 
      */
     public function show(Request $request, JobPoster $jobPoster)
     {
-        $jobPoster->load([
+        $jobPoster->load ([
             'department',
             'criteria.skill.skill_type',
             'manager.team_culture',
             'manager.work_environment'
         ]);
 
-        $user = Auth::user();
+        $user = Auth::user ();
 
         // TODO: Improve workplace photos, and reference them in template direction from WorkEnvironment model.
         $workplacePhotos = [];
@@ -125,36 +125,36 @@ 
 
         // TODO: replace route('manager.show',manager.id) in templates with link using slug.
         $criteria = [
-            'essential' => $jobPoster->criteria->filter(
-                function ($value, $key) {
+            'essential' => $jobPoster->criteria->filter (
+                function ($value, $key){
                     return $value->criteria_type->name == 'essential';
                 }
             ),
-            'asset' => $jobPoster->criteria->filter(
-                function ($value, $key) {
+            'asset' => $jobPoster->criteria->filter (
+                function ($value, $key){
                     return $value->criteria_type->name == 'asset';
                 }
             ),
         ];
 
-        $jobLang = Lang::get('applicant/job_post');
+        $jobLang = Lang::get ('applicant/job_post');
 
         $applyButton = [];
-        if (!$jobPoster->published && $this->authorize('update', $jobPoster)) {
+        if (!$jobPoster->published && $this->authorize ('update', $jobPoster)) {
             $applyButton = [
-                'href' => route('manager.jobs.edit', $jobPoster->id),
+                'href' => route ('manager.jobs.edit', $jobPoster->id),
                 'title' => $jobLang['apply']['edit_link_title'],
                 'text' => $jobLang['apply']['edit_link_label'],
             ];
-        } elseif (Auth::check() && $jobPoster->isOpen()) {
+        } elseif (Auth::check () && $jobPoster->isOpen ()) {
             $applyButton = [
-                'href' => route('job.application.edit.1', $jobPoster->id),
+                'href' => route ('job.application.edit.1', $jobPoster->id),
                 'title' => $jobLang['apply']['apply_link_title'],
                 'text' => $jobLang['apply']['apply_link_label'],
             ];
-        } elseif (Auth::guest() && $jobPoster->isOpen()) {
+        } elseif (Auth::guest () && $jobPoster->isOpen ()) {
             $applyButton = [
-                'href' => route('job.application.edit.1', $jobPoster->id),
+                'href' => route ('job.application.edit.1', $jobPoster->id),
                 'title' => $jobLang['apply']['login_link_title'],
                 'text' => $jobLang['apply']['login_link_label'],
             ];
@@ -166,19 +166,19 @@ 
             ];
         }
 
-        $jpb_release_date = strtotime('2019-08-21 16:18:17');
-        $job_created_at = strtotime($jobPoster->created_at);
+        $jpb_release_date = strtotime ('2019-08-21 16:18:17');
+        $job_created_at = strtotime ($jobPoster->created_at);
 
         // If the job poster is created after the release of the JPB.
         // Then, render with updated poster template.
         // Else, render with old poster template.
         if ($job_created_at > $jpb_release_date) {
             // Updated job poster (JPB).
-            return view(
+            return view (
                 'applicant/jpb_job_post',
                 [
                     'job_post' => $jobLang,
-                    'skill_template' => Lang::get('common/skills'),
+                    'skill_template' => Lang::get ('common/skills'),
                     'job' => $jobPoster,
                     'manager' => $jobPoster->manager,
                     'criteria' => $criteria,
@@ -187,7 +187,7 @@ 
             );
         } else {
             // Old job poster.
-            return view(
+            return view (
                 'applicant/job_post',
                 [
                     'job_post' => $jobLang,
@@ -199,7 +199,7 @@ 
                     'job' => $jobPoster,
                     'criteria' => $criteria,
                     'apply_button' => $applyButton,
-                    'skill_template' => Lang::get('common/skills'),
+                    'skill_template' => Lang::get ('common/skills'),
                 ]
             );
         }
@@ -217,20 +217,20 @@ 
     {
         $manager = $jobPoster->manager;
 
-        if ($jobPoster->job_poster_questions === null || $jobPoster->job_poster_questions->count() === 0) {
-            $jobPoster->job_poster_questions()->saveMany($this->populateDefaultQuestions());
-            $jobPoster->refresh();
+        if ($jobPoster->job_poster_questions === null || $jobPoster->job_poster_questions->count () === 0) {
+            $jobPoster->job_poster_questions ()->saveMany ($this->populateDefaultQuestions ());
+            $jobPoster->refresh ();
         }
 
-        return view(
+        return view (
             'manager/job_create',
             [
                 // Localization Strings.
-                'job_l10n' => Lang::get('manager/job_edit'),
+                'job_l10n' => Lang::get ('manager/job_edit'),
                 // Data.
                 'manager' => $manager,
                 'job' => $jobPoster,
-                'form_action_url' => route('admin.jobs.update', $jobPoster),
+                'form_action_url' => route ('admin.jobs.update', $jobPoster),
             ]
         );
     }
@@ -243,21 +243,21 @@ 
      */
     public function createAsManager(Manager $manager)
     {
-        $jobPoster = new JobPoster();
+        $jobPoster = new JobPoster ();
         $jobPoster->manager_id = $manager->id;
 
         // Save manager-specific info to the job poster - equivalent to the intro step of the JPB
-        $divisionEn = $manager->translate('en') !== null ? $manager->translate('en')->division : null;
-        $divisionFr = $manager->translate('fr') !== null ? $manager->translate('fr')->division : null;
-        $jobPoster->fill([
+        $divisionEn = $manager->translate ('en') !== null ? $manager->translate ('en')->division : null;
+        $divisionFr = $manager->translate ('fr') !== null ? $manager->translate ('fr')->division : null;
+        $jobPoster->fill ([
             'department_id' => $manager->department_id,
             'en' => ['division' => $divisionEn],
             'fr' => ['division' => $divisionFr],
         ]);
 
-        $jobPoster->save();
+        $jobPoster->save ();
 
-        return redirect()->route('manager.jobs.edit', $jobPoster->id);
+        return redirect ()->route ('manager.jobs.edit', $jobPoster->id);
     }
 
     /**
@@ -272,19 +272,19 @@ 
     {
         // Don't allow edits for published Job Posters
         // Also check auth while we're at it.
-        $this->authorize('update', $jobPoster);
-        JobPosterValidator::validateUnpublished($jobPoster);
+        $this->authorize ('update', $jobPoster);
+        JobPosterValidator::validateUnpublished ($jobPoster);
 
-        $input = $request->input();
+        $input = $request->input ();
 
         if ($jobPoster->manager_id == null) {
-            $jobPoster->manager_id = $request->user()->manager->id;
-            $jobPoster->save();
+            $jobPoster->manager_id = $request->user ()->manager->id;
+            $jobPoster->save ();
         }
 
-        $this->fillAndSaveJobPosterQuestions($input, $jobPoster, true);
+        $this->fillAndSaveJobPosterQuestions ($input, $jobPoster, true);
 
-        return redirect(route('manager.jobs.show', $jobPoster->id));
+        return redirect (route ('manager.jobs.show', $jobPoster->id));
     }
 
     /**
@@ -298,17 +298,17 @@ 
     protected function fillAndSaveJobPosterQuestions(array $input, JobPoster $jobPoster, bool $replace) : void
     {
         if ($replace) {
-            $jobPoster->job_poster_questions()->delete();
+            $jobPoster->job_poster_questions ()->delete ();
         }
 
-        if (!array_key_exists('question', $input) || !is_array($input['question'])) {
+        if (!array_key_exists ('question', $input) || !is_array ($input['question'])) {
             return;
         }
 
         foreach ($input['question'] as $question) {
-            $jobQuestion = new JobPosterQuestion();
+            $jobQuestion = new JobPosterQuestion ();
             $jobQuestion->job_poster_id = $jobPoster->id;
-            $jobQuestion->fill(
+            $jobQuestion->fill (
                 [
                     'en' => [
                         'question' => $question['question']['en'],
@@ -320,8 +320,8 @@ 
                     ]
                 ]
             );
-            $jobPoster->save();
-            $jobQuestion->save();
+            $jobPoster->save ();
+            $jobQuestion->save ();
         }
     }
 
@@ -333,20 +333,20 @@ 
     protected function populateDefaultQuestions()
     {
         $defaultQuestions = [
-            'en' => array_values(Lang::get('manager/job_create', [], 'en')['questions']),
-            'fr' => array_values(Lang::get('manager/job_create', [], 'fr')['questions']),
+            'en' => array_values (Lang::get ('manager/job_create', [], 'en')['questions']),
+            'fr' => array_values (Lang::get ('manager/job_create', [], 'fr')['questions']),
         ];
 
-        if (count($defaultQuestions['en']) !== count($defaultQuestions['fr'])) {
-            Log::warning('There must be the same number of French and English default questions for a Job Poster.');
+        if (count ($defaultQuestions['en']) !== count ($defaultQuestions['fr'])) {
+            Log::warning ('There must be the same number of French and English default questions for a Job Poster.');
             return;
         }
 
         $jobQuestions = [];
 
-        for ($i = 0; $i < count($defaultQuestions['en']); $i++) {
-            $jobQuestion = new JobPosterQuestion();
-            $jobQuestion->fill(
+        for ($i = 0; $i < count ($defaultQuestions['en']); $i++) {
+            $jobQuestion = new JobPosterQuestion ();
+            $jobQuestion->fill (
                 [
                     'en' => [
                         'question' => $defaultQuestions['en'][$i],

app/Http/Controllers/ManagerProfileController.php

Spacing +28 added lines, -28 removed lines

@@ -26,7 +26,7 @@ 
      */
     public function show(Request $request, Manager $manager)
     {
-        $manager_profile = Lang::get('applicant/manager_profile');
+        $manager_profile = Lang::get ('applicant/manager_profile');
 
         $manager_profile_sections = [
             [
@@ -65,9 +65,9 @@ 
             ]
         ];
 
-        return view('applicant/manager', [
+        return view ('applicant/manager', [
             'manager_profile' => $manager_profile,
-            'urls' => Lang::get('common/urls'),
+            'urls' => Lang::get ('common/urls'),
             'manager' => $manager,
             'manager_profile_photo_url' => '/images/user.png', // TODO get real photo.
             'manager_profile_sections' => $manager_profile_sections,
@@ -83,8 +83,8 @@ 
      */
     public function editAuthenticated(Request $request)
     {
-        $manager = $request->user()->manager;
-        return redirect(route('manager.profile.edit', $manager));
+        $manager = $request->user ()->manager;
+        return redirect (route ('manager.profile.edit', $manager));
     }
 
     /**
@@ -99,25 +99,25 @@ 
         // TODO: Improve workplace photos, and reference them in template direction from WorkEnvironment model.
         $workplacePhotos = [];
 
-        $frequencies = Frequency::all();
+        $frequencies = Frequency::all ();
         $linkedInUrlPattern = LinkedInUrlRule::PATTERN;
         $twitterHandlePattern = TwitterHandleRule::PATTERN;
 
-        return view('manager/profile', [
+        return view ('manager/profile', [
             // Localization.
-            'profile_l10n' => Lang::get('manager/profile'),
+            'profile_l10n' => Lang::get ('manager/profile'),
             // Data.
-            'urls' => Lang::get('common/urls'),
+            'urls' => Lang::get ('common/urls'),
             'user' => $manager->user,
             'manager' => $manager,
             'manager_profile_photo_url' => '/images/user.png', // TODO get real photo.
             'workplace_photos' => $workplacePhotos,
-            'departments' => Department::all(),
+            'departments' => Department::all (),
             'telework_options' => $frequencies,
             'flex_hour_options' => $frequencies,
             'radio_options' => $frequencies,
-            'managerEN' => $manager->translate('en'),
-            'managerFR' => $manager->translate('fr'),
+            'managerEN' => $manager->translate ('en'),
+            'managerFR' => $manager->translate ('fr'),
             'linkedInUrlPattern' => $linkedInUrlPattern,
             'twitterHandlePattern' => $twitterHandlePattern,
         ]);
@@ -134,27 +134,27 @@ 
     {
         // TODO: save workplace Photos.
         // TODO: remove control of name in production.
-        $input = $request->input();
+        $input = $request->input ();
 
         // redirect to error messages element if validation fails
-        if (isset($request->validator) && $request->validator->fails()) {
+        if (isset($request->validator) && $request->validator->fails ()) {
             $hash = '#managerProfileFormErrors';
-            return redirect(route('manager.profile.edit', $manager).$hash)
-                        ->withErrors($request->validator)
-                        ->withInput();
+            return redirect (route ('manager.profile.edit', $manager).$hash)
+                        ->withErrors ($request->validator)
+                        ->withInput ();
         }
 
-        $validated = $request->validated();
+        $validated = $request->validated ();
 
         $user = $manager->user;
-        $user->fill($validated);
+        $user->fill ($validated);
         if (!empty($input['new_password'])) {
-            $user->password = Hash::make($input['new_password']);
+            $user->password = Hash::make ($input['new_password']);
         }
-        $user->save();
+        $user->save ();
 
-        $manager->fill($validated);
-        $manager->save();
+        $manager->fill ($validated);
+        $manager->save ();
 
         // Use the button that was clicked to decide which element to redirect to.
         switch ($input['submit']) {
@@ -172,18 +172,18 @@ 
                 break;
         }
 
-        return redirect(route('manager.profile.edit', $manager).$hash);
+        return redirect (route ('manager.profile.edit', $manager).$hash);
     }
 
     public function faq(Request $request)
     {
-        $show_demo_notification = $request->user() && $request->user()->isDemoManager();
+        $show_demo_notification = $request->user () && $request->user ()->isDemoManager ();
 
-        return view(
+        return view (
             'applicant/static_faq',
             [
-                'breadcrumb_home' => route('manager.home'),
-                'faq' => Lang::get('applicant/faq'),
+                'breadcrumb_home' => route ('manager.home'),
+                'faq' => Lang::get ('applicant/faq'),
                 'manager_sidebar_active' => 'active',
                 'show_demo_notification' => $show_demo_notification,
             ]

app/Http/Controllers/Api/JobApiController.php

Spacing +25 added lines, -25 removed lines

@@ -22,7 +22,7 @@ 
     public function __construct()
     {
         // This applies the appropriate policy to each resource route.
-        $this->authorizeResource(JobPoster::class, 'job');
+        $this->authorizeResource (JobPoster::class, 'job');
     }
 
     /**
@@ -35,14 +35,14 @@ 
      */
     private function jobToArray(JobPoster $job)
     {
-        $criteria = Criteria::where('job_poster_id', $job->id)->get();
+        $criteria = Criteria::where ('job_poster_id', $job->id)->get ();
 
-        $toApiArray = function ($model) {
-            return array_merge($model->toArray(), $model->getTranslationsArray());
+        $toApiArray = function ($model){
+            return array_merge ($model->toArray (), $model->getTranslationsArray ());
         };
-        $criteriaTranslated = $criteria->map($toApiArray);
+        $criteriaTranslated = $criteria->map ($toApiArray);
 
-        $jobArray = array_merge($job->toApiArray(), ['criteria' => $criteriaTranslated]);
+        $jobArray = array_merge ($job->toApiArray (), ['criteria' => $criteriaTranslated]);
         return $jobArray;
     }
     /**
@@ -63,14 +63,14 @@ 
      */
     public function store(StoreJobPoster $request)
     {
-        $data = $request->validated();
-        $job = new JobPoster();
-        $job->manager_id = $request->user()->manager->id;
+        $data = $request->validated ();
+        $job = new JobPoster ();
+        $job->manager_id = $request->user ()->manager->id;
         // Defaulting JPB created Jobs to monthly terms for now.
-        $job->job_term_id = JobTerm::where('name', 'month')->value('id');
-        $job->fill($data);
-        $job->save();
-        return response()->json($this->jobToArray($job));
+        $job->job_term_id = JobTerm::where ('name', 'month')->value ('id');
+        $job->fill ($data);
+        $job->save ();
+        return response ()->json ($this->jobToArray ($job));
     }
 
     /**
@@ -81,7 +81,7 @@ 
      */
     public function show(JobPoster $job)
     {
-        return response()->json($this->jobToArray($job));
+        return response ()->json ($this->jobToArray ($job));
     }
 
     /**
@@ -93,14 +93,14 @@ 
      */
     public function update(UpdateJobPoster $request, JobPoster $job)
     {
-        $data = $request->validated();
+        $data = $request->validated ();
         // Only values both in the JobPoster->fillable array,
         // and returned by UpdateJobPoster->validatedData(), will be set.
-        $job->fill($data);
+        $job->fill ($data);
         // Defaulting JPB updated jobs to monthly for now.
-        $job->job_term_id = JobTerm::where('name', 'month')->value('id');
-        $job->save();
-        return response()->json($this->jobToArray($job->fresh()));
+        $job->job_term_id = JobTerm::where ('name', 'month')->value ('id');
+        $job->save ();
+        return response ()->json ($this->jobToArray ($job->fresh ()));
     }
 
     /**
@@ -125,18 +125,18 @@ 
         // Check to avoid submitting for review multiple times.
         if ($job->review_requested_at === null) {
             // Update review request timestamp.
-            $job->review_requested_at = new Date();
-            $job->save();
+            $job->review_requested_at = new Date ();
+            $job->save ();
 
             // Send email.
-            $reviewer_email = config('mail.reviewer_email');
+            $reviewer_email = config ('mail.reviewer_email');
             if (isset($reviewer_email)) {
-                Mail::to($reviewer_email)->send(new JobPosterReviewRequested($job, Auth::user()));
+                Mail::to ($reviewer_email)->send (new JobPosterReviewRequested ($job, Auth::user ()));
             } else {
-                Log::error('The reviewer email environment variable is not set.');
+                Log::error ('The reviewer email environment variable is not set.');
             }
         }
 
-        return response()->json($this->jobToArray($job));
+        return response ()->json ($this->jobToArray ($job));
     }
 }

app/Http/Controllers/Api/JobTaskController.php

Spacing +15 added lines, -15 removed lines

@@ -17,14 +17,14 @@ 
      */
     public function toApiArray(JobPosterKeyTask $model)
     {
-        return array_merge($model->toArray(), $model->getTranslationsArray());
+        return array_merge ($model->toArray (), $model->getTranslationsArray ());
     }
 
     public function indexByJob(JobPoster $jobPoster)
     {
         $toApiArray = array($this, 'toApiArray');
-        $taskArray = JobPosterKeyTask::where('job_poster_id', $jobPoster->id)->get()->map($toApiArray);
-        return response()->json($taskArray);
+        $taskArray = JobPosterKeyTask::where ('job_poster_id', $jobPoster->id)->get ()->map ($toApiArray);
+        return response ()->json ($taskArray);
     }
 
     /**
@@ -38,35 +38,35 @@ 
     {
         $toApiArray = array($this, 'toApiArray');
 
-        $newTasks = collect($request->validated()); // Collection of JobPosterKeyTasks.
+        $newTasks = collect ($request->validated ()); // Collection of JobPosterKeyTasks.
         $oldTasks = $jobPoster->job_poster_key_tasks;
 
         $savedNewTaskIds = [];
 
         // First, delete old tasks that weren't resubmitted, and update those that were.
         foreach ($oldTasks as $task) {
-            $newTask = $newTasks->firstWhere('id', $task['id']);
+            $newTask = $newTasks->firstWhere ('id', $task['id']);
             if ($newTask) {
                 $savedNewTaskIds[] = $newTask['id'];
-                $task->fill(collect($newTask)->only(['en', 'fr'])->toArray());
-                $task->save();
+                $task->fill (collect ($newTask)->only (['en', 'fr'])->toArray ());
+                $task->save ();
             } else {
-                $task->delete();
+                $task->delete ();
             }
         }
 
         // Now, save any new tasks that remain.
         foreach ($newTasks as $task) {
-            if ($this->isUnsaved($task, $savedNewTaskIds)) {
-                $jobPosterTask = new JobPosterKeyTask();
+            if ($this->isUnsaved ($task, $savedNewTaskIds)) {
+                $jobPosterTask = new JobPosterKeyTask ();
                 $jobPosterTask->job_poster_id = $jobPoster->id;
-                $jobPosterTask->fill(collect($task)->only(['en', 'fr'])->toArray());
-                $jobPosterTask->save();
+                $jobPosterTask->fill (collect ($task)->only (['en', 'fr'])->toArray ());
+                $jobPosterTask->save ();
             }
         }
 
-        $taskArray = $jobPoster->fresh()->job_poster_key_tasks->map($toApiArray);
-        return response()->json($taskArray);
+        $taskArray = $jobPoster->fresh ()->job_poster_key_tasks->map ($toApiArray);
+        return response ()->json ($taskArray);
     }
 
     /**
@@ -78,6 +78,6 @@ 
      */
     private function isUnsaved($task, array $savedTaskIds): bool
     {
-        return !array_key_exists('id', $task) || !in_array($task['id'], $savedTaskIds);
+        return !array_key_exists ('id', $task) || !in_array ($task['id'], $savedTaskIds);
     }
 }

app/Http/Controllers/Api/ClaimJobApiController.php

Spacing +6 added lines, -6 removed lines

@@ -27,9 +27,9 @@ 
      */
     public function store(Request $request, JobPoster $job)
     {
-        $this->claimJob($request->user()->hr_advisor, $job);
+        $this->claimJob ($request->user ()->hr_advisor, $job);
 
-        return response()->json(['status' => 'ok']);
+        return response ()->json (['status' => 'ok']);
     }
 
     /**
@@ -62,9 +62,9 @@ 
      */
     public function destroy(Request $request, JobPoster $job)
     {
-        $this->unclaimJob($request->user()->hr_advisor, $job);
+        $this->unclaimJob ($request->user ()->hr_advisor, $job);
 
-        return response()->json(['status' => 'ok']);
+        return response ()->json (['status' => 'ok']);
     }
 
     /**
@@ -76,7 +76,7 @@ 
      */
     public function claimJob(HrAdvisor $hrAdvisor, JobPoster $job)
     {
-        $hrAdvisor->claimed_jobs()->attach($job);
+        $hrAdvisor->claimed_jobs ()->attach ($job);
     }
 
     /**
@@ -88,6 +88,6 @@ 
      */
     public function unclaimJob(HrAdvisor $hrAdvisor, JobPoster $job)
     {
-        $hrAdvisor->claimed_jobs()->detach($job);
+        $hrAdvisor->claimed_jobs ()->detach ($job);
     }
 }

app/Http/Controllers/Api/CriteriaController.php

Spacing +29 added lines, -29 removed lines

@@ -19,7 +19,7 @@ 
      */
     public function toApiArray(Criteria $model)
     {
-        return array_merge($model->toArray(), $model->getTranslationsArray());
+        return array_merge ($model->toArray (), $model->getTranslationsArray ());
     }
 
     /**
@@ -31,8 +31,8 @@ 
     public function indexByJob(JobPoster $jobPoster)
     {
         $toApiArray = array($this, 'toApiArray');
-        $criteriaAray = Criteria::where('job_poster_id', $jobPoster->id)->get()->map($toApiArray);
-        return response()->json($criteriaAray);
+        $criteriaAray = Criteria::where ('job_poster_id', $jobPoster->id)->get ()->map ($toApiArray);
+        return response ()->json ($criteriaAray);
     }
 
     /**
@@ -46,39 +46,39 @@ 
     {
         $toApiArray = array($this, 'toApiArray');
 
-        $newCriteria = collect($request->input()); // TODO: switch to validated
+        $newCriteria = collect ($request->input ()); // TODO: switch to validated
         $oldCriteria = $jobPoster->criteria;
 
         $updatedIds = [];
 
         // First, delete old criteria that weren't resubmitted, and update those that were
         foreach ($oldCriteria as $criteria) {
-            $newData = $newCriteria->firstWhere('id', $criteria['id']);
+            $newData = $newCriteria->firstWhere ('id', $criteria['id']);
             if ($newData) {
                 $updatedIds[] = $criteria->id;
-                $this->updateCriteria($criteria, $newData);
+                $this->updateCriteria ($criteria, $newData);
             } else {
-                $this->deleteCriteria($criteria);
+                $this->deleteCriteria ($criteria);
             }
         }
 
         $isUnsaved = function ($criteria, $savedIds): bool {
-            return !array_key_exists('id', $criteria) || !in_array($criteria['id'], $savedIds);
+            return !array_key_exists ('id', $criteria) || !in_array ($criteria['id'], $savedIds);
         };
 
         // Now, save any new criteria that remain
         foreach ($newCriteria as $criteriaData) {
-            if ($isUnsaved($criteriaData, $updatedIds)) {
-                $criteria = new Criteria();
+            if ($isUnsaved ($criteriaData, $updatedIds)) {
+                $criteria = new Criteria ();
                 $criteria->job_poster_id = $jobPoster->id;
-                $fillableData = collect($criteriaData)->except(['id', 'job_poster_id'])->toArray();
-                $criteria->fill($fillableData);
-                $this->createCriteria($criteria);
+                $fillableData = collect ($criteriaData)->except (['id', 'job_poster_id'])->toArray ();
+                $criteria->fill ($fillableData);
+                $this->createCriteria ($criteria);
             }
         }
 
-        $criteriaAray = Criteria::where('job_poster_id', $jobPoster->id)->get()->map($toApiArray);
-        return response()->json($criteriaAray);
+        $criteriaAray = Criteria::where ('job_poster_id', $jobPoster->id)->get ()->map ($toApiArray);
+        return response ()->json ($criteriaAray);
     }
 
     /**
@@ -89,13 +89,13 @@ 
      */
     protected function createCriteria(Criteria $criteria)
     {
-        $criteria->save();
+        $criteria->save ();
 
-        $notification = $this->makeAssessmentPlanNotification(
+        $notification = $this->makeAssessmentPlanNotification (
             'CREATE',
             $criteria
         );
-        $notification->save();
+        $notification->save ();
 
         return $criteria;
     }
@@ -113,19 +113,19 @@ 
         if ($oldCriteria->skill_level_id != $newData['skill_level_id']
             || $oldCriteria->skill_id != $newData['skill_id']
         ) {
-            $notification = $this->makeAssessmentPlanNotification(
+            $notification = $this->makeAssessmentPlanNotification (
                 'UPDATE',
                 $oldCriteria,
                 $newData['skill_id'],
                 $newData['skill_level_id'],
                 $newData['criteria_type_id']
             );
-            $notification->save();
+            $notification->save ();
         }
         // Get just the data that can be changed
-        $fillableData = collect($newData)->except(['id', 'job_poster_id'])->toArray();
-        $oldCriteria->fill($fillableData);
-        $oldCriteria->save();
+        $fillableData = collect ($newData)->except (['id', 'job_poster_id'])->toArray ();
+        $oldCriteria->fill ($fillableData);
+        $oldCriteria->save ();
     }
 
     /**
@@ -136,15 +136,15 @@ 
      */
     protected function deleteCriteria(Criteria $criteria): void
     {
-        $notification = $notification = $this->makeAssessmentPlanNotification(
+        $notification = $notification = $this->makeAssessmentPlanNotification (
             'DELETE',
             $criteria
         );
-        $notification->save();
+        $notification->save ();
 
         // Delete assessments related to this criteria.
-        Assessment::where('criterion_id', $criteria->id)->delete();
-        $criteria->delete();
+        Assessment::where ('criterion_id', $criteria->id)->delete ();
+        $criteria->delete ();
     }
 
     /**
@@ -163,8 +163,8 @@ 
         $newSkillId = null,
         $newSkillLevelId = null,
         $newCriteriaTypeId = null
-    ) {
-        $notification = new AssessmentPlanNotification();
+    ){
+        $notification = new AssessmentPlanNotification ();
         $notification->job_poster_id = $criteria->job_poster_id;
         $notification->type = $type;
         $notification->criteria_id = $criteria->id;

app/Http/Controllers/Api/HrAdvisorController.php

Spacing +1 added lines, -1 removed lines

@@ -15,6 +15,6 @@
      */
     public function show(HrAdvisor $hrAdvisor)
     {
-        return response()->json($hrAdvisor->toArray());
+        return response ()->json ($hrAdvisor->toArray ());
     }
 }

app/Http/Requests/BatchUpdateCriteria.php

Spacing +3 added lines, -3 removed lines

@@ -29,9 +29,9 @@
     {
         return [
             '*.id' => 'present',
-            '*.criteria_type_id' => ['required', new ValidIdRule(CriteriaType::class)],
-            '*.skill_id' => ['required', new ValidIdRule(Skill::class)],
-            '*.skill_level_id' => ['required', new ValidIdRule(SkillLevel::class)],
+            '*.criteria_type_id' => ['required', new ValidIdRule (CriteriaType::class)],
+            '*.skill_id' => ['required', new ValidIdRule (Skill::class)],
+            '*.skill_level_id' => ['required', new ValidIdRule (SkillLevel::class)],
             '*.en.description' => 'nullable|string',
             '*.en.specificity' => 'nullable|string',
             '*.fr.description' => 'nullable|string',