RatingGuideQuestionRule::message() - Code Metrics - Inspection of "Stop repeated store requests for questions and ans..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — task/screening-plan-performanc... ( 402c06...124a4a )

by Tristan

created 2019-05-24 22:04 UTC

RatingGuideQuestionRule::message() A

↳ Parent: RatingGuideQuestionRule

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
ccs	0
cts	2
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php

namespace App\Services\Validation\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Facades\Lang;
use App\Models\RatingGuideQuestion;

/**
 * Validates that value is a valid RatingGuideQuestion id
 */
class RatingGuideQuestionRule implements Rule
{
    public function passes($attribute, $value)

    {
        return RatingGuideQuestion::where('id', $value)->exists();

    }
    public function message()

    {
        return Lang::get('validation.invalid_id');
    }
}


1			<?php
2
3			namespace App\Services\Validation\Rules;
4
5			use Illuminate\Contracts\Validation\Rule;
6			use Illuminate\Support\Facades\Lang;
7			use App\Models\RatingGuideQuestion;
8
9			/**
10			* Validates that value is a valid RatingGuideQuestion id
11			*/
12			class RatingGuideQuestionRule implements Rule
13			{
14			public function passes($attribute, $value)
			1 ignored issue – show introduced 2019-05-24 22:18 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\RatingGuideQuestionRule::passes() does not have parameter type hint nor @param annotation for its parameter $attribute. Loading history... introduced 2019-05-24 22:18 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\RatingGuideQuestionRule::passes() does not have parameter type hint nor @param annotation for its parameter $value. Loading history... introduced 2019-05-24 22:18 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\RatingGuideQuestionRule::passes() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report Missing doc comment for function passes() Loading history...
15			{
16			return RatingGuideQuestion::where('id', $value)->exists();
			0 ignored issues – show Bug Best Practice introduced 2019-05-24 22:18 UTC by Report Bug Copy Issue Report The expression `return App\Models\Rating...'id', $value)->exists()` also could return the type `Illuminate\Database\Eloquent\Builder` which is incompatible with the return type mandated by `Illuminate\Contracts\Validation\Rule::passes()` of `boolean`. Loading history...
17			}
18			public function message()
			1 ignored issue – show introduced 2019-05-24 22:18 UTC by Report Bug Copy Issue Report Method \App\Services\Validation\Rules\RatingGuideQuestionRule::message() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-05-15 19:49 UTC by Report Bug Copy Issue Report Missing doc comment for function message() Loading history...
19			{
20			return Lang::get('validation.invalid_id');
21			}
22			}
23

GCTC-NTGC / TalentCloud

Push — task/screening-plan-performanc... ( 402c06...124a4a )

RatingGuideQuestionRule::message() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like