UpdateRatingGuideAnswer::rules() - Code Metrics - Inspection of "Stop repeated store requests for questions and ans..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — task/screening-plan-performanc... ( 402c06...124a4a )

by Tristan

created 2019-05-24 22:04 UTC

UpdateRatingGuideAnswer::rules() A

↳ Parent: UpdateRatingGuideAnswer

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	3
dl	0
loc	7
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php

namespace App\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;
use App\Services\Validation\Rules\RatingGuideQuestionRule;
use App\Services\Validation\Rules\CriterionRule;
use App\Models\RatingGuideAnswer;

class UpdateRatingGuideAnswer extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool

     */
    public function authorize()

    {
        // originalParameter avoids type hinting that automagically transforms the id into the RatingGuideAnswer object
        //$answer = RatingGuideAnswer::find($this->route()->originalParameter('ratingGuideAnswer'));

        // The id parameter in the route is typehinted to magically become a RatingGuideAnswer object.
        $answer = $this->route('ratingGuideAnswer');
        return $answer && $this->user()->can('update', $answer);
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array

     */
    public function rules()

    {
        return [
            // RatingGuideQUestionId shouldn't be updated after creation
            //'rating_guide_question_id' => ['required', new RatingGuideQuestionRule()],
            'criterion_id' => ['nullable', new CriterionRule()],
            'expected_answer' => 'nullable|string',
        ];
    }
}


1			<?php
2
3			namespace App\Http\Requests;
4
5			use Illuminate\Foundation\Http\FormRequest;
6			use App\Services\Validation\Rules\RatingGuideQuestionRule;
7			use App\Services\Validation\Rules\CriterionRule;
8			use App\Models\RatingGuideAnswer;
9
10			class UpdateRatingGuideAnswer extends FormRequest
11			{
12			/**
13			* Determine if the user is authorized to make this request.
14			*
15			* @return bool
			1 ignored issue – show Coding Style introduced 2019-05-17 21:11 UTC by Report Bug Copy Issue Report Expected "boolean" but found "bool" for function return type Loading history...
16			*/
17			public function authorize()
			0 ignored issues – show introduced 2019-05-24 22:18 UTC by Report Bug Copy Issue Report Method \App\Http\Requests\UpdateRatingGuideAnswer::authorize() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool". Loading history...
18			{
19			// originalParameter avoids type hinting that automagically transforms the id into the RatingGuideAnswer object
20			//$answer = RatingGuideAnswer::find($this->route()->originalParameter('ratingGuideAnswer'));
21
22			// The id parameter in the route is typehinted to magically become a RatingGuideAnswer object.
23			$answer = $this->route('ratingGuideAnswer');
24			return $answer && $this->user()->can('update', $answer);
25			}
26
27			/**
28			* Get the validation rules that apply to the request.
29			*
30			* @return array
			0 ignored issues – show introduced 2019-05-24 22:18 UTC by Report Bug Copy Issue Report @return annotation of method \App\Http\Requests\UpdateRatingGuideAnswer::rules() does not specify type hint for items of its traversable return value. Loading history...
31			*/
32			public function rules()
			0 ignored issues – show introduced 2019-05-24 22:18 UTC by Report Bug Copy Issue Report Method \App\Http\Requests\UpdateRatingGuideAnswer::rules() does not have return type hint for its return value but it should be possible to add it based on @return annotation "array". Loading history...
33			{
34			return [
35			// RatingGuideQUestionId shouldn't be updated after creation
36			//'rating_guide_question_id' => ['required', new RatingGuideQuestionRule()],
37			'criterion_id' => ['nullable', new CriterionRule()],
38			'expected_answer' => 'nullable\|string',
39			];
40			}
41			}
42

GCTC-NTGC / TalentCloud

Push — task/screening-plan-performanc... ( 402c06...124a4a )

UpdateRatingGuideAnswer::rules() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like