BatchUpdateCriteria::authorize() - Code Metrics - Inspection of "Add test for CriteriaController generating notific..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/job-builder/criteria-a... ( a8d7d9 )

by Tristan

created 2019-07-20 20:35 UTC

BatchUpdateCriteria::authorize() A

↳ Parent: BatchUpdateCriteria

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	1
c	1
b	0
f	0
dl	0
loc	3
ccs	0
cts	2
cp	0
rs	10
cc	1
nc	1
nop	0
crap	2

<?php

namespace App\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;
use App\Services\Validation\Rules\ValidIdRule;
use App\Models\Lookup\CriteriaType;
use App\Models\Skill;
use App\Models\Lookup\SkillLevel;

class BatchUpdateCriteria extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return boolean
     */
    public function authorize(): bool
    {
        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return string[]
     */
    public function rules(): array
    {
        return [

            '*.id' => 'present',
            '*.criteria_type_id' => ['required', new ValidIdRule(CriteriaType::class)],
            '*.skill_id' => ['required', new ValidIdRule(Skill::class)],
            '*.skill_level_id' => ['required', new ValidIdRule(SkillLevel::class)],
            '*.en.description' => 'nullable|string',
            '*.en.specificity' => 'nullable|string',
            '*.fr.description' => 'nullable|string',
            '*.fr.specificity' => 'nullable|string',
        ];
    }
}


1			<?php
2
3			namespace App\Http\Requests;
4
5			use Illuminate\Foundation\Http\FormRequest;
6			use App\Services\Validation\Rules\ValidIdRule;
7			use App\Models\Lookup\CriteriaType;
8			use App\Models\Skill;
9			use App\Models\Lookup\SkillLevel;
10
11			class BatchUpdateCriteria extends FormRequest
12			{
13			/**
14			* Determine if the user is authorized to make this request.
15			*
16			* @return boolean
17			*/
18			public function authorize(): bool
19			{
20			return true;
21			}
22
23			/**
24			* Get the validation rules that apply to the request.
25			*
26			* @return string[]
27			*/
28			public function rules(): array
29			{
30			return [
			0 ignored issues – show Bug Best Practice introduced 2019-07-20 20:50 UTC by Report Bug Copy Issue Report The expression `return array('*.id' => '...' => 'nullable\|string')` returns an array which contains values of type `array<integer,App\Servic...les\ValidIdRule\|string>` which are incompatible with the documented value type `string`. Loading history...
31			'*.id' => 'present',
32			'*.criteria_type_id' => ['required', new ValidIdRule(CriteriaType::class)],
33			'*.skill_id' => ['required', new ValidIdRule(Skill::class)],
34			'*.skill_level_id' => ['required', new ValidIdRule(SkillLevel::class)],
35			'*.en.description' => 'nullable\|string',
36			'*.en.specificity' => 'nullable\|string',
37			'*.fr.description' => 'nullable\|string',
38			'*.fr.specificity' => 'nullable\|string',
39			];
40			}
41			}
42

GCTC-NTGC / TalentCloud

Push — feature/job-builder/criteria-a... ( a8d7d9 )

BatchUpdateCriteria::authorize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like