WhichPortal::isManagerPortal() - Code Metrics - Inspection of "Fix bug in WhichPortal, and add regression tests" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — bugfix/which-portal ( 090ab7 )

by Tristan

created 2019-07-03 14:59 UTC

WhichPortal::isManagerPortal() A

↳ Parent: WhichPortal

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
eloc	2
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

namespace App\Services;

use Illuminate\Support\Facades\Route;
use Illuminate\Support\Facades\URL;

class WhichPortal
{

    public function isApplicantPortal()

    {
        return !$this->isManagerPortal();
    }

    public function isManagerPortal()

    {
        $url = URL::current();
        return $this->urlIsManagerPortal($url);
    }

    public function urlIsManagerPortal($url): bool

    {
        $baseUrl = config('app.url');
        $managerPrefix = config('app.manager_prefix');
        $managerPattern = "#^$baseUrl/(\w+/)?$managerPrefix(/.*)?$#";
        return preg_match($managerPattern, $url);

    }
}


1		<?php
2
3		namespace App\Services;
4
5		use Illuminate\Support\Facades\Route;
6		use Illuminate\Support\Facades\URL;
7
8		class WhichPortal
9		{
10
11	25	public function isApplicantPortal()
		1 ignored issue – show introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Services\WhichPortal::isApplicantPortal() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing doc comment for function isApplicantPortal() Loading history...
12		{
13	25	return !$this->isManagerPortal();
14		}
15
16	30	public function isManagerPortal()
		1 ignored issue – show introduced 2019-06-27 13:35 UTC by Report Bug Copy Issue Report Method \App\Services\WhichPortal::isManagerPortal() does not have return type hint nor @return annotation for its return value. Loading history... Coding Style Documentation introduced 2019-06-27 13:35 UTC by Report Bug Copy Issue Report Missing doc comment for function isManagerPortal() Loading history...
17		{
18	30	$url = URL::current();
19	30	return $this->urlIsManagerPortal($url);
20		}
21
22	32	public function urlIsManagerPortal($url): bool
		1 ignored issue – show introduced 2019-07-03 15:34 UTC by Report Bug Copy Issue Report Method \App\Services\WhichPortal::urlIsManagerPortal() does not have parameter type hint nor @param annotation for its parameter $url. Loading history... Coding Style Documentation introduced 2019-07-03 15:34 UTC by Report Bug Copy Issue Report Missing doc comment for function urlIsManagerPortal() Loading history...
23		{
24	32	$baseUrl = config('app.url');
25	32	$managerPrefix = config('app.manager_prefix');
26	32	$managerPattern = "#^$baseUrl/(\w+/)?$managerPrefix(/.*)?$#";
27	32	return preg_match($managerPattern, $url);
		0 ignored issues – show Bug Best Practice introduced 2019-07-03 15:34 UTC by Report Bug Copy Issue Report The expression `return preg_match($managerPattern, $url)` returns the type `integer` which is incompatible with the type-hinted return `boolean`. Loading history...
28		}
29		}
30

GCTC-NTGC / TalentCloud

Push — bugfix/which-portal ( 090ab7 )

WhichPortal::isManagerPortal() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like