App\Http\Controllers\ScreeningPlanController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	94
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	destroy()	0	11	2
A	store()	0	24	4
A	createForJob()	0	28	5

<?php

Missing file doc comment

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Models\JobPoster;
use Illuminate\Support\Facades\Lang;
use Illuminate\View\View;
use App\Models\Skill;
use App\Models\Lookup\SkillLevel;
use App\Models\Lookup\AssessmentType;
use App\Models\ScreeningPlan;
use App\Models\Assessment;

class ScreeningPlanController extends Controller

Missing doc comment for class ScreeningPlanController

{
    /**
     * Show the form for creating a new resource.
     *
     * @param JobPoster $jobPoster The job to create a screening plan for.
     *
     * @return View|\Illuminate\Contracts\View\Factory
     */
    public function createForJob(JobPoster $jobPoster)
    {
        $jobPoster->load('criteria');
        $skills = Skill::all();

The assignment to $skills is dead and can be removed.

        $assessment_plans = [];
        foreach ($jobPoster->screening_plans as $plan) {
            $assessment_plan = [];
            foreach (AssessmentType::all() as $type) {
                $plan_type_assessments = $plan->assessments->where('assessment_type_id', $type->id);
                if (!$plan_type_assessments->isEmpty()) {
                    $assessment_plan[$type->name] = [];

The property name does not seem to exist on App\Models\Lookup\AssessmentType. Are you sure there is no database migration missing?

                    foreach ($plan_type_assessments as $assessment) {
                        $assessment_plan[$type->name][] = $assessment->criterion->skill->skill;
                    }
                }
            }
            $assessment_plans[$plan->id] = $assessment_plan;
        }

        return view(
            'manager/screening-plan',
            [
                'screening' => Lang::get('manager/screening-plan'),
                'job' => $jobPoster,
                'skill_template' => Lang::get('common/skills'),
                'assessment_types' => AssessmentType::all(),
                'assessment_plans' => $assessment_plans,
            ]
        );
    }

    /**
     * Save the screening plan.
     *
     * @param Request   $request   The incoming request object.
     * @param JobPoster $jobPoster The job to create a screen plan for.
     *
     * @return \Illuminate\Routing\Redirector|Illuminate\Http\RedirectResponse

The type App\Http\Controllers\Illuminate\Http\RedirectResponse was not found. Did you mean Illuminate\Http\RedirectResponse? If so, make sure to prefix the type with \.

     */
    public function store(Request $request, JobPoster $jobPoster)
    {
        //TODO: Validate every job criteria is represented
        //TODO: Validate every job criteria has at least one assessment (?)
        //TODO: Validate every assessment is correct and complete

        $plan = new ScreeningPlan();
        $plan->job_poster_id = $jobPoster->id;
        $plan->version = ScreeningPlan::max('version') + 1;
        $plan->save();

        if ($request->input('criteria')) {
            foreach ($request->input('criteria') as $criteriaId => $assessments) {
                foreach ($assessments['assessment'] as $assessmentData) {
                    $assessment = new Assessment();
                    $assessment->screening_plan_id = $plan->id;
                    $assessment->criterion_id = $criteriaId;
                    $assessment->assessment_type_id = $assessmentData['assessment_type'];
                    $assessment->save();
                }
            }
        }

        return redirect(route('manager.jobs.screening_plan', $jobPoster));

The expression return redirect(route('manager.jobs.screening_plan', $jobPoster)) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Illuminate\Http\RedirectResponse|Illuminate\Routing\Redirector.

    }

    /**
     * Delete the particular skill declaration in storage.
     *
     * @param \Illuminate\Http\Request  $request       The request object.
     * @param \App\Models\ScreeningPlan $screeningPlan The screening plan to delete.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy(Request $request, ScreeningPlan $screeningPlan) // phpcs:ignore
    {
        $this->authorize('delete', $screeningPlan);
        $screeningPlan->delete();

        if ($request->ajax()) {
            $content = ['message' => 'Screening Plan deleted'];
            return $this->formatAjaxResponse($content);

The expression return $this->formatAjaxResponse($content) returns the type Illuminate\Http\Response which is incompatible with the documented return type Illuminate\Http\RedirectResponse.

        }

        return redirect()->back();
    }
}