App\Http\Middleware\InitializeUser::handle()

Complexity

Conditions	13
Paths	55

Size

Total Lines	48
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function handle($request, Closure $next)

Type hint "\Illuminate\Http\Request" missing for $request

    {
        if (Auth::check()) {
            $user = Auth::user();

            // If running in a local environment, and FORCE_ADMIN is true,
            // automatically set any logged in user to (temporarilly) be an admin
            if (App::environment() == 'local' && Config::get('app.force_admin')) {
                $user->setRole('admin');
                $user->save();
            }

            // Ensure the user has a proper profile associated with it
            // If no profile exists yet create one.
            // Admins should be given an applicant and manager profile
            if ($user->isApplicant() ||
                    $user->isAdmin() ) {

Expected 0 spaces before closing bracket; 1 found

                $applicantProfile = $user->applicant;

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                if ($applicantProfile === null) {
                    $applicantProfile = new Applicant();
                    $applicantProfile->user_id = $user->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                    $applicantProfile->save();
                    $user->refresh();
                }
            }
            if ($user->isManager() ||
                    $user->isAdmin()) {
                $managerProfile = $user->manager;

Accessing manager on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                if ($managerProfile === null) {
                    $managerProfile = new Manager();
                    $managerProfile->user_id = $user->id;
                    $managerProfile->save();
                    $user->refresh();
                }
            }
            if ($user->isHrAdvisor() ||
                    $user->isAdmin()) {
                $hrAdvisorProfile = $user->hr_advisor;

Accessing hr_advisor on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                if ($hrAdvisorProfile === null) {
                    $hrAdvisorProfile = new HrAdvisor();
                    $hrAdvisorProfile->user_id = $user->id;
                    $hrAdvisorProfile->save();
                    $user->refresh();
                }
            }
        }

        return $next($request);
    }