ApplicantProfileMenuComposer::compose() - Code Metrics - Inspection of "Improve Laravel boot time" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — dev (#832)

by Tristan

created 2019-03-28 21:03 UTC

ApplicantProfileMenuComposer::compose() C

↳ Parent: ApplicantProfileMenuComposer

Complexity

Conditions	13
Paths	13

Size

Total Lines	40
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	21
CRAP Score	19.8615

Importance

Changes

Metric	Value
eloc	32
dl	0
loc	40
ccs	21
cts	32
cp	0.6563
rs	6.6166
c	0
b	0
f	0
cc	13
nc	13
nop	1
crap	19.8615

How to fix Complexity

<?php

namespace App\Http\ViewComposers;

use Illuminate\View\View;
use Illuminate\Support\Facades\Lang;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Route;

class ApplicantProfileMenuComposer
{
    /**
     * Bind data to the view.
     *
     * @param  View  $view

     * @return void
     */
    public function compose(View $view)

    {
        $profileMenu = Lang::get('applicant/applicant_profile_menu');

        $profileMenu['about']['link'] = route('profile.about.edit', $view->getData()['applicant']);
        $profileMenu['experience']['link'] = route('profile.experience.edit', $view->getData()['applicant']);
        $profileMenu['skills']['link'] = route('profile.skills.edit', $view->getData()['applicant']);
        $profileMenu['references']['link'] = route('profile.references.edit', $view->getData()['applicant']);
        $profileMenu['portfolio']['link'] = route('profile.work_samples.edit', $view->getData()['applicant']);

        //Set active on the proper item
        switch(Route::currentRouteName()) {

            case('profile.about'):
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
            case('profile.about.edit'):
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
            case('profile.about.update'):
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                $profileMenu['about']['active'] = true;
                break;
            case('profile.experience'):
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
            case('profile.experience.edit'):
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
            case('profile.experience.update'):
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                $profileMenu['experience']['active'] = true;
                break;
            case('profile.skills'):
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
            case('profile.skills.edit'):
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                $profileMenu['skills']['active'] = true;
                break;
            case('profile.references'):
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
            case('profile.references.edit'):
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                $profileMenu['references']['active'] = true;
                break;
            case('profile.portfolio'):
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
            case('profile.work_samples.edit'):
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                $profileMenu['portfolio']['active'] = true;
                break;
            default:
                //No active menu item
                break;
        }

        $view->with('profile_menu', $profileMenu);
    }
}


1		<?php
2
3		namespace App\Http\ViewComposers;
4
5		use Illuminate\View\View;
6		use Illuminate\Support\Facades\Lang;
7		use Illuminate\Support\Facades\Auth;
8		use Illuminate\Support\Facades\Route;
9
10		class ApplicantProfileMenuComposer
11		{
12		/**
13		* Bind data to the view.
14		*
15		* @param View $view
		2 ignored issues – show Coding Style Documentation introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Missing parameter comment Loading history... Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Expected 1 spaces after parameter type; 2 found Loading history...
16		* @return void
17		*/
18	1	public function compose(View $view)
		0 ignored issues – show introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Method \App\Http\ViewComposers\ApplicantProfileMenuComposer::compose() does not have return type hint for its return value but it should be possible to add it based on @return annotation "void". Loading history...
19		{
20	1	$profileMenu = Lang::get('applicant/applicant_profile_menu');
21
22	1	$profileMenu['about']['link'] = route('profile.about.edit', $view->getData()['applicant']);
23	1	$profileMenu['experience']['link'] = route('profile.experience.edit', $view->getData()['applicant']);
24	1	$profileMenu['skills']['link'] = route('profile.skills.edit', $view->getData()['applicant']);
25	1	$profileMenu['references']['link'] = route('profile.references.edit', $view->getData()['applicant']);
26	1	$profileMenu['portfolio']['link'] = route('profile.work_samples.edit', $view->getData()['applicant']);
27
28		//Set active on the proper item
29	1	switch(Route::currentRouteName()) {
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report Expected 1 space(s) after SWITCH keyword; 0 found Loading history...
30	1	case('profile.about'):
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
31	1	case('profile.about.edit'):
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
32	1	case('profile.about.update'):
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
33		$profileMenu['about']['active'] = true;
34		break;
35	1	case('profile.experience'):
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
36	1	case('profile.experience.edit'):
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
37	1	case('profile.experience.update'):
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
38		$profileMenu['experience']['active'] = true;
39		break;
40	1	case('profile.skills'):
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
41	1	case('profile.skills.edit'):
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
42		$profileMenu['skills']['active'] = true;
43		break;
44	1	case('profile.references'):
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
45	1	case('profile.references.edit'):
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
46	1	$profileMenu['references']['active'] = true;
47	1	break;
48		case('profile.portfolio'):
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
49		case('profile.work_samples.edit'):
		0 ignored issues – show Coding Style introduced 2019-03-09 13:58 UTC by Report Bug Copy Issue Report As per coding-style, `case` should be followed by a single space. As per the PSR-2 coding standard, there must be a space after the `case` keyword, instead of the test immediately following it. switch (true) { case!isset($a): //wrong doSomething(); break; case !isset($b): //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
50		$profileMenu['portfolio']['active'] = true;
51		break;
52		default:
53		//No active menu item
54		break;
55		}
56
57	1	$view->with('profile_menu', $profileMenu);
58	1	}
59		}
60

GCTC-NTGC / TalentCloud

Pull Request — dev (#832)

ApplicantProfileMenuComposer::compose() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like