App\Http\Controllers\WorkSamplesController::update()

Complexity

Conditions	11
Paths	12

Size

Total Lines	62
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	132

Importance

Changes

0

<?php
    public function update(Request $request, Applicant $applicant)
    {

        $input = $request->input();

        $workSamples = $input['work_samples'];

        //Delete old workSamples that weren't resubmitted
        //Note: this must be done before adding new workSamples, so we don't delete
        // them right after adding them
        foreach($applicant->work_samples as $oldWorkSample) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

            //Check if no workSamples were resubmitted, or if this specific one wasn't
            if (!isset($workSamples['old']) ||
                !isset($workSamples['old'][$oldWorkSample->id])) {

Each line in a multi-line IF statement must begin with a boolean operator

Closing parenthesis of a multi-line IF statement must be on a new line

                $oldWorkSample->delete();
            }
        }

        //Save new workSamples
        if (isset($workSamples['new'])) {
            foreach($workSamples['new'] as $workSampleInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                $workSample = new WorkSample();
                $workSample->applicant_id = $applicant->id;
                $workSample->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                    'name' => $workSampleInput['name'],
                    'date_created' => isset($workSampleInput['date_created']) ? $workSampleInput['date_created'] : null,
                    'file_type_id' => $workSampleInput['file_type_id'],
                    'url' => $workSampleInput['url'],
                    'description' => $workSampleInput['description'],
                ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                $workSample->save();

                $skillDeclarationIds =$this->getRelativeIds($workSampleInput, 'skills');
                $workSample->skill_declarations()->sync($skillDeclarationIds);
            }
        }

        //Update old workSamples
        if (isset($workSamples['old'])) {
            foreach($workSamples['old'] as $id=>$workSampleInput) {

Expected "foreach (...) {\n"; found "foreach(...) {\n"

                //Ensure this workSample belongs to this applicant
                $workSample = $applicant->work_samples->firstWhere('id', $id);
                if ($workSample != null) {
                    $workSample->fill([

The opening parenthesis of a multi-line function call should be the last content on the line.

                        'name' => $workSampleInput['name'],
                        'date_created' => isset($workSampleInput['date_created']) ? $workSampleInput['date_created'] : null,
                        'file_type_id' => $workSampleInput['file_type_id'],
                        'url' => $workSampleInput['url'],
                        'description' => $workSampleInput['description'],
                    ]);

For multi-line function calls, the closing parenthesis should be on a new line.

                    $workSample->save();

                    $skillDeclarationIds =$this->getRelativeIds($workSampleInput, 'skills');
                    $workSample->skill_declarations()->sync($skillDeclarationIds);
                } else {
                    Debugbar::warning('Applicant '.$applicant->id.' attempted to update workSample with invalid id '.$id);
                }
            }
        }

        return redirect( route('profile.work_samples.edit', $applicant) );

The expression return redirect(route('profile.work_samples.edit', $applicant)) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

$applicant of type App\Models\Applicant is incompatible with the type array expected by parameter $parameters of route().

    }