App\Utilities\HandleOutput

Complexity

Total Complexity

3

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Test Coverage

Coverage

83.33%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	handleOutput()	0	5	2
A	getFunctions()	0	3	1

<?php namespace App\Utilities;

use Twig_Extension;
use Twig_SimpleFunction;
use Twig_SimpleFilter;

class HandleOutput extends Twig_Extension {
    /**
     * Functions
     * @return void

Function return type is void, but function contains return statement

     */
    public function getFunctions() {

Method \App\Utilities\HandleOutput::getFunctions() does not have return type hint for its return value but it should be possible to add it based on @return annotation "void".

      return [

The expression return array(new Twig_SimpleFunction('handleOutput', array($this, 'handleOutput'))) returns the type array<integer,Twig_SimpleFunction> which is incompatible with the documented return type void.

        new Twig_SimpleFunction('handleOutput', [$this, 'handleOutput']),
      ];
    }

    public function handleOutput($output, $outputHtml, $nullHtml) {

Method \App\Utilities\HandleOutput::handleOutput() does not have parameter type hint nor @param annotation for its parameter $output.

Method \App\Utilities\HandleOutput::handleOutput() does not have parameter type hint nor @param annotation for its parameter $outputHtml.

Method \App\Utilities\HandleOutput::handleOutput() does not have parameter type hint nor @param annotation for its parameter $nullHtml.

Method \App\Utilities\HandleOutput::handleOutput() does not have void return type hint.

Missing doc comment for function handleOutput()

        if( !empty($output) ) {

Expected 1 space(s) after IF keyword; 0 found

Expected 0 spaces before closing bracket; 1 found

          echo $outputHtml;
        } else {
          echo $nullHtml;
        }
    }
}
?>

It is not recommended to use PHP's closing tag ?> in files other than templates.