App\Http\Middleware\InitializeUser::handle()

Complexity

Conditions	10
Paths	19

Size

Total Lines	38
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	10.2537

Importance

Changes

0

<?php
    public function handle($request, Closure $next)

Method \App\Http\Middleware\InitializeUser::handle() does not have parameter type hint for its parameter $request but it should be possible to add it based on @param annotation "\Illuminate\Http\Request".

Type hint "\Illuminate\Http\Request" missing for $request

    {
        if (Auth::check()) {
            $user = Auth::user();

            //If running in a local environment, and FORCE_ADMIN is true,
            //automatically set any logged in user to (temporarilly) be an admin
            if (App::environment() == 'local' && Config::get('app.force_admin')) {
                $adminRole = UserRole::where('name', 'admin')->firstOrFail();
                $user->user_role_id = $adminRole->id;

Accessing user_role_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                // $user->user_role = $adminRole;
                $user->save();
            }

            //Ensure the user has a proper profile associated with it
            //If no profile exists yet create one.
            //Admins should be given an applicant and manager profile
            if ($user->hasRole('applicant') ||
                    $user->hasRole('admin') ) {
                $applicantProfile = $user->applicant;

Accessing applicant on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                if ($applicantProfile === null) {
                    $applicantProfile = new Applicant();
                    $applicantProfile->user_id = $user->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                    $applicantProfile->save();
                }
            }
            if ($user->hasRole('manager') ||
                    $user->hasRole('admin')) {
                $managerProfile = $user->manager;

Accessing manager on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                if ($managerProfile === null) {
                    $managerProfile = new Manager();
                    $managerProfile->user_id = $user->id;
                    $managerProfile->save();
                }
            }
        }

        return $next($request);
    }