App\Http\Controllers\Admin\TwoFactorCrudController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setupListOperation()	0	36	1
A	setup()	0	8	2

<?php

namespace App\Http\Controllers\Admin;

use Backpack\CRUD\app\Http\Controllers\CrudController;

class TwoFactorCrudController extends CrudController
{
    use \Backpack\CRUD\app\Http\Controllers\Operations\ListOperation;

The trait Backpack\CRUD\app\Http\Controllers\Operations\ListOperation requires some properties which are not provided by App\Http\Controllers\Admin\TwoFactorCrudController: $model, $query, $entity_name_plural

    use \Backpack\CRUD\app\Http\Controllers\Operations\UpdateOperation;

The trait Backpack\CRUD\app\Http\Controllers\Operations\UpdateOperation requires some properties which are not provided by App\Http\Controllers\Admin\TwoFactorCrudController: $model, $entity_name

    /**
     * Prepare the admin interface by setting the associated
     * model, setting the route, and adding custom columns/fields.
     *
     * @return void
     */
    public function setup() : void
    {
        $this->crud->setModel('App\Models\User');
        $this->crud->setRoute('admin/2fa');
        $this->crud->setEntityNameStrings('Manage 2FA', 'Manage 2FA');
        // Only show current user.
        if (\Auth::user()->hasRole('admin')) {
            $this->crud->addClause('where', 'id', '=', \Auth::user()->id);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        }
    }

    public function setupListOperation()

Missing doc comment for function setupListOperation()

    {
        $this->crud->removeButton('update');

        $this->crud->addColumn([
            'name' => 'id',
            'type' => 'text',
            'label' => 'ID',
            'orderable' => false
        ]);

        $this->crud->addColumn([
            'name' => 'full_name',
            'type' => 'text',
            'label' => 'Name',
            'orderable' => false
        ]);

        $this->crud->addColumn([
            'name' => 'google2fa_secret',
            'type' => 'check',
            'label' => '2FA Enabled',
            'orderable' => false
        ]);

        $this->crud->addColumn([
            'name' => 'recovery_codes',
            'type' => 'array_count',
            'label' => 'Recovery Codes',
            'orderable' => false,
        ]);

        // Add the custom blade buttons (resources/views/vendor/backpack/crud/buttons).
        $this->crud->addButtonFromView('line', 'recovery_codes', 'recovery_codes', 'beginning');
        $this->crud->addButtonFromView('line', 'activate_2fa', 'activate_2fa', 'end');
        $this->crud->addButtonFromView('line', 'deactivate_2fa', 'deactivate_2fa', 'end');
    }
}