WhichPortal::urlIsManagerPortal() - Code Metrics - Inspection of "Merged branch 'dev' into 'feature/job-builder/step..." - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — feature/job-builder/step-03 ( 781974...f4292a )

by Yonathan

created 2019-07-04 15:18 UTC

WhichPortal::urlIsManagerPortal() A

↳ Parent: WhichPortal

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
eloc	4
c	0
b	0
f	0
dl	0
loc	6
ccs	5
cts	5
cp	1
rs	10
cc	1
nc	1
nop	1
crap	1

<?php

namespace App\Services;

use Illuminate\Support\Facades\Route;
use Illuminate\Support\Facades\URL;

class WhichPortal
{

    public function isApplicantPortal()
    {
        return !$this->isManagerPortal();
    }

    public function isManagerPortal()
    {
        $url = URL::current();
        return $this->urlIsManagerPortal($url);
    }

    public function urlIsManagerPortal($url): bool
    {
        $baseUrl = config('app.url');
        $managerPrefix = config('app.manager_prefix');
        $managerPattern = "#^$baseUrl/(\w+/)?$managerPrefix(/.*)?$#";
        return preg_match($managerPattern, $url);

    }
}


1		<?php
2
3		namespace App\Services;
4
5		use Illuminate\Support\Facades\Route;
6		use Illuminate\Support\Facades\URL;
7
8		class WhichPortal
9		{
10
11	25	public function isApplicantPortal()
12		{
13	25	return !$this->isManagerPortal();
14		}
15
16	30	public function isManagerPortal()
17		{
18	30	$url = URL::current();
19	30	return $this->urlIsManagerPortal($url);
20		}
21
22	32	public function urlIsManagerPortal($url): bool
23		{
24	32	$baseUrl = config('app.url');
25	32	$managerPrefix = config('app.manager_prefix');
26	32	$managerPattern = "#^$baseUrl/(\w+/)?$managerPrefix(/.*)?$#";
27	32	return preg_match($managerPattern, $url);
		0 ignored issues – show Bug Best Practice introduced 2019-07-03 15:34 UTC by Report Bug Copy Issue Report The expression `return preg_match($managerPattern, $url)` returns the type `integer` which is incompatible with the type-hinted return `boolean`. Loading history...
28		}
29		}
30

GCTC-NTGC / TalentCloud

Push — feature/job-builder/step-03 ( 781974...f4292a )

WhichPortal::urlIsManagerPortal() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like