JobControllerTest::testManagerCreate() - Code Metrics - Inspection of "Merge branch 'release/1.0.5'" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 52970f...c6d773 )

by Tristan

created 2019-02-12 14:19 UTC

JobControllerTest::testManagerCreate() A

↳ Parent: JobControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	59
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	45
dl	0
loc	59
rs	9.2
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace Tests\Unit;

use Tests\TestCase;
use Illuminate\Foundation\Testing\WithFaker;
use Illuminate\Support\Facades\Lang;

use App\Models\Applicant;
use App\Models\Criteria;
use App\Models\Lookup\Department;
use App\Models\JobPoster;
use App\Models\JobPosterKeyTask;
use App\Models\JobPosterQuestion;
use App\Models\Lookup\LanguageRequirement;
use App\Models\Manager;
use App\Models\Lookup\Province;
use App\Models\Lookup\SecurityClearance;
use Doctrine\Common\Cache\VoidCache;

class JobControllerTest extends TestCase
{
    /**
     * Run parent setup and provide reusable factories.
     *
     * @return void
     */
    protected function setUp() : void
    {
        parent::setUp();

        $this->faker = \Faker\Factory::create();

        $this->faker_fr = \Faker\Factory::create('fr_FR');


        $this->manager = factory(Manager::class)->create();

        $this->jobPoster = factory(JobPoster::class)->create([

            'manager_id' => $this->manager->id
        ]);

        $this->otherManager = factory(Manager::class)->create();

        $this->otherJobPoster = factory(JobPoster::class)->create([

            'manager_id' => $this->otherManager->id
        ]);

        $this->publishedJob = factory(JobPoster::class)->states('published')->create();

    }

    /**
     * Ensure an unauthorized user receives the correct job poster view.
     *
     * @return void
     */
    public function testGuestSingleView() : void
    {
        $response = $this->get('jobs/' . $this->publishedJob->id);
        $response->assertStatus(200);
        $response->assertSee(Lang::get('applicant/job_post')['apply']['login_link_title']);
    }

    /**
     * Ensure an authorized applicant receives the correct job poster view.
     *
     * @return void
     */
    public function testApplicantSingleView() : void
    {
        $applicant = factory(Applicant::class)->create();

        $response = $this->actingAs($applicant->user)
            ->get('jobs/' . $this->publishedJob->id);
        $response->assertStatus(200);
        $response->assertSee(Lang::get('applicant/job_post')['apply']['apply_link_title']);
    }

    /**
     * Ensure a manager can view their index page.
     *
     * @return void
     */
    public function testManagerIndexView() : void
    {
        $response = $this->actingAs($this->manager->user)
            ->get('manager/jobs');
        $response->assertStatus(200);

        $response->assertSee('<h3>' . $this->jobPoster->title . '</h3>');
        $response->assertDontSee('<h3>' . $this->otherJobPoster->title . '</h3>');
    }

    /**
     * Ensure a manager can view the create Job Poster form.
     *
     * @return void
     */
    public function testManagerCreateView() : void
    {
        $response = $this->actingAs($this->manager->user)
            ->get('manager/jobs/create');
        $response->assertStatus(200);

        $response->assertSee('<h2 class="heading--01">' . Lang::get('manager/job_create')['title'] . '</h2>');
        $response->assertViewIs('manager.job_create');

        $response->assertSee(Lang::get('manager/job_create', [], 'en')['questions']['00']);
        $response->assertSee(Lang::get('manager/job_create', [], 'fr')['questions']['00']);
    }

    /**
     * Ensure a manager can create a Job Poster.
     *
     * @return void
     */
    public function testManagerCreate() : void
    {
        $newJob = [
            'term_qty' => $this->faker->numberBetween(1, 4),
            'salary_min' => $this->faker->numberBetween(60000, 80000),
            'salary_max' => $this->faker->numberBetween(80000, 100000),
            'noc' => $this->faker->numberBetween(1, 9999),
            'classification' => $this->faker->regexify('[A-Z]{2}-0[1-5]'),
            'manager_id' => $this->manager->id,
            'published' => false,
            'remote_work_allowed' => $this->faker->boolean(50),
            'open_date' => $this->faker->date('Y-m-d', strtotime('+1 day')),
            'open_time' => $this->faker->time(),
            'close_date' => $this->faker->date('Y-m-d', strtotime('+2 weeks')),
            'close_time' => $this->faker->time(),
            'start_date_time' => $this->faker->date('Y-m-d', strtotime('+2 weeks')) . ' ' . $this->faker->time(),
            'security_clearance' => SecurityClearance::inRandomOrder()->first()->id,
            'language_requirement' => LanguageRequirement::inRandomOrder()->first()->id,
            'department' => Department::inRandomOrder()->first()->id,
            'province' => Province::inRandomOrder()->first()->id,
            'city' => $this->faker->city,
            'title' => [
                'en' => $this->faker->word,
                'fr' => $this->faker_fr->word
            ],
            'impact' => [
                'en' => $this->faker->paragraphs(
                    2,
                    true
                ),
                'fr' => $this->faker_fr->paragraphs(
                    2,
                    true
                )
            ],
            'branch' => [
                'en' => $this->faker->word,
                'fr' => $this->faker_fr->word
            ],
            'division' => [
                'en' => $this->faker->word,
                'fr' => $this->faker_fr->word
            ],
            'education' => [
                'en' => $this->faker->sentence(),
                'fr' => $this->faker_fr->sentence()
            ],
            'submit' => '',
        ];

        $dbValues = array_slice($newJob, 0, 8);

        $response = $this->followingRedirects()
            ->actingAs($this->manager->user)
            ->post('manager/jobs/', $newJob);
        $response->assertStatus(200);
        $response->assertViewIs('applicant.job_post');
        $this->assertDatabaseHas('job_posters', $dbValues);
        $response->assertSee(Lang::get('applicant/job_post')['apply']['edit_link_title']);
    }

    /**
     * Ensure a manager can edit an unpublished Job Poster they created.
     *
     * @return void
     */
    public function testManagerEditView() : void
    {
        $response = $this->actingAs($this->manager->user)
            ->get('manager/jobs/' . $this->jobPoster->id . '/edit');

        $response->assertStatus(200);
        $response->assertViewIs('manager.job_create');
        // Check for a handful of properties
        $response->assertSee($this->jobPoster->city);
        $response->assertSee($this->jobPoster->education);
        $response->assertSee($this->jobPoster->title);
        $response->assertSee($this->jobPoster->impact);
        $response->assertSee($this->jobPoster->branch);
        $response->assertSee($this->jobPoster->division);
        $response->assertSee($this->jobPoster->education);
    }
}


1			<?php
2
3			namespace Tests\Unit;
4
5			use Tests\TestCase;
6			use Illuminate\Foundation\Testing\WithFaker;
7			use Illuminate\Support\Facades\Lang;
8
9			use App\Models\Applicant;
10			use App\Models\Criteria;
11			use App\Models\Lookup\Department;
12			use App\Models\JobPoster;
13			use App\Models\JobPosterKeyTask;
14			use App\Models\JobPosterQuestion;
15			use App\Models\Lookup\LanguageRequirement;
16			use App\Models\Manager;
17			use App\Models\Lookup\Province;
18			use App\Models\Lookup\SecurityClearance;
19			use Doctrine\Common\Cache\VoidCache;
20
21			class JobControllerTest extends TestCase
22			{
23			/**
24			* Run parent setup and provide reusable factories.
25			*
26			* @return void
27			*/
28			protected function setUp() : void
29			{
30			parent::setUp();
31
32			$this->faker = \Faker\Factory::create();
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `faker` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
33			$this->faker_fr = \Faker\Factory::create('fr_FR');
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `faker_fr` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
34
35			$this->manager = factory(Manager::class)->create();
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `manager` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
36			$this->jobPoster = factory(JobPoster::class)->create([
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `jobPoster` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
37			'manager_id' => $this->manager->id
38			]);
39
40			$this->otherManager = factory(Manager::class)->create();
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `otherManager` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
41			$this->otherJobPoster = factory(JobPoster::class)->create([
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 16:17 UTC by Report Bug Copy Issue Report The property `otherJobPoster` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
42			'manager_id' => $this->otherManager->id
43			]);
44
45			$this->publishedJob = factory(JobPoster::class)->states('published')->create();
			0 ignored issues – show Bug Best Practice introduced 2019-01-11 15:31 UTC by Report Bug Copy Issue Report The property `publishedJob` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
46			}
47
48			/**
49			* Ensure an unauthorized user receives the correct job poster view.
50			*
51			* @return void
52			*/
53			public function testGuestSingleView() : void
54			{
55			$response = $this->get('jobs/' . $this->publishedJob->id);
56			$response->assertStatus(200);
57			$response->assertSee(Lang::get('applicant/job_post')['apply']['login_link_title']);
58			}
59
60			/**
61			* Ensure an authorized applicant receives the correct job poster view.
62			*
63			* @return void
64			*/
65			public function testApplicantSingleView() : void
66			{
67			$applicant = factory(Applicant::class)->create();
68
69			$response = $this->actingAs($applicant->user)
70			->get('jobs/' . $this->publishedJob->id);
71			$response->assertStatus(200);
72			$response->assertSee(Lang::get('applicant/job_post')['apply']['apply_link_title']);
73			}
74
75			/**
76			* Ensure a manager can view their index page.
77			*
78			* @return void
79			*/
80			public function testManagerIndexView() : void
81			{
82			$response = $this->actingAs($this->manager->user)
83			->get('manager/jobs');
84			$response->assertStatus(200);
85
86			$response->assertSee('<h3>' . $this->jobPoster->title . '</h3>');
87			$response->assertDontSee('<h3>' . $this->otherJobPoster->title . '</h3>');
88			}
89
90			/**
91			* Ensure a manager can view the create Job Poster form.
92			*
93			* @return void
94			*/
95			public function testManagerCreateView() : void
96			{
97			$response = $this->actingAs($this->manager->user)
98			->get('manager/jobs/create');
99			$response->assertStatus(200);
100
101			$response->assertSee('<h2 class="heading--01">' . Lang::get('manager/job_create')['title'] . '</h2>');
102			$response->assertViewIs('manager.job_create');
103
104			$response->assertSee(Lang::get('manager/job_create', [], 'en')['questions']['00']);
105			$response->assertSee(Lang::get('manager/job_create', [], 'fr')['questions']['00']);
106			}
107
108			/**
109			* Ensure a manager can create a Job Poster.
110			*
111			* @return void
112			*/
113			public function testManagerCreate() : void
114			{
115			$newJob = [
116			'term_qty' => $this->faker->numberBetween(1, 4),
117			'salary_min' => $this->faker->numberBetween(60000, 80000),
118			'salary_max' => $this->faker->numberBetween(80000, 100000),
119			'noc' => $this->faker->numberBetween(1, 9999),
120			'classification' => $this->faker->regexify('[A-Z]{2}-0[1-5]'),
121			'manager_id' => $this->manager->id,
122			'published' => false,
123			'remote_work_allowed' => $this->faker->boolean(50),
124			'open_date' => $this->faker->date('Y-m-d', strtotime('+1 day')),
125			'open_time' => $this->faker->time(),
126			'close_date' => $this->faker->date('Y-m-d', strtotime('+2 weeks')),
127			'close_time' => $this->faker->time(),
128			'start_date_time' => $this->faker->date('Y-m-d', strtotime('+2 weeks')) . ' ' . $this->faker->time(),
129			'security_clearance' => SecurityClearance::inRandomOrder()->first()->id,
130			'language_requirement' => LanguageRequirement::inRandomOrder()->first()->id,
131			'department' => Department::inRandomOrder()->first()->id,
132			'province' => Province::inRandomOrder()->first()->id,
133			'city' => $this->faker->city,
134			'title' => [
135			'en' => $this->faker->word,
136			'fr' => $this->faker_fr->word
137			],
138			'impact' => [
139			'en' => $this->faker->paragraphs(
140			2,
141			true
142			),
143			'fr' => $this->faker_fr->paragraphs(
144			2,
145			true
146			)
147			],
148			'branch' => [
149			'en' => $this->faker->word,
150			'fr' => $this->faker_fr->word
151			],
152			'division' => [
153			'en' => $this->faker->word,
154			'fr' => $this->faker_fr->word
155			],
156			'education' => [
157			'en' => $this->faker->sentence(),
158			'fr' => $this->faker_fr->sentence()
159			],
160			'submit' => '',
161			];
162
163			$dbValues = array_slice($newJob, 0, 8);
164
165			$response = $this->followingRedirects()
166			->actingAs($this->manager->user)
167			->post('manager/jobs/', $newJob);
168			$response->assertStatus(200);
169			$response->assertViewIs('applicant.job_post');
170			$this->assertDatabaseHas('job_posters', $dbValues);
171			$response->assertSee(Lang::get('applicant/job_post')['apply']['edit_link_title']);
172			}
173
174			/**
175			* Ensure a manager can edit an unpublished Job Poster they created.
176			*
177			* @return void
178			*/
179			public function testManagerEditView() : void
180			{
181			$response = $this->actingAs($this->manager->user)
182			->get('manager/jobs/' . $this->jobPoster->id . '/edit');
183
184			$response->assertStatus(200);
185			$response->assertViewIs('manager.job_create');
186			// Check for a handful of properties
187			$response->assertSee($this->jobPoster->city);
188			$response->assertSee($this->jobPoster->education);
189			$response->assertSee($this->jobPoster->title);
190			$response->assertSee($this->jobPoster->impact);
191			$response->assertSee($this->jobPoster->branch);
192			$response->assertSee($this->jobPoster->division);
193			$response->assertSee($this->jobPoster->education);
194			}
195			}
196

GCTC-NTGC / TalentCloud

Push — master ( 52970f...c6d773 )

JobControllerTest::testManagerCreate() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like