SkillDeclarationValidator::__construct() - Code Metrics - Inspection of "Merge branch 'release/1.0.5'" - GCTC-NTGC/TalentCloud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 52970f...c6d773 )

by Tristan

created 2019-02-12 14:19 UTC

SkillDeclarationValidator::__construct() A

↳ Parent: SkillDeclarationValidator

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
eloc	4
dl	0
loc	6
ccs	0
cts	5
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php


namespace App\Services\Validation;

use Illuminate\Support\Facades\Validator;
use Illuminate\Validation\Rule;
use App\Models\Skill;
use App\Models\SkillDeclaration;
use App\Models\Lookup\SkillLevel;
use App\Models\Lookup\SkillStatus;
use App\Models\Applicant;
use App\Services\Validation\Rules\UniqueApplicantSkillRule;

class SkillDeclarationValidator

{

    protected $applicant;
    protected $skill_ids;
    protected $skill_status_ids;
    protected $skill_level_ids;


    public function __construct(Applicant $applicant)

    {
        $this->applicant = $applicant;
        $this->skill_ids = Skill::all()->pluck('id');
        $this->skill_status_ids = SkillStatus::all()->pluck('id');
        $this->skill_level_ids = SkillLevel::all()->pluck('id');

    }

    public function validator(SkillDeclaration $skillDeclaration) {

        $uniqueSkillRule = new UniqueApplicantSkillRule($this->applicant, $skillDeclaration->id);

        //Validate basic data is filled in
        $validator = Validator::make($skillDeclaration->getAttributes(), [

            'skill_id' => [
                'required',
                Rule::in($this->skill_ids->toArray()),
                $uniqueSkillRule,
            ],
            'applicant_id' => [
                'required',
                Rule::in([$this->applicant->id]),
            ],
            'skill_status_id' => [
                'required',
                Rule::in($this->skill_status_ids->toArray()),
            ],
            'skill_level_id' => [
                'required',
                Rule::in($this->skill_level_ids->toArray()),
            ],
            'description' => 'string|required',
        ]);
someFunctionCall(
    $firstArgument,
    $secondArgument,
    $thirdArgument
); // Closing parenthesis on a new line.
        return $validator;
    }

    public function validate(SkillDeclaration $skillDeclaration)

    {
        return $this->validator($skillDeclaration)->validate();
    }


}


1			<?php
2
			0 ignored issues – show Coding Style introduced 2018-11-19 18:09 UTC by Report Bug Copy Issue Report Missing file doc comment Loading history...
3			namespace App\Services\Validation;
4
5			use Illuminate\Support\Facades\Validator;
6			use Illuminate\Validation\Rule;
7			use App\Models\Skill;
8			use App\Models\SkillDeclaration;
9			use App\Models\Lookup\SkillLevel;
10			use App\Models\Lookup\SkillStatus;
11			use App\Models\Applicant;
12			use App\Services\Validation\Rules\UniqueApplicantSkillRule;
13
14			class SkillDeclarationValidator
			0 ignored issues – show Coding Style introduced 2018-12-13 15:22 UTC by Report Bug Copy Issue Report Missing doc comment for class SkillDeclarationValidator Loading history...
15			{
16
17			protected $applicant;
18			protected $skill_ids;
19			protected $skill_status_ids;
20			protected $skill_level_ids;
21
22
23			public function __construct(Applicant $applicant)
			0 ignored issues – show Coding Style introduced 2018-12-17 15:14 UTC by Report Bug Copy Issue Report Missing doc comment for function __construct() Loading history...
24			{
25			$this->applicant = $applicant;
26			$this->skill_ids = Skill::all()->pluck('id');
27			$this->skill_status_ids = SkillStatus::all()->pluck('id');
28			$this->skill_level_ids = SkillLevel::all()->pluck('id');
29
30			}
31
32			public function validator(SkillDeclaration $skillDeclaration) {
			0 ignored issues – show Coding Style introduced 2018-12-13 20:56 UTC by Report Bug Copy Issue Report Missing doc comment for function validator() Loading history...
33			$uniqueSkillRule = new UniqueApplicantSkillRule($this->applicant, $skillDeclaration->id);
34
35			//Validate basic data is filled in
36			$validator = Validator::make($skillDeclaration->getAttributes(), [
			0 ignored issues – show Coding Style introduced 2018-12-13 20:56 UTC by Report Bug Copy Issue Report The opening parenthesis of a multi-line function call should be the last content on the line. Loading history...
37			'skill_id' => [
38			'required',
39			Rule::in($this->skill_ids->toArray()),
40			$uniqueSkillRule,
41			],
42			'applicant_id' => [
43			'required',
44			Rule::in([$this->applicant->id]),
45			],
46			'skill_status_id' => [
47			'required',
48			Rule::in($this->skill_status_ids->toArray()),
49			],
50			'skill_level_id' => [
51			'required',
52			Rule::in($this->skill_level_ids->toArray()),
53			],
54			'description' => 'string\|required',
55			]);
			0 ignored issues – show Coding Style introduced 2018-12-13 20:56 UTC by Report Bug Copy Issue Report For multi-line function calls, the closing parenthesis should be on a new line. If a function call spawns multiple lines, the coding standard suggests to move the closing parenthesis to a new line: someFunctionCall( $firstArgument, $secondArgument, $thirdArgument ); // Closing parenthesis on a new line. Loading history...
56			return $validator;
57			}
58
59			public function validate(SkillDeclaration $skillDeclaration)
			0 ignored issues – show Coding Style introduced 2018-12-13 15:22 UTC by Report Bug Copy Issue Report Missing doc comment for function validate() Loading history...
60			{
61			return $this->validator($skillDeclaration)->validate();
62			}
63
64
65			}
66

GCTC-NTGC / TalentCloud

Push — master ( 52970f...c6d773 )

SkillDeclarationValidator::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like