App\Services\Validation\ReferencesValidator

Complexity

Total Complexity

2

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	validate()	0	17	1

<?php
namespace App\Services\Validation;

Missing file doc comment

use Illuminate\Support\Facades\Validator;
use Illuminate\Validation\Rule;
use App\Models\Reference;
use App\Services\Validation\Rules\UniqueApplicantSkillRule;
class ReferencesValidator

Missing doc comment for class ReferencesValidator

{
    
    protected $applicant;
    protected $relationship_id;
    
    public function __construct(Applicant $applicant)

Missing doc comment for function __construct()

    {
        $this->applicant = $applicant;
        $this->relationship_id = Relationship::all()->pluck('id');
    }
    public function validate(ReferencesValidator $referencesValidator)

Missing doc comment for function validate()

    {
        $uniqueSkillRule = new UniqueApplicantSkillRule($this->applicant, $referencesValidator->id);

The property id does not exist on App\Services\Validation\ReferencesValidator. Did you maybe forget to declare it?

The assignment to $uniqueSkillRule is dead and can be removed.

        //This array is reset every time because applicants table can change frequently
        $applicant_ids = Applicant::all()->pluck('id');
        //Validate basic data is filled in
        Validator::make($referencesValidator->getAttributes(), [

The method getAttributes() does not exist on App\Services\Validation\ReferencesValidator.

The opening parenthesis of a multi-line function call should be the last content on the line.

            'applicant_id' => [
                'required',
                Rule::in($applicant_ids->toArray()),      
        ],  
            'relatonship_id' => [
            'required',
            Rule::in($this->relationship_id->toArray()),
        ]       
            
        ])->validate();

For multi-line function calls, the closing parenthesis should be on a new line.

    }
     
}