App\Services\Validation\CourseValidator

Complexity

Total Complexity

2

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	validate()	0	17	1

<?php
namespace App\Services\Validation;

Missing file doc comment

use Illuminate\Support\Facades\Validator;
use Illuminate\Validation\Rule;
use App\Models\Course;
use App\Models\Lookup\CourseStatus;
use App\Models\Applicant;
use App\Services\Validation\Rules\UniqueApplicantSkillRule;
class CourseValidator

Missing doc comment for class CourseValidator

{ 

Opening class brace must be on a line by itself

    
    protected $applicant;
    protected $course_status_id;
    
    public function __construct(Applicant $applicant)

Missing doc comment for function __construct()

    {
        $this->applicant = $applicant;
        $this->course_status_ids = CourseStatus::all()->pluck('id');

The property course_status_ids does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }
    public function validate(CourseValidator $courseValidator)

Missing doc comment for function validate()

    {
        $uniqueSkillRule = new UniqueApplicantSkillRule($this->applicant, $courseValidator->id);

The assignment to $uniqueSkillRule is dead and can be removed.

The property id does not exist on App\Services\Validation\CourseValidator. Did you maybe forget to declare it?

        //This array is reset every time because applicants table can change frequently
        $applicant_ids = Applicant::all()->pluck('id');
        //Validate basic data is filled in
        Validator::make($courseValidator->getAttributes(), [ 

The method getAttributes() does not exist on App\Services\Validation\CourseValidator.

The opening parenthesis of a multi-line function call should be the last content on the line.

            'applicant_id' => [
             'required',
                Rule::in($applicant_ids->toArray()),
       ],
             'course_status_id' => [
             'required',
                Rule::in($this->course_status_ids->toArray()),    
     ]
         
        ])->validate();

For multi-line function calls, the closing parenthesis should be on a new line.

    }
    
}