GCTC-NTGC / TalentCloud

app/Http/Controllers/Admin/SkillCrudController.php

Spacing +12 added lines, -12 removed lines

@@ -33,7 +33,7 @@ 
         // things like Create Skill, Delete Skills, etc.
         $this->crud->setEntityNameStrings('skill', 'skills');
 
-        $this->crud->operation(['create', 'update'], function () {
+        $this->crud->operation(['create', 'update'], function() {
             // Add custom fields to the create/update views.
             $this->crud->addField([
                 'name' => 'name',
@@ -105,11 +105,11 @@ 
             'name' => 'name',
             'type' => 'text',
             'label' => 'Name',
-            'searchLogic' => function ($query, $column, $searchTerm) use ($locale) : void {
-                $query->orWhere('name->' . $locale, 'like', "%$searchTerm%");
+            'searchLogic' => function($query, $column, $searchTerm) use ($locale) : void {
+                $query->orWhere('name->'.$locale, 'like', "%$searchTerm%");
             },
-            'orderLogic' => function ($query, $column, $columnDirection) use ($locale) {
-                return $query->orderBy('name->' . $locale, $columnDirection)->select('*');
+            'orderLogic' => function($query, $column, $columnDirection) use ($locale) {
+                return $query->orderBy('name->'.$locale, $columnDirection)->select('*');
             }
         ]);
 
@@ -117,8 +117,8 @@ 
             'name' => 'description',
             'type' => 'text',
             'label' => 'Description',
-            'searchLogic' => function ($query, $column, $searchTerm) use ($locale) : void {
-                $query->orWhere('description->' . $locale, 'like', "%$searchTerm%");
+            'searchLogic' => function($query, $column, $searchTerm) use ($locale) : void {
+                $query->orWhere('description->'.$locale, 'like', "%$searchTerm%");
             },
             'orderable' => false,
         ]);
@@ -129,7 +129,7 @@ 
             'type' => 'text',
             'label' => 'Type',
             'orderable' => true,
-            'orderLogic' => function ($query, $column, $columnDirection) use ($locale) {
+            'orderLogic' => function($query, $column, $columnDirection) use ($locale) {
                 return $query->orderBy('skill_type_id', $columnDirection)->select('*');
             }
         ]);
@@ -163,13 +163,13 @@ 
             'key' => 'classifications_filter',
             'type' => 'select2_multiple',
             'label' => 'Filter by classification'
-        ], function () {
+        ], function() {
             // The options that show up in the select2.
             return Classification::all()->pluck('key', 'id')->toArray();
-        }, function ($values) {
+        }, function($values) {
             // If the filter is active.
             foreach (json_decode($values) as $key => $value) {
-                $this->crud->query = $this->crud->query->whereHas('classifications', function ($query) use ($value) {
+                $this->crud->query = $this->crud->query->whereHas('classifications', function($query) use ($value) {
                     $query->where('id', $value);
                 });
             }
@@ -183,7 +183,7 @@ 
                 'label'=> 'No classification'
             ],
             false,
-            function () {
+            function() {
                 $this->crud->query = $this->crud->query->doesntHave('classifications');
             }
         );

app/Http/Controllers/Admin/UserCrudController.php

Spacing +2 added lines, -2 removed lines

@@ -70,9 +70,9 @@
             'name' => 'user_role',
             'type' => 'select2',
             'label' => 'Role'
-            ], function () {
+            ], function() {
                 return UserRole::all()->keyBy('id')->pluck('name', 'id')->toArray();
-            }, function ($value) : void {
+            }, function($value) : void {
                 $this->crud->addClause('where', 'user_role_id', $value);
             });
     }

app/Http/Controllers/Admin/DepartmentCrudController.php

Spacing +3 added lines, -3 removed lines

@@ -29,7 +29,7 @@ 
         // Custom strings to display within the backpack UI.
         $this->crud->setEntityNameStrings('department', 'departments');
 
-        $this->crud->operation(['create', 'update'], function () {
+        $this->crud->operation(['create', 'update'], function() {
             $this->crud->addField([
                 'name' => 'name',
                 'type' => 'text',
@@ -76,8 +76,8 @@ 
             'label' => 'Name',
             'orderable' => true,
             'limit' => 70,
-            'orderLogic' => function ($query, $column, $columnDirection) use ($locale) {
-                return $query->orderBy('name->' . $locale, $columnDirection)->select('*');
+            'orderLogic' => function($query, $column, $columnDirection) use ($locale) {
+                return $query->orderBy('name->'.$locale, $columnDirection)->select('*');
             }
         ]);
 

app/Http/Controllers/ApplicationController.php

Spacing +3 added lines, -4 removed lines

@@ -40,18 +40,17 @@
     public function show(JobApplication $application)
     {
         $criteria = [
-            'essential' => $application->job_poster->criteria->filter(function ($value, $key) {
+            'essential' => $application->job_poster->criteria->filter(function($value, $key) {
                 return $value->criteria_type->name == 'essential';
             }),
-            'asset' => $application->job_poster->criteria->filter(function ($value, $key) {
+            'asset' => $application->job_poster->criteria->filter(function($value, $key) {
                 return $value->criteria_type->name == 'asset';
             }),
         ];
 
         // Display slightly different views on different portals.
         $view = WhichPortal::isManagerPortal() ?
-            'manager/application_post' :
-            'applicant/application_preview';
+            'manager/application_post' : 'applicant/application_preview';
 
         if (WhichPortal::isManagerPortal()) {
             // Load things required for review component.

app/Http/Controllers/ApplicationByJobController.php

Spacing +6 added lines, -6 removed lines

@@ -159,10 +159,10 @@ 
         $this->authorize('update', $application);
 
         $criteria = [
-            'essential' => $jobPoster->criteria->filter(function ($value, $key) {
+            'essential' => $jobPoster->criteria->filter(function($value, $key) {
                 return $value->criteria_type->name == 'essential';
             }),
-            'asset' => $jobPoster->criteria->filter(function ($value, $key) {
+            'asset' => $jobPoster->criteria->filter(function($value, $key) {
                 return $value->criteria_type->name == 'asset';
             }),
         ];
@@ -204,10 +204,10 @@ 
         $this->authorize('update', $application);
 
         $criteria = [
-            'essential' => $jobPoster->criteria->filter(function ($value, $key) {
+            'essential' => $jobPoster->criteria->filter(function($value, $key) {
                 return $value->criteria_type->name == 'essential';
             }),
-            'asset' => $jobPoster->criteria->filter(function ($value, $key) {
+            'asset' => $jobPoster->criteria->filter(function($value, $key) {
                 return $value->criteria_type->name == 'asset';
             }),
         ];
@@ -246,10 +246,10 @@ 
 
         $this->authorize('view', $application);
         $criteria = [
-            'essential' => $jobPoster->criteria->filter(function ($value, $key) {
+            'essential' => $jobPoster->criteria->filter(function($value, $key) {
                 return $value->criteria_type->name == 'essential';
             }),
-            'asset' => $jobPoster->criteria->filter(function ($value, $key) {
+            'asset' => $jobPoster->criteria->filter(function($value, $key) {
                 return $value->criteria_type->name == 'asset';
             }),
         ];

app/Services/Validation/Rules/PassesValidatorRule.php

Spacing +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
      */
     public function passes($attribute, $value)
     {
-        return $value->contains(function ($object) {
+        return $value->contains(function($object) {
             $object->getRelationValue($this->relationName)->is($this->relationValue);
         });
     }

app/Services/Validation/Rules/ContainsObjectWithAttributeRule.php

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         // debugbar()->debug($value);
         // debugbar()->debug($this->attributeName);
         // debugbar()->debug($this->attributeValue);
-        return $this->array_any($value, function ($object) {
+        return $this->array_any($value, function($object) {
             return $object[$this->attributeName] == $this->attributeValue;
         });
     }

app/Services/Validation/JobApplicationAnswerValidator.php

Spacing +1 added lines, -1 removed lines

@@ -7,7 +7,7 @@
 use Illuminate\Support\Facades\Validator;
 use Illuminate\Validation\Rule;
 
-class JobApplicationAnswerValidator {
+class JobApplicationAnswerValidator{
 
     protected $application;
     protected $questionIds;

app/Services/Validation/ApplicationValidator.php

Spacing +5 added lines, -5 removed lines

@@ -13,7 +13,7 @@ 
 use App\Services\Validation\Rules\ContainsObjectWithAttributeRule;
 use App\Services\Validation\JobApplicationAnswerValidator;
 
-class ApplicationValidator {
+class ApplicationValidator{
 
     protected $citizenship_ids;
     protected $veteran_status_ids;
@@ -100,14 +100,14 @@ 
 
         // Validate that each question has been answered
         $jobPosterQuestionRules = [];
-        foreach($application->job_poster->job_poster_questions as $question) {
+        foreach ($application->job_poster->job_poster_questions as $question) {
             $jobPosterQuestionRules[] = new ContainsObjectWithAttributeRule('job_poster_question_id', $question->id);
         }
         $rules['job_application_answers'] = $jobPosterQuestionRules;
         $answerValidatorFactory = new JobApplicationAnswerValidator($application);
 
         //Validate that each answer is complete
-        foreach($application->job_application_answers as $key=>$answer) {
+        foreach ($application->job_application_answers as $key=>$answer) {
             $attribute = implode('.', ['job_application_answers', $key]);
             $rules = $this->addNestedValidatorRules($attribute, $answerValidatorFactory->rules(), $rules);
         }
@@ -135,7 +135,7 @@ 
 
         $skillDeclarationRules = [];
         $criteriaTypeId = CriteriaType::where('name', $criteria_type)->firstOrFail()->id;
-        foreach($application->job_poster->criteria->where('criteria_type_id', $criteriaTypeId) as $criteria) {
+        foreach ($application->job_poster->criteria->where('criteria_type_id', $criteriaTypeId) as $criteria) {
             //Validate that every essential skill has a corresponding declaration
             $skillDeclarationRules[] = new ContainsObjectWithAttributeRule('skill_id', $criteria->skill_id);
         }
@@ -145,7 +145,7 @@ 
         //Validate that those declarations are complete
         $skilDeclarationValidatorFactory = new SkillDeclarationValidator($application->applicant);
         $relevantSkillIds = $application->job_poster->criteria->where('criteria_type_id', $criteriaTypeId)->pluck('skill_id');
-        foreach( $application->skill_declarations as $key=>$declaration) {
+        foreach ($application->skill_declarations as $key=>$declaration) {
             if ($relevantSkillIds->contains($declaration->skill_id)) {
                 $attribute = implode('.', ['skill_declarations', $key]);
                 $skillDeclarationValidator = $skilDeclarationValidatorFactory->validator($declaration);