GCTC-NTGC / TalentCloud

routes/web.php

Indentation +1 added lines, -1 removed lines

@@ -480,7 +480,7 @@
         ->middleware('can:update,jobPoster');
 
 
-     Route::get('jobs/{jobPoster}/criteria', 'Api\CriteriaController@indexByJob')
+        Route::get('jobs/{jobPoster}/criteria', 'Api\CriteriaController@indexByJob')
         ->where('jobPoster', '[0-9]+')
         ->middleware('can:view,jobPoster');
     Route::put('jobs/{jobPoster}/criteria', 'Api\CriteriaController@batchUpdate')

Spacing +15 added lines, -15 removed lines

@@ -18,10 +18,10 @@ 
         'prefix' => LaravelLocalization::setLocale(),
         'middleware' => ['localeSessionRedirect', 'localizationRedirect', 'localeViewPath']
     ],
-    function () : void {
+    function() : void {
         /** ADD ALL LOCALIZED ROUTES INSIDE THIS GROUP **/
 
-        Route::group(['prefix' => 'demo'], function () : void {
+        Route::group(['prefix' => 'demo'], function() : void {
 
             /* Temporary Blog Index */
             Route::view('blog', 'common/blog-index')->middleware('localOnly')->name('blog');
@@ -51,7 +51,7 @@ 
         });
 
 
-        Route::group(['prefix' => config('app.applicant_prefix')], function () : void {
+        Route::group(['prefix' => config('app.applicant_prefix')], function() : void {
 
             /* Home */
             Route::get('/', 'HomepageController@applicant')->name('home');
@@ -64,7 +64,7 @@ 
                 ->name('jobs.show');
 
             /* Require being logged in */
-            Route::middleware(['auth'])->group(function () : void {
+            Route::middleware(['auth'])->group(function() : void {
                 /* Managers */
                 Route::get('managers/{manager}', 'ManagerProfileController@show')
                     ->middleware('can:view,manager')
@@ -72,7 +72,7 @@ 
             });
 
             /* Require being logged in as applicant */
-            Route::middleware(['auth', 'role:applicant'])->group(function () : void {
+            Route::middleware(['auth', 'role:applicant'])->group(function() : void {
 
             // Application permissions are handled within the controller instead of with middleware
                 /* Applications */
@@ -207,9 +207,9 @@ 
 
         Route::group([
             'prefix' => config('app.manager_prefix'),
-        ], function (): void {
+        ], function(): void {
 
-            Route::middleware(['finishManagerRegistration'])->group(function (): void {
+            Route::middleware(['finishManagerRegistration'])->group(function(): void {
 
                 /* Home */
                 Route::get('/', 'HomepageController@manager')->name('manager.home');
@@ -225,7 +225,7 @@ 
                     'ManagerProfileController@faq'
                 )->name('manager.faq.section');
 
-                Route::middleware(['auth', 'role:manager'])->group(function (): void {
+                Route::middleware(['auth', 'role:manager'])->group(function(): void {
 
                     Route::get('profile', 'ManagerProfileController@editAuthenticated')->name('manager.profile');
 
@@ -322,7 +322,7 @@ 
             });
 
             // These routes must be excluded from the finishManagerRegistration middleware to avoid an infinite loop of redirects
-            Route::middleware(['auth', 'role:manager'])->group(function (): void {
+            Route::middleware(['auth', 'role:manager'])->group(function(): void {
                 Route::get('first-visit', 'Auth\FirstVisitController@showFirstVisitManagerForm')
                     ->name('manager.first_visit');
                 Route::post('finish_registration', 'Auth\FirstVisitController@finishManagerRegistration')
@@ -348,7 +348,7 @@ 
         /* AJAX calls =============================================================== */
 
         /* Require being logged in */
-        Route::middleware(['auth'])->group(function () : void {
+        Route::middleware(['auth'])->group(function() : void {
 
             Route::delete('courses/{course}', 'CourseController@destroy')
                 ->middleware('can:delete,course')
@@ -414,7 +414,7 @@ 
                 'prefix' => 'admin',
                 'middleware' => ['auth', 'role:admin']
             ],
-            function (): void {
+            function(): void {
                 /* Edit Job */
                 Route::get('jobs/{jobPoster}/edit', 'JobController@edit')
                     ->where('jobPoster', '[0-9]+')
@@ -435,7 +435,7 @@ 
         'prefix' => 'admin',
         'middleware' => ['auth', 'role:admin']
     ],
-    function (): void {
+    function(): void {
         // This page is non-localized, because the middleware that redirects to localized pages changes POSTs to GETs and messes up the request.
         Route::post('jobs/create/as-manager/{manager}', 'JobController@createAsManager')
             ->middleware('can:create,App\Models\JobPoster')
@@ -449,7 +449,7 @@ 
 
 
 /** API routes - currently using same default http auth, but not localized */
-Route::group(['prefix' => 'api'], function (): void {
+Route::group(['prefix' => 'api'], function(): void {
     // Protected by a gate in the controller, instead of policy middleware
     Route::get('jobs/{jobPoster}/assessment-plan', 'AssessmentPlanController@getForJob');
     // Public, not protected by policy or gate
@@ -494,7 +494,7 @@ 
         ->name('api.jobs.submit');
     Route::resource('jobs', 'Api\JobController')->only([
         'show', 'store', 'update'
-    ])->names([ // Specify custom names because default names collied with existing routes.
+    ])->names([// Specify custom names because default names collied with existing routes.
         'show' => 'api.jobs.show',
         'store' => 'api.jobs.store',
         'update' => 'api.jobs.update'
@@ -502,7 +502,7 @@ 
 
     Route::resource('managers', 'Api\ManagerController')->only([
         'show', 'update'
-    ])->names([ // Specify custom names because default names collied with existing routes
+    ])->names([// Specify custom names because default names collied with existing routes
         'show' => 'api.managers.show',
         'update' => 'api.managers.update'
     ]);

database/factories/UserFactory.php

Spacing +9 added lines, -9 removed lines

@@ -23,14 +23,14 @@ 
 
 $faker_fr = Faker\Factory::create('fr');
 
-$factory->define(User::class, function (Faker\Generator $faker) {
+$factory->define(User::class, function(Faker\Generator $faker){
     static $password;
 
     return [
         'first_name' => $faker->firstName(),
         'last_name' => $faker->lastName(),
         'email' => $faker->unique()->safeEmail(),
-        'password' => $password ? : $password = Hash::make('password'),
+        'password' => $password ?: $password = Hash::make('password'),
         'is_confirmed' => 1,
         'user_role_id' => UserRole::where('name', 'basic')->first()->id, // Users should default to basic user role.
         'remember_token' => str_random(10),
@@ -38,7 +38,7 @@ 
     ];
 });
 
-$factory->state(User::class, 'upgradedManager', function (Faker\Generator $faker) {
+$factory->state(User::class, 'upgradedManager', function(Faker\Generator $faker){
     return [
         'user_role_id' => UserRole::where('name', 'upgradedManager')->first()->id,
         'gov_email' => $faker->unique()->safeEmail(),
@@ -57,20 +57,20 @@ 
     'is_priority' => true
 ]);
 
-$factory->define(Applicant::class, function (Faker\Generator $faker) {
+$factory->define(Applicant::class, function(Faker\Generator $faker){
     return [
         'twitter_username' => $faker->firstName(),
         'linkedin_url' => null,
         'tagline' => $faker->paragraph(),
         'personal_website' => $faker->url(),
         'is_snapshot' => false,
-        'user_id' => function () {
+        'user_id' => function(){
             return factory(User::class)->states('applicant')->create()->id;
         },
     ];
 });
 
-$factory->define(Manager::class, function (Faker\Generator $faker) use ($faker_fr) {
+$factory->define(Manager::class, function(Faker\Generator $faker) use ($faker_fr) {
     return [
         'twitter_username' => $faker->firstName(),
         'linkedin_url' => null,
@@ -81,7 +81,7 @@ 
         'development_opportunity_frequency_id' => Frequency::inRandomOrder()->first()->id,
         'refuse_low_value_work_frequency_id' => Frequency::inRandomOrder()->first()->id,
         'years_experience' => $faker->numberBetween(2, 25),
-        'user_id' => function () use ($faker) {
+        'user_id' => function() use ($faker) {
             return factory(User::class)->create([
                 'gov_email' => $faker->unique()->safeEmail(),
             ])->id;
@@ -110,12 +110,12 @@ 
 });
 
 $factory->state(Manager::class, 'upgraded', [
-    'user_id' => function () {
+    'user_id' => function(){
         return factory(User::class)->state('upgradedManager')->create()->id;
     },
 ]);
 
-$factory->afterCreating(Manager::class, function ($manager) : void {
+$factory->afterCreating(Manager::class, function($manager) : void {
     $manager->team_culture()->save(factory(TeamCulture::class)->create([
         'manager_id' => $manager->id,
     ]));

app/Models/JobPoster.php

Spacing +2 added lines, -2 removed lines

@@ -366,7 +366,7 @@ 
      */
     public function submitted_applications() // phpcs:ignore
     {
-        return $this->hasMany(\App\Models\JobApplication::class)->whereDoesntHave('application_status', function ($query): void {
+        return $this->hasMany(\App\Models\JobApplication::class)->whereDoesntHave('application_status', function($query): void {
             $query->where('name', 'draft');
         });
     }
@@ -555,7 +555,7 @@ 
     public function getClassificationMessageAttribute()
     {
         if ($this->classification_id !== null && $this->classification_level !== null) {
-            return $this->classification->key . '-0' . $this->classification_level;
+            return $this->classification->key.'-0'.$this->classification_level;
         }
         return null;
     }

app/Models/Manager.php

Spacing +1 added lines, -1 removed lines

@@ -187,7 +187,7 @@
     public function getFullNameAttribute(): string
     {
         if ($this->user !== null) {
-            return $this->user->first_name . ' ' . $this->user->last_name;
+            return $this->user->first_name.' '.$this->user->last_name;
         }
         return '';
     }

app/Listeners/ApplicationStatusChanged.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
         }
 
         //Log when application is first created
-        if($application->wasRecentlyCreated) {
+        if ($application->wasRecentlyCreated) {
             $applicationText = "{id=".$application->id.", status=".$application->application_status->name."}";
 
             Log::notice("Application created: application ".$applicationText." has been created by user ".$userText);

app/Services/Validation/Rules/LinkedInUrlRule.php

Spacing +1 added lines, -1 removed lines

@@ -23,7 +23,7 @@
      */
     public function passes($attribute, $value)
     {
-        return preg_match('/' . self::PATTERN . '/', $value);
+        return preg_match('/'.self::PATTERN.'/', $value);
     }
 
     /**

app/Console/Kernel.php

Spacing +1 added lines, -1 removed lines

@@ -60,7 +60,7 @@
         // search $needle in process status
         $result = array_filter(
             $process_status,
-            function ($var) use ($needle) {
+            function($var) use ($needle) {
                 return strpos($var, $needle);
             }
         );

app/Exceptions/Handler.php

Spacing +2 added lines, -2 removed lines

@@ -68,7 +68,7 @@ 
                 'user' => request()->user(),
                 'requestUrl' => request()->url()
             ];
-            $message = '419 CSRF Token Mismatch. ' . collect($logData)->toJson();
+            $message = '419 CSRF Token Mismatch. '.collect($logData)->toJson();
             Log::debug($message);
         }
 
@@ -109,7 +109,7 @@ 
             return $exception->render($request);
         }
         if ($exception instanceof TokenMismatchException) {
-            $newMessage = $exception->getMessage() . ' ' . Lang::get('errors.refresh_page');
+            $newMessage = $exception->getMessage().' '.Lang::get('errors.refresh_page');
             $modifiedException = new TokenMismatchException($newMessage, $exception->getCode(), $exception);
             return parent::render($request, $modifiedException);
         }

app/Http/Requests/StoreRatingGuideAnswer.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
     {
         // Ensure the user can make answers, question exists, and user is the owner of the question it answers.
         if ($this->user()->can('create', RatingGuideAnswer::class)) {
-            $questionId = (int) $this->input('rating_guide_question_id');
+            $questionId = (int)$this->input('rating_guide_question_id');
             if ($questionId) {
                 $question = RatingGuideQuestion::find($questionId);
                 return $question && $this->user()->can('update', $question);