GC0202 / ThinkLibrary

src/service/StorageService.php

<?php

// +----------------------------------------------------------------------
// | ThinkLibrary 6.0 for ThinkPhP 6.0
// +----------------------------------------------------------------------
// | 版权所有 2017~2020 [ https://www.dtapp.net ]
// +----------------------------------------------------------------------
// | 官方网站: https://gitee.com/liguangchun/ThinkLibrary
// +----------------------------------------------------------------------
// | 开源协议 ( https://mit-license.org )
// +----------------------------------------------------------------------
// | gitee 仓库地址 ：https://gitee.com/liguangchun/ThinkLibrary
// | github 仓库地址 ：https://github.com/GC0202/ThinkLibrary
// | Packagist 地址 ：https://packagist.org/packages/liguangchun/think-library
// +----------------------------------------------------------------------

namespace DtApp\ThinkLibrary\service;

use DtApp\ThinkLibrary\Service;

/**
 * 本地存储
 * Class StorageService
 * @package DtApp\ThinkLibrary\service
 */
class StorageService extends Service
{
    /**
     * @var string
     */
    private $path = '', $remotely = '';

    /**
     * 文件夹
     * @param string $path
     * @return $this
     */
    public function path(string $path): self
    {
        $this->path = $path;
        return $this;
    }

    /**
     * 需要保存的远程文件
     * @param string $remotely
     * @return $this
     */
    public function remotely(string $remotely): self
    {
        $this->remotely = $remotely;
        return $this;
    }

    /**
     * 获取配置信息
     * @return $this
     */
    private function getConfig(): self
    {
        $this->path = config('dtapp.storage.path');

It seems like config('dtapp.storage.path') can also be of type boolean. However, the property $path is declared as type string. Maybe add an additional type check?

        return $this;
    }

    /**
     * 保存文件
     * @param string $name 保存的文件名
     * @return array
     */
    public function save(string $name): array
    {
        if (empty($this->path)) {
            $this->getConfig();
        }
        // 判断文件夹是否存在
        is_dir($this->path) || mkdir($concurrentDirectory = $this->path, 0777, true) || is_dir($concurrentDirectory);

It seems like $this->path can also be of type boolean. However, the property $path is declared as type string. Maybe add an additional type check?

It seems like $concurrentDirectory = $this->path can also be of type boolean; however, parameter $directory of mkdir() does only seem to accept string, maybe add an additional type check?

It seems like $this->path can also be of type boolean; however, parameter $filename of is_dir() does only seem to accept string, maybe add an additional type check?

        $return_content = $this->http_get_data($this->remotely);
        $fp = @fopen("{$this->path}{$name}", "a"); //将文件绑定到流
        fwrite($fp, $return_content); //写入文件

It seems like $fp can also be of type false; however, parameter $stream of fwrite() does only seem to accept resource, maybe add an additional type check?

        return [
            'file_name' => $name,
            'path' => $this->path,
            'remotely' => $this->remotely,
            'save_path' => "{$this->path}{$name}",
            'size' => $this->bytes($name)
        ];
    }

    /**
     * 下载
     * @param $url
     * @return false|string
     */
    private function http_get_data($url)
    {
        $ch = curl_init();
        curl_setopt($ch, CURLOPT_CUSTOMREQUEST, 'GET');
        curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
        curl_setopt($ch, CURLOPT_URL, $url);
        ob_start();
        curl_exec($ch);
        $return_content = ob_get_clean();
        $return_code = curl_getinfo($ch, CURLINFO_HTTP_CODE);

The assignment to $return_code is dead and can be removed.

        return $return_content;
    }

    /**
     * 删除文件
     * @param string $name
     * @return bool
     */
    public function delete(string $name)
    {
        if (empty($this->path)) {
            $this->getConfig();
        }
        if (file_exists($name)) {
            if (unlink($name)) {
                return true;
            }
        }
        return false;
    }

    /**
     * 统计文件大小
     * @param string $name
     * @return string
     */
    public function bytes(string $name)
    {
        if (empty($this->path)) {
            $this->getConfig();
        }
        $bytes = filesize($this->path . $name);
        if ($bytes >= 1073741824) {
            $bytes = round($bytes / 1073741824 * 100) / 100 . 'GB';
        } elseif ($bytes >= 1048576) {
            $bytes = round($bytes / 1048576 * 100) / 100 . 'MB';
        } elseif ($bytes >= 1024) {
            $bytes = round($bytes / 1024 * 100) / 100 . 'KB';
        } else {
            $bytes .= 'Bytes';
        }
        return $bytes;
    }

    /**
     * 获取文件路径
     * @return string
     */
    public function getPath(): string
    {
        if (empty($this->path)) {
            $this->getConfig();
        }
        return $this->path;

The expression return $this->path could return the type boolean which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }
}