GC0202 / ThinkLibrary

src/command/Install.php

<?php

// +----------------------------------------------------------------------
// | ThinkLibrary 6.0 for ThinkPhP 6.0
// +----------------------------------------------------------------------
// | 版权所有 2017~2020 [ https://www.dtapp.net ]
// +----------------------------------------------------------------------
// | 官方网站: https://gitee.com/liguangchun/ThinkLibrary
// +----------------------------------------------------------------------
// | 开源协议 ( https://mit-license.org )
// +----------------------------------------------------------------------
// | gitee 仓库地址 ：https://gitee.com/liguangchun/ThinkLibrary
// | github 仓库地址 ：https://github.com/GC0202/ThinkLibrary
// | Packagist 地址 ：https://packagist.org/packages/liguangchun/think-library
// +----------------------------------------------------------------------

namespace DtApp\ThinkLibrary\command;

use think\console\Command;
use think\console\Input;
use think\console\input\Argument;
use think\console\Output;

class Install extends Command
{
    /**
     * 名称
     * @var string
     */
    protected $name;

    protected function configure()
    {
        $this->setName('dta:install');
        $this->setDescription("Install or update dtapp");
        $this->addArgument('name', Argument::OPTIONAL, 'Name', '');
    }

    protected function execute(Input $input, Output $output)
    {
        $this->name = trim($input->getArgument('name'));

It seems like $input->getArgument('name') can also be of type think\console\input\Argument; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

        if (empty($this->name)) {
            $this->output->writeln('name of online installation cannot be empty');
        } else {
            $this->output->writeln("The specified module {$this->name} is not configured with installation rules");
        }
    }
}