AliyunClient::execute()

Complexity

Conditions	13
Paths	129

Size

Total Lines	93
Code Lines	53

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
	public function execute($request)
	{
		if($this->checkRequest) {
			try {
				$request->check();
			} catch (Exception $e) {
				$result->code = $e->getCode();

The variable $result seems to be never defined.

				$result->message = $e->getMessage();
				return $result;
			}
		}
		//获取业务参数
		$apiParams = $request->getApiParas();
		//组装系统参数
		$apiParams["AccessKeyId"] = $this->accessKeyId;
		$apiParams["Format"] = $this->format;//
		$apiParams["SignatureMethod"] = $this->signatureMethod;
		$apiParams["SignatureVersion"] = $this->signatureVersion;
		$apiParams["SignatureNonce"] = uniqid();
		date_default_timezone_set("GMT");
		$apiParams["TimeStamp"] = date($this->dateTimeFormat);
		$apiParams["partner_id"] = $this->sdkVersion;
		
	    $apiNameArray =	split("\.", $request->getApiMethodName());

The function split() has been deprecated: 5.3.0 Use preg_split() instead

		$apiParams["Action"] = $apiNameArray[3];
		$apiParams["Version"] = $apiNameArray[4];
		//签名
		$apiParams["Signature"] = $this->computeSignature($apiParams, $this->accessKeySecret);

		//系统参数放入GET请求串
		$requestUrl = rtrim($this->serverUrl,"/") . "/?";
		foreach ($apiParams as $apiParamKey => $apiParamValue)
		{
			$requestUrl .= "$apiParamKey=" . urlencode($apiParamValue) . "&";
		}
		$requestUrl = substr($requestUrl, 0, -1);
		//发起HTTP请求
		try
		{
			$resp = $this->curl($requestUrl, null);
		}
		catch (Exception $e)
		{
			$this->logCommunicationError($apiParams["Action"],$requestUrl,"HTTP_ERROR_" . $e->getCode(),$e->getMessage());
			if ("json" == $this->format)
			{
				return  json_decode($e->getMessage());
			}
			else if("xml" == $this->format)
			{
				return  @simplexml_load_string($e->getMessage());
			}
	    }

		//解析API返回结果
		$respWellFormed = false;
		if ("json" == $this->format)
		{
			$respObject = json_decode($resp);
			if (null !== $respObject)
			{
				$respWellFormed = true;
			}
		}
		else if("xml" == $this->format)
		{
			$respObject = @simplexml_load_string($resp);
			if (false !== $respObject)
			{
				$respWellFormed = true;
			}
		}

		//返回的HTTP文本不是标准JSON或者XML，记下错误日志
		if (false === $respWellFormed)
		{
			$this->logCommunicationError($apiParams["Action"],$requestUrl,"HTTP_RESPONSE_NOT_WELL_FORMED",$resp);
			$result->code = 0;
			$result->message = "HTTP_RESPONSE_NOT_WELL_FORMED";
			return $result;
		}

		//如果TOP返回了错误码，记录到业务错误日志中
		if (isset($respObject->code))

The variable $respObject does not seem to be defined for all execution paths leading up to this point.

		{
			$logger = new LtLogger;

The type LtLogger was not found. Maybe you did not declare it correctly or list all dependencies?

			$logger->conf["log_file"] = rtrim(TOP_SDK_WORK_DIR, '\\/') . '/' . "logs/top_biz_err_" . $this->appkey . "_" . date("Y-m-d") . ".log";

The property appkey does not exist on AliyunClient. Did you maybe forget to declare it?

			$logger->log(array(
				date("Y-m-d H:i:s"),
				$resp
			));
		}
		return $respObject;
	}