AliyunClient::curl() - Code Metrics - Inspection of "- 测试淘宝官方SDK" - GC0202/ThinkLibrary - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — v6 ( 95b370...25ce72 )

by 光春
created 2020-11-18 16:19 UTC
AliyunClient::curl() B

↳ Parent: AliyunClient
Complexity

Conditions	11
Paths	48
Size

Total Lines	52
Code Lines	30
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	11
eloc	30
c	1
b	0
f	0
nc	48
nop	2
dl	0
loc	52
rs	7.3166
How to fix Long Method Complexity

<?php
class AliyunClient
{
	public $accessKeyId;

	public $accessKeySecret;

	public $serverUrl = "http://ecs.aliyuncs.com/";

	public $format = "json";

	public $connectTimeout = 3000;//3秒

	public $readTimeout = 80000;//80秒

	/** 是否打开入参check**/
	public $checkRequest = true;

	protected $signatureMethod = "HMAC-SHA1";

	protected $signatureVersion = "1.0";
	
    protected  $dateTimeFormat = 'Y-m-d\TH:i:s\Z'; // ISO8601规范
	
	protected $sdkVersion = "1.0";

	public function execute($request)
	{
		if($this->checkRequest) {
			try {
				$request->check();
			} catch (Exception $e) {
				$result->code = $e->getCode();

				$result->message = $e->getMessage();
				return $result;
			}
		}
		//获取业务参数
		$apiParams = $request->getApiParas();
		//组装系统参数
		$apiParams["AccessKeyId"] = $this->accessKeyId;
		$apiParams["Format"] = $this->format;//
		$apiParams["SignatureMethod"] = $this->signatureMethod;
		$apiParams["SignatureVersion"] = $this->signatureVersion;
		$apiParams["SignatureNonce"] = uniqid();
		date_default_timezone_set("GMT");
		$apiParams["TimeStamp"] = date($this->dateTimeFormat);
		$apiParams["partner_id"] = $this->sdkVersion;
		
	    $apiNameArray =	split("\.", $request->getApiMethodName());
	    $apiNameArray =	/** @scrutinizer ignore-deprecated */ split("\.", $request->getApiMethodName());
		$apiParams["Action"] = $apiNameArray[3];
		$apiParams["Version"] = $apiNameArray[4];
		//签名
		$apiParams["Signature"] = $this->computeSignature($apiParams, $this->accessKeySecret);

		//系统参数放入GET请求串
		$requestUrl = rtrim($this->serverUrl,"/") . "/?";
		foreach ($apiParams as $apiParamKey => $apiParamValue)
		{
			$requestUrl .= "$apiParamKey=" . urlencode($apiParamValue) . "&";
		}
		$requestUrl = substr($requestUrl, 0, -1);
		//发起HTTP请求
		try
		{
			$resp = $this->curl($requestUrl, null);
		}
		catch (Exception $e)
		{
			$this->logCommunicationError($apiParams["Action"],$requestUrl,"HTTP_ERROR_" . $e->getCode(),$e->getMessage());
			if ("json" == $this->format)
			{
				return  json_decode($e->getMessage());
			}
			else if("xml" == $this->format)
			{
				return  @simplexml_load_string($e->getMessage());
			}
	    }

		//解析API返回结果
		$respWellFormed = false;
		if ("json" == $this->format)
		{
			$respObject = json_decode($resp);
			if (null !== $respObject)
			{
				$respWellFormed = true;
			}
		}
		else if("xml" == $this->format)
		{
			$respObject = @simplexml_load_string($resp);
			if (false !== $respObject)
			{
				$respWellFormed = true;
			}
		}

		//返回的HTTP文本不是标准JSON或者XML，记下错误日志
		if (false === $respWellFormed)
		{
			$this->logCommunicationError($apiParams["Action"],$requestUrl,"HTTP_RESPONSE_NOT_WELL_FORMED",$resp);
			$result->code = 0;
			$result->message = "HTTP_RESPONSE_NOT_WELL_FORMED";
			return $result;
		}

		//如果TOP返回了错误码，记录到业务错误日志中
		if (isset($respObject->code))

		{
			$logger = new LtLogger;
filter:
    dependency_paths: ["lib/*"]
			$logger->conf["log_file"] = rtrim(TOP_SDK_WORK_DIR, '\\/') . '/' . "logs/top_biz_err_" . $this->appkey . "_" . date("Y-m-d") . ".log";

			$logger->log(array(
				date("Y-m-d H:i:s"),
				$resp
			));
		}
		return $respObject;
	}

	public function exec($paramsArray)
	{
		if (!isset($paramsArray["Action"]))
		{
			trigger_error("No api name passed");
		}
		$inflector = new LtInflector;
filter:
    dependency_paths: ["lib/*"]
		$inflector->conf["separator"] = ".";
		$requestClassName = ucfirst($inflector->camelize(substr($paramsArray["Action"], 7))) . "Request";
		if (!class_exists($requestClassName))
		{
			trigger_error("No such api: " . $paramsArray["Action"]);
		}

		$req = new $requestClassName;
		foreach($paramsArray as $paraKey => $paraValue)
		{
			$inflector->conf["separator"] = "_";
			$setterMethodName = $inflector->camelize($paraKey);
			$inflector->conf["separator"] = ".";
			$setterMethodName = "set" . $inflector->camelize($setterMethodName);
			if (method_exists($req, $setterMethodName))
			{
				$req->$setterMethodName($paraValue);
			}
		}
		return $this->execute($req, $session);
		return $this->/** @scrutinizer ignore-call */ execute($req, $session);
	}
	
	protected function percentEncode($str)
	{
	    // 使用urlencode编码后，将"+","*","%7E"做替换即满足 API规定的编码规范
	    $res = urlencode($str);
	    $res = preg_replace('/\+/', '%20', $res);
	    $res = preg_replace('/\*/', '%2A', $res);
	    $res = preg_replace('/%7E/', '~', $res);
	    return $res;
	}
	
	protected function computeSignature($parameters, $accessKeySecret)
	{
	    // 将参数Key按字典顺序排序
	    ksort($parameters);
	
	    // 生成规范化请求字符串
	    $canonicalizedQueryString = '';
	    foreach($parameters as $key => $value)
	    {
		$canonicalizedQueryString .= '&' . $this->percentEncode($key) 
		    . '=' . $this->percentEncode($value);
	    }
	
	    // 生成用于计算签名的字符串 stringToSign
	    $stringToSign = 'GET&%2F&' . $this->percentencode(substr($canonicalizedQueryString, 1));
	
	    // 计算签名，注意accessKeySecret后面要加上字符'&'
	    $signature = base64_encode(hash_hmac('sha1', $stringToSign, $accessKeySecret . '&', true));
	    return $signature;
	}
	
    public function curl($url, $postFields = null)
	{
		$ch = curl_init();
		curl_setopt($ch, CURLOPT_URL, $url);
		curl_setopt(/** @scrutinizer ignore-type */ $ch, CURLOPT_URL, $url);
		curl_setopt($ch, CURLOPT_FAILONERROR, false);
		curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
		if ($this->readTimeout) {
			curl_setopt($ch, CURLOPT_TIMEOUT, $this->readTimeout);
		}
		if ($this->connectTimeout) {
			curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, $this->connectTimeout);
		}
		//https 请求
		if(strlen($url) > 5 && strtolower(substr($url,0,5)) == "https" ) {
			curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
			curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, false);
		}

		if (is_array($postFields) && 0 < count($postFields))
		{
			$postBodyString = "";
			$postMultipart = false;
			foreach ($postFields as $k => $v)
			{
				if("@" != substr($v, 0, 1))//判断是不是文件上传
				{
					$postBodyString .= "$k=" . urlencode($v) . "&"; 
				}
				else//文件上传用multipart/form-data，否则用www-form-urlencoded
				{
					$postMultipart = true;
				}
			}
			unset($k, $v);
			curl_setopt($ch, CURLOPT_POST, true);
			if ($postMultipart)
			{
				curl_setopt($ch, CURLOPT_POSTFIELDS, $postFields);
			}
			else
			{
				curl_setopt($ch, CURLOPT_POSTFIELDS, substr($postBodyString,0,-1));
			}
		}
		$reponse = curl_exec($ch);
		$reponse = curl_exec(/** @scrutinizer ignore-type */ $ch);
		
		if (curl_errno($ch))
		if (curl_errno(/** @scrutinizer ignore-type */ $ch))
		{
			throw new Exception(curl_error($ch),0);
			throw new Exception(curl_error(/** @scrutinizer ignore-type */ $ch),0);
		}
		curl_close($ch);
		curl_close(/** @scrutinizer ignore-type */ $ch);
		return $reponse;
	}

	protected function logCommunicationError($apiName, $requestUrl, $errorCode, $responseTxt)
	{
		$localIp = isset($_SERVER["SERVER_ADDR"]) ? $_SERVER["SERVER_ADDR"] : "CLI";
		$logger = new LtLogger;
		$logger->conf["log_file"] = rtrim(TOP_SDK_WORK_DIR, '\\/') . '/' . "logs/top_comm_err_" . $this->accessKeyId . "_" . date("Y-m-d") . ".log";
		$logger->conf["separator"] = "^_^";
		$logData = array(
		date("Y-m-d H:i:s"),
		$apiName,
		$this->accessKeyId,
		$localIp,
		PHP_OS,
		$this->sdkVersion,
		$requestUrl,
		$errorCode,
		str_replace("\n","",$responseTxt)
		);
		$logger->log($logData);
	}
}

GC0202 / ThinkLibrary

Push — v6 ( 95b370...25ce72 )

AliyunClient::curl() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
