GC0202 /
ThinkLibrary
| Conditions | 2 |
| Paths | 2 |
| Total Lines | 51 |
| Code Lines | 37 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 45 | function multipartUpload($client,$bucket,$keyprefix){ |
||
| 46 | //初始化分开上传，获取uploadid |
||
| 47 | $args = array( |
||
| 48 | "Bucket"=>$bucket, |
||
| 49 | "Key"=>$keyprefix."EOFile", |
||
| 50 | ); |
||
| 51 | $uploadid = $client->initMultipartUpload($args); |
||
| 52 | $uploadid = $uploadid["UploadId"];//获取到uploadid |
||
| 53 | //开始上传 |
||
| 54 | |||
| 55 | $file = "D://IMG.jpg";//要上传的文件 |
||
| 56 | $partsize = 1024*100; |
||
| 57 | $resource = fopen($file,"r"); |
||
| 58 | $stat = fstat($resource); |
||
| 59 | $total = $stat["size"];//获取文件的总大小 |
||
| 60 | fclose($resource); |
||
| 61 | $count = (int)(($total-1)/$partsize)+1;//计算文件需要分几块上传 |
||
| 62 | for($i = 0;$i < $count;$i++){ |
||
| 63 | //依次上传每一块 |
||
| 64 | echo "upload".$i."\r\n"; |
||
| 65 | $args=array( |
||
| 66 | "Bucket"=>$bucket, |
||
| 67 | "Key"=>$keyprefix."EOFile", |
||
| 68 | "LastPart"=>($i===$count-1), |
||
| 69 | "Options"=>array( |
||
| 70 | "partNumber"=>$i+1, |
||
| 71 | "uploadId"=>$uploadid |
||
| 72 | ), |
||
| 73 | "ObjectMeta"=>array( |
||
| 74 | "Content-Length"=>min($partsize,$total-$partsize*$i)//每次上传$partsize大小 |
||
| 75 | ), |
||
| 76 | "Content"=>array( |
||
| 77 | "content"=>$file, |
||
| 78 | "seek_position"=>$partsize*$i//跳过之前已经上传的 |
||
| 79 | ) |
||
| 80 | ); |
||
| 81 | $etag = $client->uploadPart($args); |
||
| 82 | $etag = $etag["ETag"]; |
||
| 83 | } |
||
| 84 | $parts = $client->listParts(array("Bucket"=>$bucket,"Key"=>$keyprefix."EOFile","Options"=>array("uploadId"=>$uploadid))); |
||
| 85 | //结束上传 |
||
| 86 | $args=array( |
||
| 87 | "Bucket"=>$bucket, |
||
| 88 | "Key"=>$keyprefix."EOFile", |
||
| 89 | "Options"=>array("uploadId"=>$uploadid), |
||
| 90 | "Parts"=>$parts["Parts"]//使用之前列出的块完成分开上传 |
||
| 91 | ); |
||
| 92 | $result = $client->completeMultipartUpload($args); |
||
| 93 | |||
| 94 | rangeGetAndCheckMd5($client,$bucket,$keyprefix."EOFile", |
||
| 95 | "D://testdown/down",base64_encode(md5_file("D://IMG.jpg"))); |
||
| 96 | } |
||
| 171 |
Loading history...
This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.
If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.