CollectionFactory::newCollection() - Code Metrics - Inspection of "refactored constructor parameter ordering" - FusionPHP/collection - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — validation-refactor (de59e2)

by Jason

created 2018-05-22 19:36 UTC

CollectionFactory::newCollection() A

↳ Parent: CollectionFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	1
nc	1
nop	1
crap	1

<?php
/**
 * Created by PhpStorm.
 * User: jwalker
 * Date: 5/22/2018
 * Time: 9:27 AM
 */

namespace Fusion\Collection;


use Fusion\Collection\Contracts\CollectionValidationInterface;

class CollectionFactory
{
    /** @var \Fusion\Collection\Contracts\CollectionValidationInterface */
    private static $cachedValidator;

    private static function getValidator(): CollectionValidationInterface
    {
        if (self::$cachedValidator === null || (self::$cachedValidator instanceof CollectionValidationInterface) === false)
        {
            self::$cachedValidator = new CollectionValidator();
        }

        return self::$cachedValidator;
    }

    public static function newCollection(array $starterItems = []): Collection
    {
        return new Collection(self::getValidator(), $starterItems);
    }

    public static function newTypedCollection(string $acceptedType, array $starterItems = []): TypedCollection
    {
        return new TypedCollection(self::getValidator(), $acceptedType, $starterItems);
    }

    public static function newDictionary(array $starterItems = []): Dictionary
    {
        return new Dictionary(self::getValidator(), $starterItems);
    }

    public static function newTypedDictionary(string $acceptedType, array $starterItems = []): TypedDictionary
    {
        return new TypedDictionary(self::getValidator(), $acceptedType, $starterItems);
    }
}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: jwalker
5		* Date: 5/22/2018
6		* Time: 9:27 AM
7		*/
8
9		namespace Fusion\Collection;
10
11
12		use Fusion\Collection\Contracts\CollectionValidationInterface;
13
14		class CollectionFactory
15		{
16		/** @var \Fusion\Collection\Contracts\CollectionValidationInterface */
17		private static $cachedValidator;
18
19	93	private static function getValidator(): CollectionValidationInterface
20		{
21	93	if (self::$cachedValidator === null \|\| (self::$cachedValidator instanceof CollectionValidationInterface) === false)
22		{
23	1	self::$cachedValidator = new CollectionValidator();
24		}
25
26	93	return self::$cachedValidator;
27		}
28
29	49	public static function newCollection(array $starterItems = []): Collection
30		{
31	49	return new Collection(self::getValidator(), $starterItems);
32		}
33
34	13	public static function newTypedCollection(string $acceptedType, array $starterItems = []): TypedCollection
35		{
36	13	return new TypedCollection(self::getValidator(), $acceptedType, $starterItems);
37		}
38
39	21	public static function newDictionary(array $starterItems = []): Dictionary
40		{
41	21	return new Dictionary(self::getValidator(), $starterItems);
42		}
43
44	10	public static function newTypedDictionary(string $acceptedType, array $starterItems = []): TypedDictionary
45		{
46	10	return new TypedDictionary(self::getValidator(), $acceptedType, $starterItems);
47		}
48		}

FusionPHP / collection

Branch — validation-refactor (de59e2)

CollectionFactory::newCollection() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like