Model - Code Metrics - Inspection of "Making some good progress in ModelTest. Currently..." - Fuitad/laravel-cassandra - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( da7eaf...ab8466 )

by Pierre-Luc

created 2017-03-21 16:11 UTC

Model A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	15
lcom	1
cbo	4
dl	0
loc	111
rs	10
c	1
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	newEloquentBuilder()	4	1
A	newBaseQueryBuilder()	6	1
A	freshTimestamp()	4	1
A	fromDateTime()	14	3
A	asDateTime()	9	2
A	originalIsNumericallyEquivalent()	15	4
A	getQualifiedKeyName()	4	1
A	__call()	9	2

<?php

namespace fuitad\LaravelCassandra\Eloquent;

use Cassandra\Timestamp;
use fuitad\LaravelCassandra\Query\Builder as QueryBuilder;
use Illuminate\Database\Eloquent\Model as BaseModel;

abstract class Model extends BaseModel
{
    /**
     * Indicates if the IDs are auto-incrementing.
     * This is not possible in cassandra so we override this
     *
     * @var bool
     */
    public $incrementing = false;

    /**
     * @inheritdoc
     */
    public function newEloquentBuilder($query)
    {
        return new Builder($query);
    }

    /**
     * @inheritdoc
     */
    protected function newBaseQueryBuilder()
    {
        $connection = $this->getConnection();

        return new QueryBuilder($connection, $connection->getPostProcessor());

    }

    /**
     * @inheritdoc
     */
    public function freshTimestamp()
    {
        return new Timestamp();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @inheritdoc
     */
    public function fromDateTime($value)
    {
        // If the value is already a Timestamp instance, we don't need to parse it.
        if ($value instanceof Timestamp) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            return $value;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        // Let Eloquent convert the value to a DateTime instance.
        if (!$value instanceof DateTime) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $value = parent::asDateTime($value);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        }

        return new Timestamp($value->getTimestamp() * 1000);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @inheritdoc
     */
    protected function asDateTime($value)
    {
        // Convert UTCDateTime instances.
        if ($value instanceof Timestamp) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
            return parent::asDateTime($value->toDateTime());
        }

        return parent::asDateTime($value);
    }

    /**
     * @inheritdoc
     */
    protected function originalIsNumericallyEquivalent($key)
    {
        $current = $this->attributes[$key];
        $original = $this->original[$key];

        // Date comparison.
        if (in_array($key, $this->getDates())) {
            $current = $current instanceof Timestamp ? $this->asDateTime($current) : $current;
if ($x instanceof DoesNotExist) {
    // Do something.
}
            $original = $original instanceof Timestamp ? $this->asDateTime($original) : $original;
if ($x instanceof DoesNotExist) {
    // Do something.
}

            return $current == $original;
        }

        return parent::originalIsNumericallyEquivalent($key);
    }

    /**
     * Get the table qualified key name.
     * Cassandra does not support the table.column annotation so
     * we override this
     *
     * @return string
     */
    public function getQualifiedKeyName()
    {
        return $this->getKeyName();
    }

    /**
     * @inheritdoc
     */
    public function __call($method, $parameters)
    {
        // Unset method
        if ($method == 'unset') {
            return call_user_func_array([$this, 'drop'], $parameters);
        }

        return parent::__call($method, $parameters);
    }
}


1			<?php
2
3			namespace fuitad\LaravelCassandra\Eloquent;
4
5			use Cassandra\Timestamp;
6			use fuitad\LaravelCassandra\Query\Builder as QueryBuilder;
7			use Illuminate\Database\Eloquent\Model as BaseModel;
8
9			abstract class Model extends BaseModel
10			{
11			/**
12			* Indicates if the IDs are auto-incrementing.
13			* This is not possible in cassandra so we override this
14			*
15			* @var bool
16			*/
17			public $incrementing = false;
18
19			/**
20			* @inheritdoc
21			*/
22			public function newEloquentBuilder($query)
23			{
24			return new Builder($query);
25			}
26
27			/**
28			* @inheritdoc
29			*/
30			protected function newBaseQueryBuilder()
31			{
32			$connection = $this->getConnection();
33
34			return new QueryBuilder($connection, $connection->getPostProcessor());
			0 ignored issues – show Compatibility introduced 2017-03-20 19:45 UTC by Report Bug Copy Issue Report `$connection` of type `object<Illuminate\Database\Connection>` is not a sub-type of `object<fuitad\LaravelCassandra\Connection>`. It seems like you assume a child class of the class `Illuminate\Database\Connection` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history... Compatibility introduced 2017-03-20 19:45 UTC by Report Bug Copy Issue Report `$connection->getPostProcessor()` of type `object<Illuminate\Databa...y\Processors\Processor>` is not a sub-type of `object<fuitad\LaravelCassandra\Query\Processor>`. It seems like you assume a child class of the class `Illuminate\Database\Query\Processors\Processor` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
35			}
36
37			/**
38			* @inheritdoc
39			*/
40			public function freshTimestamp()
41			{
42			return new Timestamp();
			0 ignored issues – show Bug Best Practice introduced 2017-03-20 19:45 UTC by Report Bug Copy Issue Report The return type of `return new \Cassandra\Timestamp();` (`Cassandra\Timestamp`) is incompatible with the return type of the parent method `Illuminate\Database\Eloquent\Model::freshTimestamp` of type `Carbon\Carbon`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
43			}
44
45			/**
46			* @inheritdoc
47			*/
48			public function fromDateTime($value)
49			{
50			// If the value is already a Timestamp instance, we don't need to parse it.
51			if ($value instanceof Timestamp) {
			0 ignored issues – show Bug introduced 2017-03-20 19:45 UTC by Report Bug Copy Issue Report The class `Cassandra\Timestamp` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
52			return $value;
			0 ignored issues – show Bug Best Practice introduced 2017-03-20 19:45 UTC by Report Bug Copy Issue Report The return type of `return $value;` (`Cassandra\Timestamp`) is incompatible with the return type of the parent method `Illuminate\Database\Eloquent\Model::fromDateTime` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
53			}
54
55			// Let Eloquent convert the value to a DateTime instance.
56			if (!$value instanceof DateTime) {
			0 ignored issues – show Bug introduced 2017-03-20 19:45 UTC by Report Bug Copy Issue Report The class `fuitad\LaravelCassandra\Eloquent\DateTime` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
57			$value = parent::asDateTime($value);
			0 ignored issues – show Comprehensibility Bug introduced 2017-03-20 19:45 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`asDateTime()` instead of `fromDateTime()`). Are you sure this is correct? If so, you might want to change this to `$this->asDateTime()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
58			}
59
60			return new Timestamp($value->getTimestamp() * 1000);
			0 ignored issues – show Bug Best Practice introduced 2017-03-20 19:45 UTC by Report Bug Copy Issue Report The return type of `return new \Cassandra\Ti...getTimestamp() * 1000);` (`Cassandra\Timestamp`) is incompatible with the return type of the parent method `Illuminate\Database\Eloquent\Model::fromDateTime` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
61			}
62
63			/**
64			* @inheritdoc
65			*/
66			protected function asDateTime($value)
67			{
68			// Convert UTCDateTime instances.
69			if ($value instanceof Timestamp) {
			0 ignored issues – show Bug introduced 2017-03-20 19:45 UTC by Report Bug Copy Issue Report The class `Cassandra\Timestamp` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
70			return parent::asDateTime($value->toDateTime());
71			}
72
73			return parent::asDateTime($value);
74			}
75
76			/**
77			* @inheritdoc
78			*/
79			protected function originalIsNumericallyEquivalent($key)
80			{
81			$current = $this->attributes[$key];
82			$original = $this->original[$key];
83
84			// Date comparison.
85			if (in_array($key, $this->getDates())) {
86			$current = $current instanceof Timestamp ? $this->asDateTime($current) : $current;
			0 ignored issues – show Bug introduced 2017-03-20 19:45 UTC by Report Bug Copy Issue Report The class `Cassandra\Timestamp` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
87			$original = $original instanceof Timestamp ? $this->asDateTime($original) : $original;
			0 ignored issues – show Bug introduced 2017-03-20 19:45 UTC by Report Bug Copy Issue Report The class `Cassandra\Timestamp` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
88
89			return $current == $original;
90			}
91
92			return parent::originalIsNumericallyEquivalent($key);
93			}
94
95			/**
96			* Get the table qualified key name.
97			* Cassandra does not support the table.column annotation so
98			* we override this
99			*
100			* @return string
101			*/
102			public function getQualifiedKeyName()
103			{
104			return $this->getKeyName();
105			}
106
107			/**
108			* @inheritdoc
109			*/
110			public function __call($method, $parameters)
111			{
112			// Unset method
113			if ($method == 'unset') {
114			return call_user_func_array([$this, 'drop'], $parameters);
115			}
116
117			return parent::__call($method, $parameters);
118			}
119			}
120

Fuitad / laravel-cassandra

GitHub Access Token became invalid

Push — master ( da7eaf...ab8466 )

Model A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like