Connection::insertBulk() - Code Metrics - Inspection of "applying scrutinizer suggestions" - Fuitad/laravel-cassandra - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 84e839...633760 )

by Pierre-Luc

created 2017-03-22 14:16 UTC

Connection::insertBulk() A

↳ Parent: Connection

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	3

<?php

namespace fuitad\LaravelCassandra;

use Cassandra;
use Cassandra\BatchStatement;
use Cassandra\ExecutionOptions;

class Connection extends \Illuminate\Database\Connection
{
    /**
     * The Cassandra keyspace
     *
     * @var string
     */
    protected $keyspace;

    /**
     * The Cassandra cluster
     *
     * @var \Cassandra\Cluster
     */
    protected $cluster;

    /**
     * The Cassandra connection handler.
     *
     * @var \Cassandra\Session
     */
    protected $session;

    /**
     * Create a new database connection instance.
     *
     * @param  array   $config
     */
    public function __construct(array $config)
    {
        $this->config = $config;

        // You can pass options directly to the Cassandra constructor
        $options = array_get($config, 'options', []);

        // Create the connection
        $this->cluster = $this->createCluster(null, $config, $options);

        if (isset($options['keyspace']) || isset($config['keyspace'])) {
            $this->keyspace = $config['keyspace'];
            $this->session = $this->cluster->connect($config['keyspace']);
        }

        $this->useDefaultPostProcessor();

        $this->useDefaultSchemaGrammar();

        $this->setQueryGrammar($this->getDefaultQueryGrammar());
    }

    /**
     * Begin a fluent query against a database table.
     *
     * @param  string  $table
     * @return Query\Builder
     */
    public function table($table)
    {
        $processor = $this->getPostProcessor();

        $query = new Query\Builder($this, $processor);


        return $query->from($table);
    }

    /**
     * return Cassandra cluster.
     *
     * @return \Cassandra\Cluster
     */
    public function getCassandraCluster()
    {
        return $this->cluster;
    }

    /**
     * return Cassandra Session.
     *
     * @return \Cassandra\Session
     */
    public function getCassandraSession()
    {
        return $this->session;
    }

    /**
     * Return the Cassandra keyspace
     *
     * @return string
     */
    public function getKeyspace()
    {
        return $this->keyspace;
    }

    /**
     * Create a new Cassandra cluster object.
     *
     * @param  string  $dsn
     * @param  array   $config
     * @param  array   $options
     * @return \Cassandra\Cluster
     */
    protected function createCluster($dsn, array $config, array $options)

    {
        // By default driver options is an empty array.
        $driverOptions = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if (isset($config['driver_options']) && is_array($config['driver_options'])) {
            $driverOptions = $config['driver_options'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }

        $cluster = Cassandra::cluster();

        // Check if the credentials are not already set in the options
        if (!isset($options['username']) && !empty($config['username'])) {
            $options['username'] = $config['username'];
        }
        if (!isset($options['password']) && !empty($config['password'])) {
            $options['password'] = $config['password'];
        }

        // Authentication
        if (isset($options['username']) && isset($options['password'])) {
            $cluster->withCredentials($options['username'], $options['password']);
        }

        // Contact Points/Host
        if (isset($options['contactpoints']) || (isset($config['host']) && !empty($config['host']))) {
            $contactPoints = $config['host'];

            if (isset($options['contactpoints'])) {
                $contactPoints = $options['contactpoints'];
            }

            $cluster->withContactPoints($contactPoints);
        }

        if (!isset($options['port']) && !empty($config['port'])) {
            $cluster->withPort((int) $config['port']);
        }

        return $cluster->build();
    }

    /**
     * Disconnect from the underlying Cassandra connection.
     */
    public function disconnect()
    {
        unset($this->connection);
    }

    /**
     * Get the PDO driver name.
     *
     * @return string
     */
    public function getDriverName()
    {
        return 'cassandra';
    }

    /**
     * Run a select statement against the database.
     *
     * @param  string  $query
     * @param  array  $bindings
     * @param  bool  $useReadPdo
     * @return array
     */
    public function select($query, $bindings = [], $useReadPdo = true)

    {
        return $this->run($query, $bindings, function ($query, $bindings) use ($useReadPdo) {
            if ($this->pretending()) {
                return [];
            }

            $preparedStatement = $this->session->prepare($query);

            return $this->session->execute($preparedStatement, new ExecutionOptions(['arguments' => $bindings]));
        });
    }

    /**
     * Run an bulk insert statement against the database.
     *
     * @param  array  $queries
     * @param  array  $bindings
     * @return bool
     */
    public function insertBulk($queries = [], $bindings = [], $type = Cassandra::BATCH_LOGGED)
    {
        return $this->batchStatement($queries, $bindings, $type);
    }

    /**
     * Execute a group of queries inside a batch statement against the database.
     *
     * @param  array  $queries
     * @param  array  $bindings
     * @return bool
     */
    public function batchStatement($queries = [], $bindings = [], $type = Cassandra::BATCH_LOGGED)

    {
        return $this->run($queries, $bindings, function ($queries, $bindings) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            if ($this->pretending()) {
                return [];
            }

            $batch = new BatchStatement(Cassandra::BATCH_LOGGED);

            foreach ($queries as $k => $query) {
                $preparedStatement = $this->session->prepare($query);
                $batch->add($preparedStatement, $bindings[$k]);
            }

            return $this->session->execute($batch);
        });
    }

    /**
     * Execute an SQL statement and return the boolean result.
     *
     * @param  string  $query
     * @param  array   $bindings
     * @return bool
     */
    public function statement($query, $bindings = [])

    {
        return $this->run($query, $bindings, function ($query, $bindings) {
            if ($this->pretending()) {
                return [];
            }

            $preparedStatement = $this->session->prepare($query);

            return $this->session->execute($preparedStatement, new ExecutionOptions(['arguments' => $bindings]));
        });
    }

    /**
     * Because Cassandra is an eventually consistent database, it's not possible to obtain
     * the affected count for statements so we're just going to return 0, based on the idea
     * that if the query fails somehow, an exception will be thrown
     *
     * @param  string  $query
     * @param  array   $bindings
     * @return int
     */
    public function affectingStatement($query, $bindings = [])

    {
        return $this->run($query, $bindings, function ($query, $bindings) {
            if ($this->pretending()) {
                return 0;
            }

            $preparedStatement = $this->session->prepare($query);

            $this->session->execute($preparedStatement, new ExecutionOptions(['arguments' => $bindings]));

            return 1;
        });
    }

    /**
     * @inheritdoc
     */
    protected function getDefaultPostProcessor()
    {
        return new Query\Processor();
    }

    /**
     * @inheritdoc
     */
    protected function getDefaultQueryGrammar()
    {
        return new Query\Grammar();
    }

    /**
     * @inheritdoc
     */
    protected function getDefaultSchemaGrammar()
    {
        //return new Schema\Grammar();

    }

    /**
     * Dynamically pass methods to the connection.
     *
     * @param  string  $method
     * @param  array   $parameters
     * @return mixed
     */
    public function __call($method, $parameters)
    {
        return call_user_func_array([$this->cluster, $method], $parameters);
    }
}


1		<?php
2
3		namespace fuitad\LaravelCassandra;
4
5		use Cassandra;
6		use Cassandra\BatchStatement;
7		use Cassandra\ExecutionOptions;
8
9		class Connection extends \Illuminate\Database\Connection
10		{
11		/**
12		* The Cassandra keyspace
13		*
14		* @var string
15		*/
16		protected $keyspace;
17
18		/**
19		* The Cassandra cluster
20		*
21		* @var \Cassandra\Cluster
22		*/
23		protected $cluster;
24
25		/**
26		* The Cassandra connection handler.
27		*
28		* @var \Cassandra\Session
29		*/
30		protected $session;
31
32		/**
33		* Create a new database connection instance.
34		*
35		* @param array $config
36		*/
37		public function __construct(array $config)
38		{
39		$this->config = $config;
40
41		// You can pass options directly to the Cassandra constructor
42		$options = array_get($config, 'options', []);
43
44		// Create the connection
45		$this->cluster = $this->createCluster(null, $config, $options);
46
47		if (isset($options['keyspace']) \|\| isset($config['keyspace'])) {
48		$this->keyspace = $config['keyspace'];
49		$this->session = $this->cluster->connect($config['keyspace']);
50		}
51
52		$this->useDefaultPostProcessor();
53
54		$this->useDefaultSchemaGrammar();
55
56		$this->setQueryGrammar($this->getDefaultQueryGrammar());
57		}
58
59		/**
60		* Begin a fluent query against a database table.
61		*
62		* @param string $table
63		* @return Query\Builder
64		*/
65		public function table($table)
66		{
67		$processor = $this->getPostProcessor();
68
69		$query = new Query\Builder($this, $processor);
		0 ignored issues – show Compatibility introduced 2017-03-20 17:24 UTC by Report Bug Copy Issue Report `$processor` of type `object<Illuminate\Databa...y\Processors\Processor>` is not a sub-type of `object<fuitad\LaravelCassandra\Query\Processor>`. It seems like you assume a child class of the class `Illuminate\Database\Query\Processors\Processor` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
70
71		return $query->from($table);
72		}
73
74		/**
75		* return Cassandra cluster.
76		*
77		* @return \Cassandra\Cluster
78		*/
79		public function getCassandraCluster()
80		{
81		return $this->cluster;
82		}
83
84		/**
85		* return Cassandra Session.
86		*
87		* @return \Cassandra\Session
88		*/
89		public function getCassandraSession()
90		{
91		return $this->session;
92		}
93
94		/**
95		* Return the Cassandra keyspace
96		*
97		* @return string
98		*/
99		public function getKeyspace()
100		{
101		return $this->keyspace;
102		}
103
104		/**
105		* Create a new Cassandra cluster object.
106		*
107		* @param string $dsn
108		* @param array $config
109		* @param array $options
110		* @return \Cassandra\Cluster
111		*/
112		protected function createCluster($dsn, array $config, array $options)
		0 ignored issues – show Unused Code introduced 2017-03-20 17:24 UTC by Report Bug Copy Issue Report The parameter `$dsn` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
113		{
114		// By default driver options is an empty array.
115		$driverOptions = [];
		0 ignored issues – show Unused Code introduced 2017-03-20 17:24 UTC by Report Bug Copy Issue Report `$driverOptions` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
116
117		if (isset($config['driver_options']) && is_array($config['driver_options'])) {
118		$driverOptions = $config['driver_options'];
		0 ignored issues – show Unused Code introduced 2017-03-20 17:24 UTC by Report Bug Copy Issue Report `$driverOptions` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
119		}
120
121		$cluster = Cassandra::cluster();
122
123		// Check if the credentials are not already set in the options
124	View Code Duplication	if (!isset($options['username']) && !empty($config['username'])) {
125		$options['username'] = $config['username'];
126		}
127	View Code Duplication	if (!isset($options['password']) && !empty($config['password'])) {
128		$options['password'] = $config['password'];
129		}
130
131		// Authentication
132		if (isset($options['username']) && isset($options['password'])) {
133		$cluster->withCredentials($options['username'], $options['password']);
134		}
135
136		// Contact Points/Host
137		if (isset($options['contactpoints']) \|\| (isset($config['host']) && !empty($config['host']))) {
138		$contactPoints = $config['host'];
139
140		if (isset($options['contactpoints'])) {
141		$contactPoints = $options['contactpoints'];
142		}
143
144		$cluster->withContactPoints($contactPoints);
145		}
146
147		if (!isset($options['port']) && !empty($config['port'])) {
148		$cluster->withPort((int) $config['port']);
149		}
150
151		return $cluster->build();
152		}
153
154		/**
155		* Disconnect from the underlying Cassandra connection.
156		*/
157		public function disconnect()
158		{
159		unset($this->connection);
160		}
161
162		/**
163		* Get the PDO driver name.
164		*
165		* @return string
166		*/
167		public function getDriverName()
168		{
169		return 'cassandra';
170		}
171
172		/**
173		* Run a select statement against the database.
174		*
175		* @param string $query
176		* @param array $bindings
177		* @param bool $useReadPdo
178		* @return array
179		*/
180	View Code Duplication	public function select($query, $bindings = [], $useReadPdo = true)
		0 ignored issues – show Duplication introduced 2017-03-20 17:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
181		{
182		return $this->run($query, $bindings, function ($query, $bindings) use ($useReadPdo) {
183		if ($this->pretending()) {
184		return [];
185		}
186
187		$preparedStatement = $this->session->prepare($query);
188
189		return $this->session->execute($preparedStatement, new ExecutionOptions(['arguments' => $bindings]));
190		});
191		}
192
193		/**
194		* Run an bulk insert statement against the database.
195		*
196		* @param array $queries
197		* @param array $bindings
198		* @return bool
199		*/
200		public function insertBulk($queries = [], $bindings = [], $type = Cassandra::BATCH_LOGGED)
201		{
202		return $this->batchStatement($queries, $bindings, $type);
203		}
204
205		/**
206		* Execute a group of queries inside a batch statement against the database.
207		*
208		* @param array $queries
209		* @param array $bindings
210		* @return bool
211		*/
212		public function batchStatement($queries = [], $bindings = [], $type = Cassandra::BATCH_LOGGED)
		0 ignored issues – show Unused Code introduced 2017-03-21 16:17 UTC by Report Bug Copy Issue Report The parameter `$type` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
213		{
214		return $this->run($queries, $bindings, function ($queries, $bindings) {
		0 ignored issues – show Documentation introduced 2017-03-21 16:17 UTC by Report Bug Copy Issue Report `$queries` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
215		if ($this->pretending()) {
216		return [];
217		}
218
219		$batch = new BatchStatement(Cassandra::BATCH_LOGGED);
220
221		foreach ($queries as $k => $query) {
222		$preparedStatement = $this->session->prepare($query);
223		$batch->add($preparedStatement, $bindings[$k]);
224		}
225
226		return $this->session->execute($batch);
227		});
228		}
229
230		/**
231		* Execute an SQL statement and return the boolean result.
232		*
233		* @param string $query
234		* @param array $bindings
235		* @return bool
236		*/
237	View Code Duplication	public function statement($query, $bindings = [])
		0 ignored issues – show Duplication introduced 2017-03-20 17:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
238		{
239		return $this->run($query, $bindings, function ($query, $bindings) {
240		if ($this->pretending()) {
241		return [];
242		}
243
244		$preparedStatement = $this->session->prepare($query);
245
246		return $this->session->execute($preparedStatement, new ExecutionOptions(['arguments' => $bindings]));
247		});
248		}
249
250		/**
251		* Because Cassandra is an eventually consistent database, it's not possible to obtain
252		* the affected count for statements so we're just going to return 0, based on the idea
253		* that if the query fails somehow, an exception will be thrown
254		*
255		* @param string $query
256		* @param array $bindings
257		* @return int
258		*/
259	View Code Duplication	public function affectingStatement($query, $bindings = [])
		0 ignored issues – show Duplication introduced 2017-03-20 17:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
260		{
261		return $this->run($query, $bindings, function ($query, $bindings) {
262		if ($this->pretending()) {
263		return 0;
264		}
265
266		$preparedStatement = $this->session->prepare($query);
267
268		$this->session->execute($preparedStatement, new ExecutionOptions(['arguments' => $bindings]));
269
270		return 1;
271		});
272		}
273
274		/**
275		* @inheritdoc
276		*/
277		protected function getDefaultPostProcessor()
278		{
279		return new Query\Processor();
280		}
281
282		/**
283		* @inheritdoc
284		*/
285		protected function getDefaultQueryGrammar()
286		{
287		return new Query\Grammar();
288		}
289
290		/**
291		* @inheritdoc
292		*/
293		protected function getDefaultSchemaGrammar()
294		{
295		//return new Schema\Grammar();
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-20 19:45 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
296		}
297
298		/**
299		* Dynamically pass methods to the connection.
300		*
301		* @param string $method
302		* @param array $parameters
303		* @return mixed
304		*/
305		public function __call($method, $parameters)
306		{
307		return call_user_func_array([$this->cluster, $method], $parameters);
308		}
309		}
310

Fuitad / laravel-cassandra

GitHub Access Token became invalid

Push — master ( 84e839...633760 )

Connection::insertBulk() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like